[PATCH] [v2] ASoC: amd: vangogh: select CONFIG_SND_AMD_ACP_CONFIG
From: Arnd Bergmann arnd@arndb.de
The vangogh driver just gained a link time dependency that now causes randconfig builds to fail:
x86_64-linux-ld: sound/soc/amd/vangogh/pci-acp5x.o: in function `snd_acp5x_probe': pci-acp5x.c:(.text+0xbb): undefined reference to `snd_amd_acp_find_config'
Fixes: e89f45edb747e ("ASoC: amd: vangogh: Add check for acp config flags in vangogh platform") Signed-off-by: Arnd Bergmann arnd@arndb.de --- v2: select CONFIG_SND_AMD_ACP_CONFIG from all ACP5, not just VANGOGH_MACH. --- sound/soc/amd/Kconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/sound/soc/amd/Kconfig b/sound/soc/amd/Kconfig index 08e42082f5e96..713348508001a 100644 --- a/sound/soc/amd/Kconfig +++ b/sound/soc/amd/Kconfig @@ -71,6 +71,7 @@ config SND_SOC_AMD_RENOIR_MACH config SND_SOC_AMD_ACP5x tristate "AMD Audio Coprocessor-v5.x I2S support" depends on X86 && PCI + select SND_AMD_ACP_CONFIG help This option enables ACP v5.x support on AMD platform
On Mon, Jun 05, 2023 at 10:58:29AM +0200, Arnd Bergmann wrote:
From: Arnd Bergmann arnd@arndb.de
The vangogh driver just gained a link time dependency that now causes randconfig builds to fail:
Actually git copes fine with applying this on top of v1 so no problem here.
On Mon, Jun 5, 2023, at 14:48, Mark Brown wrote:
On Mon, Jun 05, 2023 at 10:58:29AM +0200, Arnd Bergmann wrote:
From: Arnd Bergmann arnd@arndb.de
The vangogh driver just gained a link time dependency that now causes randconfig builds to fail:
Actually git copes fine with applying this on top of v1 so no problem here.
Ok, good. There is no harm in having the dependency in both places, there is just a duplicate changelog text now with two commits, but that's probably still better than having another commit to revert the first.
Arnd
On Mon, 05 Jun 2023 10:58:29 +0200, Arnd Bergmann wrote:
The vangogh driver just gained a link time dependency that now causes randconfig builds to fail:
x86_64-linux-ld: sound/soc/amd/vangogh/pci-acp5x.o: in function `snd_acp5x_probe': pci-acp5x.c:(.text+0xbb): undefined reference to `snd_amd_acp_find_config'
[...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: amd: vangogh: select CONFIG_SND_AMD_ACP_CONFIG commit: 812a05256d673b2b9c5db906775d1e6625ba4787
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks, Mark
participants (3)
-
Arnd Bergmann -
Arnd Bergmann -
Mark Brown