Hi Benjamin,

ok, I will do so.

I will prepare a v2 of "[PATCH 3/4] hid-lenovo: Add support for X1 Tablet special keys and, LED control" which is affected by this change.

Thank you & best regards,

Dennis On 12.09.2016 17:53, Benjamin Tissoires wrote:

On Sep 12 2016 or thereabouts, Dennis Wassenberg wrote:

...

Add device id for Lenovo X1 Tablet Cover

Signed-off-by: Dennis Wassenberg dennis.wassenberg@secunet.com

quick comment:

this patch should be squashed with the next one where you add support of this device to the hid-lenovo module.

Cheers, Benjamin

...

drivers/hid/hid-core.c | 1 + drivers/hid/hid-ids.h | 1 + 2 files changed, 2 insertions(+)

diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c index 6add0b6..ba6a200 100644 --- a/drivers/hid/hid-core.c +++ b/drivers/hid/hid-core.c @@ -2111,6 +2111,7 @@ void hid_disconnect(struct hid_device *hdev) { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_NINTENDO, USB_DEVICE_ID_NINTENDO_WIIMOTE2) }, { HID_USB_DEVICE(USB_VENDOR_ID_RAZER, USB_DEVICE_ID_RAZER_BLADE_14) }, { HID_USB_DEVICE(USB_VENDOR_ID_CMEDIA, USB_DEVICE_ID_CM6533) },

• { HID_USB_DEVICE(USB_VENDOR_ID_LENOVO, USB_DEVICE_ID_LENOVO_X1_COVER) }, { }

};

diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h index 3466f0d..1f08fb5 100644 --- a/drivers/hid/hid-ids.h +++ b/drivers/hid/hid-ids.h @@ -615,6 +615,7 @@ #define USB_DEVICE_ID_LENOVO_CUSBKBD 0x6047 #define USB_DEVICE_ID_LENOVO_CBTKBD 0x6048 #define USB_DEVICE_ID_LENOVO_TPPRODOCK 0x6067 +#define USB_DEVICE_ID_LENOVO_X1_COVER 0x6085

#define USB_VENDOR_ID_LG 0x1fd2

#define USB_DEVICE_ID_LG_MULTITOUCH 0x0064

1.9.1