[alsa-devel] kernel oops related to the new HDA audio handling for DP MST
Hi
Recently I've encountered this error and as Hans de Goede's request I'm reporting this back to you. This happens while booting my laptop connected to docking station and without using one.
kernel: WARNING: CPU: 1 PID: 330 at sound/hda/hdac_component.c:290 snd_hdac_acomp_init+0xde/0x130 [snd_hda_core] There are 2 more "cut here", but they're almost identical so I've only included one in this email.
Don't know what will be valuable to you, but I'm willing to help test this and do what I'm told. So, how can I help?
More info about this particular kernel and issue, that led to this is at: https://bugzilla.redhat.com/show_bug.cgi?id=1757891
dmesg output:
Nov 26 18:05:45 kernel: microcode: microcode updated early to revision 0x2f, date = 2019-02-17 Nov 26 18:05:45 kernel: Linux version 5.4.0-0.rc8.git0.1.rhbz1757891.fc31.x86_64 (mockbuild@buildhw-10.phx2.fedoraproject.org) (gcc version 9.2.1 20190827 (Red Hat 9.2.1-1) (GCC)) #1 SMP Wed Nov 20 14:50:34 UTC 2019 Nov 26 18:05:45 kernel: Command line: BOOT_IMAGE=(hd0,gpt2)/vmlinuz-5.4.0-0.rc8.git0.1.rhbz1757891.fc31.x86_64 root=/dev/mapper/fedora-root ro resume=/dev/mapper/fedora-swap rd.lvm.lv=fedora/root rd.luks.uuid=luks-efd8b438-8f56-405a-8cea-88f83ca38d2b rd.lvm.lv=fedora/swap rhgb quiet ... ... ... Nov 26 18:06:16 kernel: ------------[ cut here ]------------ Nov 26 18:06:16 kernel: WARNING: CPU: 0 PID: 461 at sound/hda/hdac_component.c:290 snd_hdac_acomp_init+0xde/0x130 [snd_hda_core] Nov 26 18:06:16 kernel: Modules linked in: intel_rapl_msr intel_rapl_common iwldvm x86_pkg_temp_thermal intel_powerclamp snd_hda_codec_hdmi coretemp mac80211 snd_hda_codec_conexant snd_hda_codec_generic kvm_intel snd_hda_intel libarc4 snd_intel_nhlt kvm mei_wdt iTCO_wdt snd_hda_codec mei_hdcp iwlwifi irqbypass iTCO_vendor_support snd_hda_core intel_cstate snd_hwdep snd_seq intel_uncore snd_seq_device thinkpad_acpi joydev i2c_i801 wmi_bmof intel_rapl_perf snd_pcm pcspkr ledtrig_audio cfg80211 snd_timer mei_me snd mei soundcore lpc_ich rfkill binfmt_misc ip_tables dm_crypt i915 nouveau crct10dif_pclmul crc32_pclmul mxm_wmi crc32c_intel ttm i2c_algo_bit drm_kms_helper ghash_clmulni_intel sdhci_pci cqhci drm sdhci serio_raw e1000e firewire_ohci mmc_core firewire_core crc_itu_t wmi video fuse Nov 26 18:06:16 kernel: CPU: 0 PID: 461 Comm: kworker/0:2 Tainted: G W 5.4.0-0.rc8.git0.1.rhbz1757891.fc31.x86_64 #1 Nov 26 18:06:16 kernel: Hardware name: LENOVO 42844DG/42844DG, BIOS 8BET66WW (1.46 ) 06/14/2018 Nov 26 18:06:16 kernel: Workqueue: events azx_probe_work [snd_hda_intel] Nov 26 18:06:16 kernel: RIP: 0010:snd_hdac_acomp_init+0xde/0x130 [snd_hda_core] Nov 26 18:06:16 kernel: Code: 41 89 c4 85 c0 78 3a 45 31 e4 48 8b 44 24 08 65 48 33 04 25 28 00 00 00 75 22 48 83 c4 10 44 89 e0 5b 5d 41 5c 41 5d 41 5e c3 <0f> 0b 41 bc f0 ff ff ff eb d6 41 bc f4 ff ff ff eb ce e8 6b 7c 5f Nov 26 18:06:16 kernel: RSP: 0018:ffffa5e4002a3c28 EFLAGS: 00010286 Nov 26 18:06:16 kernel: RAX: ffff984ae816a7e8 RBX: ffff984aebf91000 RCX: ffff984aeb50c338 Nov 26 18:06:16 kernel: RDX: 0000000000000001 RSI: 0000000000000282 RDI: 0000000000000282 Nov 26 18:06:16 kernel: RBP: ffff984ae53e4df0 R08: 0000000000000282 R09: ffff984aebe4e738 Nov 26 18:06:16 kernel: R10: ffff984ae778a180 R11: ffffa5e4002a3c0f R12: ffffffffc0c270c0 Nov 26 18:06:16 kernel: R13: ffff984aeb50c0b0 R14: 0000000000000000 R15: 0000000000000001 Nov 26 18:06:16 kernel: FS: 0000000000000000(0000) GS:ffff984aee000000(0000) knlGS:0000000000000000 Nov 26 18:06:16 kernel: CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 Nov 26 18:06:16 kernel: CR2: 00007f3a343e8000 CR3: 000000035360a006 CR4: 00000000000606f0 Nov 26 18:06:16 kernel: Call Trace: Nov 26 18:06:16 kernel: generic_acomp_init+0x71/0x90 [snd_hda_codec_hdmi] Nov 26 18:06:16 kernel: patch_nvhdmi+0x58/0x60 [snd_hda_codec_hdmi] Nov 26 18:06:16 kernel: hda_codec_driver_probe+0x92/0x150 [snd_hda_codec] Nov 26 18:06:16 kernel: really_probe+0x298/0x3c0 Nov 26 18:06:16 kernel: driver_probe_device+0xb6/0x100 Nov 26 18:06:16 kernel: ? driver_allows_async_probing+0x50/0x50 Nov 26 18:06:16 kernel: bus_for_each_drv+0x7e/0xc0 Nov 26 18:06:16 kernel: __device_attach+0xdf/0x160 Nov 26 18:06:16 kernel: bus_probe_device+0x8e/0xa0 Nov 26 18:06:16 kernel: device_add+0x3a2/0x670 Nov 26 18:06:16 kernel: snd_hdac_device_register+0x12/0x60 [snd_hda_core] Nov 26 18:06:16 kernel: snd_hda_codec_configure+0x45/0x150 [snd_hda_codec] Nov 26 18:06:16 kernel: azx_codec_configure+0x2f/0x60 [snd_hda_codec] Nov 26 18:06:16 kernel: azx_probe_continue+0x48c/0x700 [snd_hda_intel] Nov 26 18:06:16 kernel: process_one_work+0x1b0/0x350 Nov 26 18:06:16 kernel: worker_thread+0x50/0x3b0 Nov 26 18:06:16 kernel: kthread+0xfb/0x130 Nov 26 18:06:16 kernel: ? process_one_work+0x350/0x350 Nov 26 18:06:16 kernel: ? kthread_park+0x90/0x90 Nov 26 18:06:16 kernel: ret_from_fork+0x35/0x40 Nov 26 18:06:16 kernel: ---[ end trace 3c8d65bedba62849 ]--- Nov 26 18:06:16 kernel: input: HDA NVidia HDMI/DP,pcm=3 as /devices/pci0000:00/0000:00:01.0/0000:01:00.1/sound/card1/input15 Nov 26 18:06:16 kernel: input: HDA NVidia HDMI/DP,pcm=7 as /devices/pci0000:00/0000:00:01.0/0000:01:00.1/sound/card1/input16 Nov 26 18:06:16 kernel: input: HDA NVidia HDMI/DP,pcm=8 as /devices/pci0000:00/0000:00:01.0/0000:01:00.1/sound/card1/input17 Nov 26 18:06:16 kernel: input: HDA NVidia HDMI/DP,pcm=9 as /devices/pci0000:00/0000:00:01.0/0000:01:00.1/sound/card1/input18
-- Regards, Michał Matysiak
On Wed, 27 Nov 2019 15:26:37 +0100, Michał Matysiak wrote:
Hi
Recently I've encountered this error and as Hans de Goede's request I'm reporting this back to you. This happens while booting my laptop connected to docking station and without using one.
kernel: WARNING: CPU: 1 PID: 330 at sound/hda/hdac_component.c:290 snd_hdac_acomp_init+0xde/0x130 [snd_hda_core] There are 2 more "cut here", but they're almost identical so I've only included one in this email.
Don't know what will be valuable to you, but I'm willing to help test this and do what I'm told. So, how can I help?
More info about this particular kernel and issue, that led to this is at: https://bugzilla.redhat.com/show_bug.cgi?id=1757891
dmesg output:
Nov 26 18:05:45 kernel: microcode: microcode updated early to revision 0x2f, date = 2019-02-17 Nov 26 18:05:45 kernel: Linux version 5.4.0-0.rc8.git0.1.rhbz1757891.fc31.x86_64 (mockbuild@buildhw-10.phx2.fedoraproject.org) (gcc version 9.2.1 20190827 (Red Hat 9.2.1-1) (GCC)) #1 SMP Wed Nov 20 14:50:34 UTC 2019 Nov 26 18:05:45 kernel: Command line: BOOT_IMAGE=(hd0,gpt2)/vmlinuz-5.4.0-0.rc8.git0.1.rhbz1757891.fc31.x86_64 root=/dev/mapper/fedora-root ro resume=/dev/mapper/fedora-swap rd.lvm.lv=fedora/root rd.luks.uuid=luks-efd8b438-8f56-405a-8cea-88f83ca38d2b rd.lvm.lv=fedora/swap rhgb quiet ... ... ... Nov 26 18:06:16 kernel: ------------[ cut here ]------------ Nov 26 18:06:16 kernel: WARNING: CPU: 0 PID: 461 at sound/hda/hdac_component.c:290 snd_hdac_acomp_init+0xde/0x130 [snd_hda_core]
This should have been already fixed by the recent commit 5a858e79c911330678b5a9be91a24830e94a0dc9 ALSA: hda - Disable audio component for legacy Nvidia HDMI codecs which is already included in Linus tree. Please check it.
thanks,
Takashi
Hi Takashi,
On 27-11-2019 15:39, Takashi Iwai wrote:
On Wed, 27 Nov 2019 15:26:37 +0100, Michał Matysiak wrote:
Hi
Recently I've encountered this error and as Hans de Goede's request I'm reporting this back to you. This happens while booting my laptop connected to docking station and without using one.
kernel: WARNING: CPU: 1 PID: 330 at sound/hda/hdac_component.c:290 snd_hdac_acomp_init+0xde/0x130 [snd_hda_core] There are 2 more "cut here", but they're almost identical so I've only included one in this email.
Don't know what will be valuable to you, but I'm willing to help test this and do what I'm told. So, how can I help?
More info about this particular kernel and issue, that led to this is at: https://bugzilla.redhat.com/show_bug.cgi?id=1757891
dmesg output:
Nov 26 18:05:45 kernel: microcode: microcode updated early to revision 0x2f, date = 2019-02-17 Nov 26 18:05:45 kernel: Linux version 5.4.0-0.rc8.git0.1.rhbz1757891.fc31.x86_64 (mockbuild@buildhw-10.phx2.fedoraproject.org) (gcc version 9.2.1 20190827 (Red Hat 9.2.1-1) (GCC)) #1 SMP Wed Nov 20 14:50:34 UTC 2019 Nov 26 18:05:45 kernel: Command line: BOOT_IMAGE=(hd0,gpt2)/vmlinuz-5.4.0-0.rc8.git0.1.rhbz1757891.fc31.x86_64 root=/dev/mapper/fedora-root ro resume=/dev/mapper/fedora-swap rd.lvm.lv=fedora/root rd.luks.uuid=luks-efd8b438-8f56-405a-8cea-88f83ca38d2b rd.lvm.lv=fedora/swap rhgb quiet ... ... ... Nov 26 18:06:16 kernel: ------------[ cut here ]------------ Nov 26 18:06:16 kernel: WARNING: CPU: 0 PID: 461 at sound/hda/hdac_component.c:290 snd_hdac_acomp_init+0xde/0x130 [snd_hda_core]
This should have been already fixed by the recent commit 5a858e79c911330678b5a9be91a24830e94a0dc9 ALSA: hda - Disable audio component for legacy Nvidia HDMI codecs which is already included in Linus tree. Please check it.
Thanks, I've started a scratch kernel build with the relevant patches added, for the Fedora users hitting this to test.
The reason they started looking into their dmesg is that their nvidia GPU (hybrid gfx setup) will no longer suspend with recent kernels, this is with a 5.4 kernel which already has the
"ALSA: hda - Force runtime PM on Nvidia HDMI codecs"
Fix and for good measure I've already given them a test kernel with the: "ALSA: hda: Allow HDA to be runtime suspended when dGPU is not bound to a drive"
patch added. But looking at the fix for the oops I'm not sure if fixing the oops is also going to fix the issue with the dGPU no longer suspending?
Anyways lets wait for Michal or other Fedora users to test and see from there.
Regards,
Hans
On Wed, 27 Nov 2019 16:46:00 +0100, Hans de Goede wrote:
Hi Takashi,
On 27-11-2019 15:39, Takashi Iwai wrote:
On Wed, 27 Nov 2019 15:26:37 +0100, Michał Matysiak wrote:
Hi
Recently I've encountered this error and as Hans de Goede's request I'm reporting this back to you. This happens while booting my laptop connected to docking station and without using one.
kernel: WARNING: CPU: 1 PID: 330 at sound/hda/hdac_component.c:290 snd_hdac_acomp_init+0xde/0x130 [snd_hda_core] There are 2 more "cut here", but they're almost identical so I've only included one in this email.
Don't know what will be valuable to you, but I'm willing to help test this and do what I'm told. So, how can I help?
More info about this particular kernel and issue, that led to this is at: https://bugzilla.redhat.com/show_bug.cgi?id=1757891
dmesg output:
Nov 26 18:05:45 kernel: microcode: microcode updated early to revision 0x2f, date = 2019-02-17 Nov 26 18:05:45 kernel: Linux version 5.4.0-0.rc8.git0.1.rhbz1757891.fc31.x86_64 (mockbuild@buildhw-10.phx2.fedoraproject.org) (gcc version 9.2.1 20190827 (Red Hat 9.2.1-1) (GCC)) #1 SMP Wed Nov 20 14:50:34 UTC 2019 Nov 26 18:05:45 kernel: Command line: BOOT_IMAGE=(hd0,gpt2)/vmlinuz-5.4.0-0.rc8.git0.1.rhbz1757891.fc31.x86_64 root=/dev/mapper/fedora-root ro resume=/dev/mapper/fedora-swap rd.lvm.lv=fedora/root rd.luks.uuid=luks-efd8b438-8f56-405a-8cea-88f83ca38d2b rd.lvm.lv=fedora/swap rhgb quiet ... ... ... Nov 26 18:06:16 kernel: ------------[ cut here ]------------ Nov 26 18:06:16 kernel: WARNING: CPU: 0 PID: 461 at sound/hda/hdac_component.c:290 snd_hdac_acomp_init+0xde/0x130 [snd_hda_core]
This should have been already fixed by the recent commit 5a858e79c911330678b5a9be91a24830e94a0dc9 ALSA: hda - Disable audio component for legacy Nvidia HDMI codecs which is already included in Linus tree. Please check it.
Thanks, I've started a scratch kernel build with the relevant patches added, for the Fedora users hitting this to test.
The reason they started looking into their dmesg is that their nvidia GPU (hybrid gfx setup) will no longer suspend with recent kernels, this is with a 5.4 kernel which already has the
"ALSA: hda - Force runtime PM on Nvidia HDMI codecs"
Fix and for good measure I've already given them a test kernel with the: "ALSA: hda: Allow HDA to be runtime suspended when dGPU is not bound to a drive"
patch added. But looking at the fix for the oops I'm not sure if fixing the oops is also going to fix the issue with the dGPU no longer suspending?
I guess it's irrelevant with that problem, as this kernel warning (not really an Oops) is just about skipping the multiple audio component registration. And the audio component isn't used in nouveau side on 5.4.x at all, and it's just a placeholder. But who knows the black magic behind the scene :)
BTW, I submitted the backport of this (with another compile warning fix) for 5.4.y shortly ago, so hopefully this one will be covered soon later.
Takashi
Anyways lets wait for Michal or other Fedora users to test and see from there.
Regards,
Hans
On Wed, 27 Nov 2019 16:57:04 +0100, Takashi Iwai wrote:
On Wed, 27 Nov 2019 16:46:00 +0100, Hans de Goede wrote:
Hi Takashi,
On 27-11-2019 15:39, Takashi Iwai wrote:
On Wed, 27 Nov 2019 15:26:37 +0100, Michał Matysiak wrote:
Hi
Recently I've encountered this error and as Hans de Goede's request I'm reporting this back to you. This happens while booting my laptop connected to docking station and without using one.
kernel: WARNING: CPU: 1 PID: 330 at sound/hda/hdac_component.c:290 snd_hdac_acomp_init+0xde/0x130 [snd_hda_core] There are 2 more "cut here", but they're almost identical so I've only included one in this email.
Don't know what will be valuable to you, but I'm willing to help test this and do what I'm told. So, how can I help?
More info about this particular kernel and issue, that led to this is at: https://bugzilla.redhat.com/show_bug.cgi?id=1757891
dmesg output:
Nov 26 18:05:45 kernel: microcode: microcode updated early to revision 0x2f, date = 2019-02-17 Nov 26 18:05:45 kernel: Linux version 5.4.0-0.rc8.git0.1.rhbz1757891.fc31.x86_64 (mockbuild@buildhw-10.phx2.fedoraproject.org) (gcc version 9.2.1 20190827 (Red Hat 9.2.1-1) (GCC)) #1 SMP Wed Nov 20 14:50:34 UTC 2019 Nov 26 18:05:45 kernel: Command line: BOOT_IMAGE=(hd0,gpt2)/vmlinuz-5.4.0-0.rc8.git0.1.rhbz1757891.fc31.x86_64 root=/dev/mapper/fedora-root ro resume=/dev/mapper/fedora-swap rd.lvm.lv=fedora/root rd.luks.uuid=luks-efd8b438-8f56-405a-8cea-88f83ca38d2b rd.lvm.lv=fedora/swap rhgb quiet ... ... ... Nov 26 18:06:16 kernel: ------------[ cut here ]------------ Nov 26 18:06:16 kernel: WARNING: CPU: 0 PID: 461 at sound/hda/hdac_component.c:290 snd_hdac_acomp_init+0xde/0x130 [snd_hda_core]
This should have been already fixed by the recent commit 5a858e79c911330678b5a9be91a24830e94a0dc9 ALSA: hda - Disable audio component for legacy Nvidia HDMI codecs which is already included in Linus tree. Please check it.
Thanks, I've started a scratch kernel build with the relevant patches added, for the Fedora users hitting this to test.
The reason they started looking into their dmesg is that their nvidia GPU (hybrid gfx setup) will no longer suspend with recent kernels, this is with a 5.4 kernel which already has the
"ALSA: hda - Force runtime PM on Nvidia HDMI codecs"
Fix and for good measure I've already given them a test kernel with the: "ALSA: hda: Allow HDA to be runtime suspended when dGPU is not bound to a drive"
patch added. But looking at the fix for the oops I'm not sure if fixing the oops is also going to fix the issue with the dGPU no longer suspending?
I guess it's irrelevant with that problem, as this kernel warning (not really an Oops) is just about skipping the multiple audio component registration. And the audio component isn't used in nouveau side on 5.4.x at all, and it's just a placeholder. But who knows the black magic behind the scene :)
... and if this still doesn't fix the problem, please check the runtime PM state of all HD-audio codec devices and HD-audio controller device. Do all show the runtime-suspended but the power consumption is high? Or is some device blocked?
Basically the audio controller corresponding to the dGPU should have chip->bus.keep_power = 0, which allows the runtime PM. This flag is cleared at azx_vx_gpu_bound() only for the dGPU. For the primary GPU, we need to keep the link power unless the notification is done via the audio component (like i915 or amdgpu). I already submitted a patch to enable the audio component for nouveau in the past, but it's ignored, so far.
thanks,
Takashi
On Wed, Nov 27, 2019 at 06:00:17PM +0100, Takashi Iwai wrote:
On Wed, 27 Nov 2019 16:57:04 +0100, Takashi Iwai wrote:
On Wed, 27 Nov 2019 16:46:00 +0100, Hans de Goede wrote:
Hi Takashi,
On 27-11-2019 15:39, Takashi Iwai wrote:
On Wed, 27 Nov 2019 15:26:37 +0100, Michał Matysiak wrote:
Hi
Recently I've encountered this error and as Hans de Goede's request I'm reporting this back to you. This happens while booting my laptop connected to docking station and without using one.
kernel: WARNING: CPU: 1 PID: 330 at sound/hda/hdac_component.c:290 snd_hdac_acomp_init+0xde/0x130 [snd_hda_core] There are 2 more "cut here", but they're almost identical so I've only included one in this email.
Don't know what will be valuable to you, but I'm willing to help test this and do what I'm told. So, how can I help?
More info about this particular kernel and issue, that led to this is at: https://bugzilla.redhat.com/show_bug.cgi?id=1757891
dmesg output:
Nov 26 18:05:45 kernel: microcode: microcode updated early to revision 0x2f, date = 2019-02-17 Nov 26 18:05:45 kernel: Linux version 5.4.0-0.rc8.git0.1.rhbz1757891.fc31.x86_64 (mockbuild@buildhw-10.phx2.fedoraproject.org) (gcc version 9.2.1 20190827 (Red Hat 9.2.1-1) (GCC)) #1 SMP Wed Nov 20 14:50:34 UTC 2019 Nov 26 18:05:45 kernel: Command line: BOOT_IMAGE=(hd0,gpt2)/vmlinuz-5.4.0-0.rc8.git0.1.rhbz1757891.fc31.x86_64 root=/dev/mapper/fedora-root ro resume=/dev/mapper/fedora-swap rd.lvm.lv=fedora/root rd.luks.uuid=luks-efd8b438-8f56-405a-8cea-88f83ca38d2b rd.lvm.lv=fedora/swap rhgb quiet ... ... ... Nov 26 18:06:16 kernel: ------------[ cut here ]------------ Nov 26 18:06:16 kernel: WARNING: CPU: 0 PID: 461 at sound/hda/hdac_component.c:290 snd_hdac_acomp_init+0xde/0x130 [snd_hda_core]
This should have been already fixed by the recent commit 5a858e79c911330678b5a9be91a24830e94a0dc9 ALSA: hda - Disable audio component for legacy Nvidia HDMI codecs which is already included in Linus tree. Please check it.
Thanks, I've started a scratch kernel build with the relevant patches added, for the Fedora users hitting this to test.
The reason they started looking into their dmesg is that their nvidia GPU (hybrid gfx setup) will no longer suspend with recent kernels, this is with a 5.4 kernel which already has the
"ALSA: hda - Force runtime PM on Nvidia HDMI codecs"
Fix and for good measure I've already given them a test kernel with the: "ALSA: hda: Allow HDA to be runtime suspended when dGPU is not bound to a drive"
patch added. But looking at the fix for the oops I'm not sure if fixing the oops is also going to fix the issue with the dGPU no longer suspending?
I guess it's irrelevant with that problem, as this kernel warning (not really an Oops) is just about skipping the multiple audio component registration. And the audio component isn't used in nouveau side on 5.4.x at all, and it's just a placeholder. But who knows the black magic behind the scene :)
... and if this still doesn't fix the problem, please check the runtime PM state of all HD-audio codec devices and HD-audio controller device. Do all show the runtime-suspended but the power consumption is high? Or is some device blocked?
Basically the audio controller corresponding to the dGPU should have chip->bus.keep_power = 0, which allows the runtime PM. This flag is cleared at azx_vx_gpu_bound() only for the dGPU. For the primary GPU, we need to keep the link power unless the notification is done via the audio component (like i915 or amdgpu). I already submitted a patch to enable the audio component for nouveau in the past, but it's ignored, so far.
thanks,
Takashi
Hi Takashi
On linux-next-20191127 warning indeed disappeared. Thanks!
Rest of problems did not. This is my output from alsa-info.sh http://alsa-project.org/db/?f=91bb789a01f9eed92d0534fe8951619312b355da Don't know if it's helpful, so I'll leave it here. Power consumption is high, because runtime-suspended is not enabled/active (and cannot be forced) without removing nvidia's audio.
Regards, Michał Matysiak
On Wed, 27 Nov 2019 19:52:37 +0100, Michał Matysiak wrote:
On Wed, Nov 27, 2019 at 06:00:17PM +0100, Takashi Iwai wrote:
On Wed, 27 Nov 2019 16:57:04 +0100, Takashi Iwai wrote:
On Wed, 27 Nov 2019 16:46:00 +0100, Hans de Goede wrote:
Hi Takashi,
On 27-11-2019 15:39, Takashi Iwai wrote:
On Wed, 27 Nov 2019 15:26:37 +0100, Michał Matysiak wrote:
Hi
Recently I've encountered this error and as Hans de Goede's request I'm reporting this back to you. This happens while booting my laptop connected to docking station and without using one.
kernel: WARNING: CPU: 1 PID: 330 at sound/hda/hdac_component.c:290 snd_hdac_acomp_init+0xde/0x130 [snd_hda_core] There are 2 more "cut here", but they're almost identical so I've only included one in this email.
Don't know what will be valuable to you, but I'm willing to help test this and do what I'm told. So, how can I help?
More info about this particular kernel and issue, that led to this is at: https://bugzilla.redhat.com/show_bug.cgi?id=1757891
dmesg output:
Nov 26 18:05:45 kernel: microcode: microcode updated early to revision 0x2f, date = 2019-02-17 Nov 26 18:05:45 kernel: Linux version 5.4.0-0.rc8.git0.1.rhbz1757891.fc31.x86_64 (mockbuild@buildhw-10.phx2.fedoraproject.org) (gcc version 9.2.1 20190827 (Red Hat 9.2.1-1) (GCC)) #1 SMP Wed Nov 20 14:50:34 UTC 2019 Nov 26 18:05:45 kernel: Command line: BOOT_IMAGE=(hd0,gpt2)/vmlinuz-5.4.0-0.rc8.git0.1.rhbz1757891.fc31.x86_64 root=/dev/mapper/fedora-root ro resume=/dev/mapper/fedora-swap rd.lvm.lv=fedora/root rd.luks.uuid=luks-efd8b438-8f56-405a-8cea-88f83ca38d2b rd.lvm.lv=fedora/swap rhgb quiet ... ... ... Nov 26 18:06:16 kernel: ------------[ cut here ]------------ Nov 26 18:06:16 kernel: WARNING: CPU: 0 PID: 461 at sound/hda/hdac_component.c:290 snd_hdac_acomp_init+0xde/0x130 [snd_hda_core]
This should have been already fixed by the recent commit 5a858e79c911330678b5a9be91a24830e94a0dc9 ALSA: hda - Disable audio component for legacy Nvidia HDMI codecs which is already included in Linus tree. Please check it.
Thanks, I've started a scratch kernel build with the relevant patches added, for the Fedora users hitting this to test.
The reason they started looking into their dmesg is that their nvidia GPU (hybrid gfx setup) will no longer suspend with recent kernels, this is with a 5.4 kernel which already has the
"ALSA: hda - Force runtime PM on Nvidia HDMI codecs"
Fix and for good measure I've already given them a test kernel with the: "ALSA: hda: Allow HDA to be runtime suspended when dGPU is not bound to a drive"
patch added. But looking at the fix for the oops I'm not sure if fixing the oops is also going to fix the issue with the dGPU no longer suspending?
I guess it's irrelevant with that problem, as this kernel warning (not really an Oops) is just about skipping the multiple audio component registration. And the audio component isn't used in nouveau side on 5.4.x at all, and it's just a placeholder. But who knows the black magic behind the scene :)
... and if this still doesn't fix the problem, please check the runtime PM state of all HD-audio codec devices and HD-audio controller device. Do all show the runtime-suspended but the power consumption is high? Or is some device blocked?
Basically the audio controller corresponding to the dGPU should have chip->bus.keep_power = 0, which allows the runtime PM. This flag is cleared at azx_vx_gpu_bound() only for the dGPU. For the primary GPU, we need to keep the link power unless the notification is done via the audio component (like i915 or amdgpu). I already submitted a patch to enable the audio component for nouveau in the past, but it's ignored, so far.
thanks,
Takashi
Hi Takashi
On linux-next-20191127 warning indeed disappeared. Thanks!
Rest of problems did not. This is my output from alsa-info.sh http://alsa-project.org/db/?f=91bb789a01f9eed92d0534fe8951619312b355da Don't know if it's helpful, so I'll leave it here. Power consumption is high, because runtime-suspended is not enabled/active (and cannot be forced) without removing nvidia's audio.
What if you pass power_save=1 to snd-hda-intel option?
echo -n 1 > /sys/module/snd_hda_intel/parameters/power_save
This should enable the runtime PM on all HD-audio stuff. You can adjust via runtime sysfs entries for each device, while the above is a one-shot change.
This isn't a solution, but let's see whether the runtime PM itself works or not.
Takashi
On Wed, 27 Nov 2019 20:24:49 +0100, Takashi Iwai wrote:
On Wed, 27 Nov 2019 19:52:37 +0100, Michał Matysiak wrote:
On Wed, Nov 27, 2019 at 06:00:17PM +0100, Takashi Iwai wrote:
On Wed, 27 Nov 2019 16:57:04 +0100, Takashi Iwai wrote:
On Wed, 27 Nov 2019 16:46:00 +0100, Hans de Goede wrote:
Hi Takashi,
On 27-11-2019 15:39, Takashi Iwai wrote:
On Wed, 27 Nov 2019 15:26:37 +0100, Michał Matysiak wrote: > > Hi > > Recently I've encountered this error and as Hans de Goede's request I'm > reporting this back to you. This happens while booting my laptop > connected to docking station and without using one. > > kernel: WARNING: CPU: 1 PID: 330 at sound/hda/hdac_component.c:290 snd_hdac_acomp_init+0xde/0x130 [snd_hda_core] > There are 2 more "cut here", but they're almost identical so I've only > included one in this email. > > Don't know what will be valuable to you, but I'm willing to help test > this and do what I'm told. So, how can I help? > > More info about this particular kernel and issue, that led to this is at: > https://bugzilla.redhat.com/show_bug.cgi?id=1757891 > > dmesg output: > > Nov 26 18:05:45 kernel: microcode: microcode updated early to revision 0x2f, date = 2019-02-17 > Nov 26 18:05:45 kernel: Linux version 5.4.0-0.rc8.git0.1.rhbz1757891.fc31.x86_64 (mockbuild@buildhw-10.phx2.fedoraproject.org) (gcc version 9.2.1 20190827 (Red Hat 9.2.1-1) (GCC)) #1 SMP Wed Nov 20 14:50:34 UTC 2019 > Nov 26 18:05:45 kernel: Command line: BOOT_IMAGE=(hd0,gpt2)/vmlinuz-5.4.0-0.rc8.git0.1.rhbz1757891.fc31.x86_64 root=/dev/mapper/fedora-root ro resume=/dev/mapper/fedora-swap rd.lvm.lv=fedora/root rd.luks.uuid=luks-efd8b438-8f56-405a-8cea-88f83ca38d2b rd.lvm.lv=fedora/swap rhgb quiet > ... > ... > ... > Nov 26 18:06:16 kernel: ------------[ cut here ]------------ > Nov 26 18:06:16 kernel: WARNING: CPU: 0 PID: 461 at sound/hda/hdac_component.c:290 snd_hdac_acomp_init+0xde/0x130 [snd_hda_core]
This should have been already fixed by the recent commit 5a858e79c911330678b5a9be91a24830e94a0dc9 ALSA: hda - Disable audio component for legacy Nvidia HDMI codecs which is already included in Linus tree. Please check it.
Thanks, I've started a scratch kernel build with the relevant patches added, for the Fedora users hitting this to test.
The reason they started looking into their dmesg is that their nvidia GPU (hybrid gfx setup) will no longer suspend with recent kernels, this is with a 5.4 kernel which already has the
"ALSA: hda - Force runtime PM on Nvidia HDMI codecs"
Fix and for good measure I've already given them a test kernel with the: "ALSA: hda: Allow HDA to be runtime suspended when dGPU is not bound to a drive"
patch added. But looking at the fix for the oops I'm not sure if fixing the oops is also going to fix the issue with the dGPU no longer suspending?
I guess it's irrelevant with that problem, as this kernel warning (not really an Oops) is just about skipping the multiple audio component registration. And the audio component isn't used in nouveau side on 5.4.x at all, and it's just a placeholder. But who knows the black magic behind the scene :)
... and if this still doesn't fix the problem, please check the runtime PM state of all HD-audio codec devices and HD-audio controller device. Do all show the runtime-suspended but the power consumption is high? Or is some device blocked?
Basically the audio controller corresponding to the dGPU should have chip->bus.keep_power = 0, which allows the runtime PM. This flag is cleared at azx_vx_gpu_bound() only for the dGPU. For the primary GPU, we need to keep the link power unless the notification is done via the audio component (like i915 or amdgpu). I already submitted a patch to enable the audio component for nouveau in the past, but it's ignored, so far.
thanks,
Takashi
Hi Takashi
On linux-next-20191127 warning indeed disappeared. Thanks!
Rest of problems did not. This is my output from alsa-info.sh http://alsa-project.org/db/?f=91bb789a01f9eed92d0534fe8951619312b355da Don't know if it's helpful, so I'll leave it here. Power consumption is high, because runtime-suspended is not enabled/active (and cannot be forced) without removing nvidia's audio.
What if you pass power_save=1 to snd-hda-intel option?
echo -n 1 > /sys/module/snd_hda_intel/parameters/power_save
and the following, too: echo -n 1 > /sys/module/snd_hda_intel/parameters/power_save_controller
Otherwise the controller device will keep on.
Takashi
This should enable the runtime PM on all HD-audio stuff. You can adjust via runtime sysfs entries for each device, while the above is a one-shot change.
This isn't a solution, but let's see whether the runtime PM itself works or not.
Takashi
Hi,
On 27-11-2019 20:27, Takashi Iwai wrote:
On Wed, 27 Nov 2019 20:24:49 +0100, Takashi Iwai wrote:
On Wed, 27 Nov 2019 19:52:37 +0100, Michał Matysiak wrote:
On Wed, Nov 27, 2019 at 06:00:17PM +0100, Takashi Iwai wrote:
On Wed, 27 Nov 2019 16:57:04 +0100, Takashi Iwai wrote:
On Wed, 27 Nov 2019 16:46:00 +0100, Hans de Goede wrote:
Hi Takashi,
On 27-11-2019 15:39, Takashi Iwai wrote: > On Wed, 27 Nov 2019 15:26:37 +0100, > Michał Matysiak wrote: >> >> Hi >> >> Recently I've encountered this error and as Hans de Goede's request I'm >> reporting this back to you. This happens while booting my laptop >> connected to docking station and without using one. >> >> kernel: WARNING: CPU: 1 PID: 330 at sound/hda/hdac_component.c:290 snd_hdac_acomp_init+0xde/0x130 [snd_hda_core] >> There are 2 more "cut here", but they're almost identical so I've only >> included one in this email. >> >> Don't know what will be valuable to you, but I'm willing to help test >> this and do what I'm told. So, how can I help? >> >> More info about this particular kernel and issue, that led to this is at: >> https://bugzilla.redhat.com/show_bug.cgi?id=1757891 >> >> dmesg output: >> >> Nov 26 18:05:45 kernel: microcode: microcode updated early to revision 0x2f, date = 2019-02-17 >> Nov 26 18:05:45 kernel: Linux version 5.4.0-0.rc8.git0.1.rhbz1757891.fc31.x86_64 (mockbuild@buildhw-10.phx2.fedoraproject.org) (gcc version 9.2.1 20190827 (Red Hat 9.2.1-1) (GCC)) #1 SMP Wed Nov 20 14:50:34 UTC 2019 >> Nov 26 18:05:45 kernel: Command line: BOOT_IMAGE=(hd0,gpt2)/vmlinuz-5.4.0-0.rc8.git0.1.rhbz1757891.fc31.x86_64 root=/dev/mapper/fedora-root ro resume=/dev/mapper/fedora-swap rd.lvm.lv=fedora/root rd.luks.uuid=luks-efd8b438-8f56-405a-8cea-88f83ca38d2b rd.lvm.lv=fedora/swap rhgb quiet >> ... >> ... >> ... >> Nov 26 18:06:16 kernel: ------------[ cut here ]------------ >> Nov 26 18:06:16 kernel: WARNING: CPU: 0 PID: 461 at sound/hda/hdac_component.c:290 snd_hdac_acomp_init+0xde/0x130 [snd_hda_core] > > This should have been already fixed by the recent commit > 5a858e79c911330678b5a9be91a24830e94a0dc9 > ALSA: hda - Disable audio component for legacy Nvidia HDMI codecs > which is already included in Linus tree. Please check it.
Thanks, I've started a scratch kernel build with the relevant patches added, for the Fedora users hitting this to test.
The reason they started looking into their dmesg is that their nvidia GPU (hybrid gfx setup) will no longer suspend with recent kernels, this is with a 5.4 kernel which already has the
"ALSA: hda - Force runtime PM on Nvidia HDMI codecs"
Fix and for good measure I've already given them a test kernel with the: "ALSA: hda: Allow HDA to be runtime suspended when dGPU is not bound to a drive"
patch added. But looking at the fix for the oops I'm not sure if fixing the oops is also going to fix the issue with the dGPU no longer suspending?
I guess it's irrelevant with that problem, as this kernel warning (not really an Oops) is just about skipping the multiple audio component registration. And the audio component isn't used in nouveau side on 5.4.x at all, and it's just a placeholder. But who knows the black magic behind the scene :)
... and if this still doesn't fix the problem, please check the runtime PM state of all HD-audio codec devices and HD-audio controller device. Do all show the runtime-suspended but the power consumption is high? Or is some device blocked?
Basically the audio controller corresponding to the dGPU should have chip->bus.keep_power = 0, which allows the runtime PM. This flag is cleared at azx_vx_gpu_bound() only for the dGPU. For the primary GPU, we need to keep the link power unless the notification is done via the audio component (like i915 or amdgpu). I already submitted a patch to enable the audio component for nouveau in the past, but it's ignored, so far.
thanks,
Takashi
Hi Takashi
On linux-next-20191127 warning indeed disappeared. Thanks!
Rest of problems did not. This is my output from alsa-info.sh http://alsa-project.org/db/?f=91bb789a01f9eed92d0534fe8951619312b355da Don't know if it's helpful, so I'll leave it here. Power consumption is high, because runtime-suspended is not enabled/active (and cannot be forced) without removing nvidia's audio.
What if you pass power_save=1 to snd-hda-intel option?
echo -n 1 > /sys/module/snd_hda_intel/parameters/power_save
and the following, too: echo -n 1 > /sys/module/snd_hda_intel/parameters/power_save_controller
Otherwise the controller device will keep on.
Thank you for helping us getting to the root of this.
These both default to 1 resp. Y on Fedora kernels, so I do not think that this will help, as they are both already 1/Y.
Regards,
Hans
On Wed, 27 Nov 2019 20:31:20 +0100, Hans de Goede wrote:
Hi,
On 27-11-2019 20:27, Takashi Iwai wrote:
On Wed, 27 Nov 2019 20:24:49 +0100, Takashi Iwai wrote:
On Wed, 27 Nov 2019 19:52:37 +0100, Michał Matysiak wrote:
On Wed, Nov 27, 2019 at 06:00:17PM +0100, Takashi Iwai wrote:
On Wed, 27 Nov 2019 16:57:04 +0100, Takashi Iwai wrote:
On Wed, 27 Nov 2019 16:46:00 +0100, Hans de Goede wrote: > > Hi Takashi, > > On 27-11-2019 15:39, Takashi Iwai wrote: >> On Wed, 27 Nov 2019 15:26:37 +0100, >> Michał Matysiak wrote: >>> >>> Hi >>> >>> Recently I've encountered this error and as Hans de Goede's request I'm >>> reporting this back to you. This happens while booting my laptop >>> connected to docking station and without using one. >>> >>> kernel: WARNING: CPU: 1 PID: 330 at sound/hda/hdac_component.c:290 snd_hdac_acomp_init+0xde/0x130 [snd_hda_core] >>> There are 2 more "cut here", but they're almost identical so I've only >>> included one in this email. >>> >>> Don't know what will be valuable to you, but I'm willing to help test >>> this and do what I'm told. So, how can I help? >>> >>> More info about this particular kernel and issue, that led to this is at: >>> https://bugzilla.redhat.com/show_bug.cgi?id=1757891 >>> >>> dmesg output: >>> >>> Nov 26 18:05:45 kernel: microcode: microcode updated early to revision 0x2f, date = 2019-02-17 >>> Nov 26 18:05:45 kernel: Linux version 5.4.0-0.rc8.git0.1.rhbz1757891.fc31.x86_64 (mockbuild@buildhw-10.phx2.fedoraproject.org) (gcc version 9.2.1 20190827 (Red Hat 9.2.1-1) (GCC)) #1 SMP Wed Nov 20 14:50:34 UTC 2019 >>> Nov 26 18:05:45 kernel: Command line: BOOT_IMAGE=(hd0,gpt2)/vmlinuz-5.4.0-0.rc8.git0.1.rhbz1757891.fc31.x86_64 root=/dev/mapper/fedora-root ro resume=/dev/mapper/fedora-swap rd.lvm.lv=fedora/root rd.luks.uuid=luks-efd8b438-8f56-405a-8cea-88f83ca38d2b rd.lvm.lv=fedora/swap rhgb quiet >>> ... >>> ... >>> ... >>> Nov 26 18:06:16 kernel: ------------[ cut here ]------------ >>> Nov 26 18:06:16 kernel: WARNING: CPU: 0 PID: 461 at sound/hda/hdac_component.c:290 snd_hdac_acomp_init+0xde/0x130 [snd_hda_core] >> >> This should have been already fixed by the recent commit >> 5a858e79c911330678b5a9be91a24830e94a0dc9 >> ALSA: hda - Disable audio component for legacy Nvidia HDMI codecs >> which is already included in Linus tree. Please check it. > > Thanks, I've started a scratch kernel build with the relevant patches added, > for the Fedora users hitting this to test. > > The reason they started looking into their dmesg is that their nvidia GPU (hybrid gfx setup) > will no longer suspend with recent kernels, this is with a 5.4 kernel which already has the > > "ALSA: hda - Force runtime PM on Nvidia HDMI codecs" > > Fix and for good measure I've already given them a test kernel with the: > "ALSA: hda: Allow HDA to be runtime suspended when dGPU is not bound to a drive" > > patch added. But looking at the fix for the oops I'm not sure if fixing > the oops is also going to fix the issue with the dGPU no longer suspending?
I guess it's irrelevant with that problem, as this kernel warning (not really an Oops) is just about skipping the multiple audio component registration. And the audio component isn't used in nouveau side on 5.4.x at all, and it's just a placeholder. But who knows the black magic behind the scene :)
... and if this still doesn't fix the problem, please check the runtime PM state of all HD-audio codec devices and HD-audio controller device. Do all show the runtime-suspended but the power consumption is high? Or is some device blocked?
Basically the audio controller corresponding to the dGPU should have chip->bus.keep_power = 0, which allows the runtime PM. This flag is cleared at azx_vx_gpu_bound() only for the dGPU. For the primary GPU, we need to keep the link power unless the notification is done via the audio component (like i915 or amdgpu). I already submitted a patch to enable the audio component for nouveau in the past, but it's ignored, so far.
thanks,
Takashi
Hi Takashi
On linux-next-20191127 warning indeed disappeared. Thanks!
Rest of problems did not. This is my output from alsa-info.sh http://alsa-project.org/db/?f=91bb789a01f9eed92d0534fe8951619312b355da Don't know if it's helpful, so I'll leave it here. Power consumption is high, because runtime-suspended is not enabled/active (and cannot be forced) without removing nvidia's audio.
What if you pass power_save=1 to snd-hda-intel option?
echo -n 1 > /sys/module/snd_hda_intel/parameters/power_save
and the following, too: echo -n 1 > /sys/module/snd_hda_intel/parameters/power_save_controller
Otherwise the controller device will keep on.
Thank you for helping us getting to the root of this.
These both default to 1 resp. Y on Fedora kernels, so I do not think that this will help, as they are both already 1/Y.
Well, the alsa-info.sh output Michal suggested shows differently: http://alsa-project.org/db/?f=91bb789a01f9eed92d0534fe8951619312b355da
!!Loaded sound module options !!--------------------------- .... power_save : 0 power_save_controller : N
If these values are true, maybe some desktop tuning modifies on the fly?
Takashi
Hi,
On 27-11-2019 20:40, Takashi Iwai wrote:
On Wed, 27 Nov 2019 20:31:20 +0100, Hans de Goede wrote:
Hi,
On 27-11-2019 20:27, Takashi Iwai wrote:
On Wed, 27 Nov 2019 20:24:49 +0100, Takashi Iwai wrote:
On Wed, 27 Nov 2019 19:52:37 +0100, Michał Matysiak wrote:
On Wed, Nov 27, 2019 at 06:00:17PM +0100, Takashi Iwai wrote:
On Wed, 27 Nov 2019 16:57:04 +0100, Takashi Iwai wrote: > > On Wed, 27 Nov 2019 16:46:00 +0100, > Hans de Goede wrote: >> >> Hi Takashi, >> >> On 27-11-2019 15:39, Takashi Iwai wrote: >>> On Wed, 27 Nov 2019 15:26:37 +0100, >>> Michał Matysiak wrote: >>>> >>>> Hi >>>> >>>> Recently I've encountered this error and as Hans de Goede's request I'm >>>> reporting this back to you. This happens while booting my laptop >>>> connected to docking station and without using one. >>>> >>>> kernel: WARNING: CPU: 1 PID: 330 at sound/hda/hdac_component.c:290 snd_hdac_acomp_init+0xde/0x130 [snd_hda_core] >>>> There are 2 more "cut here", but they're almost identical so I've only >>>> included one in this email. >>>> >>>> Don't know what will be valuable to you, but I'm willing to help test >>>> this and do what I'm told. So, how can I help? >>>> >>>> More info about this particular kernel and issue, that led to this is at: >>>> https://bugzilla.redhat.com/show_bug.cgi?id=1757891 >>>> >>>> dmesg output: >>>> >>>> Nov 26 18:05:45 kernel: microcode: microcode updated early to revision 0x2f, date = 2019-02-17 >>>> Nov 26 18:05:45 kernel: Linux version 5.4.0-0.rc8.git0.1.rhbz1757891.fc31.x86_64 (mockbuild@buildhw-10.phx2.fedoraproject.org) (gcc version 9.2.1 20190827 (Red Hat 9.2.1-1) (GCC)) #1 SMP Wed Nov 20 14:50:34 UTC 2019 >>>> Nov 26 18:05:45 kernel: Command line: BOOT_IMAGE=(hd0,gpt2)/vmlinuz-5.4.0-0.rc8.git0.1.rhbz1757891.fc31.x86_64 root=/dev/mapper/fedora-root ro resume=/dev/mapper/fedora-swap rd.lvm.lv=fedora/root rd.luks.uuid=luks-efd8b438-8f56-405a-8cea-88f83ca38d2b rd.lvm.lv=fedora/swap rhgb quiet >>>> ... >>>> ... >>>> ... >>>> Nov 26 18:06:16 kernel: ------------[ cut here ]------------ >>>> Nov 26 18:06:16 kernel: WARNING: CPU: 0 PID: 461 at sound/hda/hdac_component.c:290 snd_hdac_acomp_init+0xde/0x130 [snd_hda_core] >>> >>> This should have been already fixed by the recent commit >>> 5a858e79c911330678b5a9be91a24830e94a0dc9 >>> ALSA: hda - Disable audio component for legacy Nvidia HDMI codecs >>> which is already included in Linus tree. Please check it. >> >> Thanks, I've started a scratch kernel build with the relevant patches added, >> for the Fedora users hitting this to test. >> >> The reason they started looking into their dmesg is that their nvidia GPU (hybrid gfx setup) >> will no longer suspend with recent kernels, this is with a 5.4 kernel which already has the >> >> "ALSA: hda - Force runtime PM on Nvidia HDMI codecs" >> >> Fix and for good measure I've already given them a test kernel with the: >> "ALSA: hda: Allow HDA to be runtime suspended when dGPU is not bound to a drive" >> >> patch added. But looking at the fix for the oops I'm not sure if fixing >> the oops is also going to fix the issue with the dGPU no longer suspending? > > I guess it's irrelevant with that problem, as this kernel warning (not > really an Oops) is just about skipping the multiple audio component > registration. And the audio component isn't used in nouveau side on > 5.4.x at all, and it's just a placeholder. But who knows the black > magic behind the scene :)
... and if this still doesn't fix the problem, please check the runtime PM state of all HD-audio codec devices and HD-audio controller device. Do all show the runtime-suspended but the power consumption is high? Or is some device blocked?
Basically the audio controller corresponding to the dGPU should have chip->bus.keep_power = 0, which allows the runtime PM. This flag is cleared at azx_vx_gpu_bound() only for the dGPU. For the primary GPU, we need to keep the link power unless the notification is done via the audio component (like i915 or amdgpu). I already submitted a patch to enable the audio component for nouveau in the past, but it's ignored, so far.
thanks,
Takashi
Hi Takashi
On linux-next-20191127 warning indeed disappeared. Thanks!
Rest of problems did not. This is my output from alsa-info.sh http://alsa-project.org/db/?f=91bb789a01f9eed92d0534fe8951619312b355da Don't know if it's helpful, so I'll leave it here. Power consumption is high, because runtime-suspended is not enabled/active (and cannot be forced) without removing nvidia's audio.
What if you pass power_save=1 to snd-hda-intel option?
echo -n 1 > /sys/module/snd_hda_intel/parameters/power_saveand the following, too: echo -n 1 > /sys/module/snd_hda_intel/parameters/power_save_controller
Otherwise the controller device will keep on.
Thank you for helping us getting to the root of this.
These both default to 1 resp. Y on Fedora kernels, so I do not think that this will help, as they are both already 1/Y.
Well, the alsa-info.sh output Michal suggested shows differently: http://alsa-project.org/db/?f=91bb789a01f9eed92d0534fe8951619312b355da
!!Loaded sound module options !!--------------------------- .... power_save : 0 power_save_controller : N
If these values are true, maybe some desktop tuning modifies on the fly?
Oh, that might explain why the fixes for this are confirmed as working by some of our users, but not by all.
Michal, are you perhaps using TLP or some similar software to tune / improve power-management settings ? Or do you perhaps have some custom files under /etc/modprobe.conf.d messing with these settings?
Regards,
Hans
On Wed, Nov 27, 2019 at 08:46:36PM +0100, Hans de Goede wrote:
Hi,
On 27-11-2019 20:40, Takashi Iwai wrote:
On Wed, 27 Nov 2019 20:31:20 +0100, Hans de Goede wrote:
Hi,
On 27-11-2019 20:27, Takashi Iwai wrote:
On Wed, 27 Nov 2019 20:24:49 +0100, Takashi Iwai wrote:
On Wed, 27 Nov 2019 19:52:37 +0100, Michał Matysiak wrote:
On Wed, Nov 27, 2019 at 06:00:17PM +0100, Takashi Iwai wrote: > On Wed, 27 Nov 2019 16:57:04 +0100, > Takashi Iwai wrote: > > > > On Wed, 27 Nov 2019 16:46:00 +0100, > > Hans de Goede wrote: > > > > > > Hi Takashi, > > > > > > On 27-11-2019 15:39, Takashi Iwai wrote: > > > > On Wed, 27 Nov 2019 15:26:37 +0100, > > > > Michał Matysiak wrote: > > > > > > > > > > Hi > > > > > > > > > > Recently I've encountered this error and as Hans de Goede's request I'm > > > > > reporting this back to you. This happens while booting my laptop > > > > > connected to docking station and without using one. > > > > > > > > > > kernel: WARNING: CPU: 1 PID: 330 at sound/hda/hdac_component.c:290 snd_hdac_acomp_init+0xde/0x130 [snd_hda_core] > > > > > There are 2 more "cut here", but they're almost identical so I've only > > > > > included one in this email. > > > > > > > > > > Don't know what will be valuable to you, but I'm willing to help test > > > > > this and do what I'm told. So, how can I help? > > > > > > > > > > More info about this particular kernel and issue, that led to this is at: > > > > > https://bugzilla.redhat.com/show_bug.cgi?id=1757891 > > > > > > > > > > dmesg output: > > > > > > > > > > Nov 26 18:05:45 kernel: microcode: microcode updated early to revision 0x2f, date = 2019-02-17 > > > > > Nov 26 18:05:45 kernel: Linux version 5.4.0-0.rc8.git0.1.rhbz1757891.fc31.x86_64 (mockbuild@buildhw-10.phx2.fedoraproject.org) (gcc version 9.2.1 20190827 (Red Hat 9.2.1-1) (GCC)) #1 SMP Wed Nov 20 14:50:34 UTC 2019 > > > > > Nov 26 18:05:45 kernel: Command line: BOOT_IMAGE=(hd0,gpt2)/vmlinuz-5.4.0-0.rc8.git0.1.rhbz1757891.fc31.x86_64 root=/dev/mapper/fedora-root ro resume=/dev/mapper/fedora-swap rd.lvm.lv=fedora/root rd.luks.uuid=luks-efd8b438-8f56-405a-8cea-88f83ca38d2b rd.lvm.lv=fedora/swap rhgb quiet > > > > > ... > > > > > ... > > > > > ... > > > > > Nov 26 18:06:16 kernel: ------------[ cut here ]------------ > > > > > Nov 26 18:06:16 kernel: WARNING: CPU: 0 PID: 461 at sound/hda/hdac_component.c:290 snd_hdac_acomp_init+0xde/0x130 [snd_hda_core] > > > > > > > > This should have been already fixed by the recent commit > > > > 5a858e79c911330678b5a9be91a24830e94a0dc9 > > > > ALSA: hda - Disable audio component for legacy Nvidia HDMI codecs > > > > which is already included in Linus tree. Please check it. > > > > > > Thanks, I've started a scratch kernel build with the relevant patches added, > > > for the Fedora users hitting this to test. > > > > > > The reason they started looking into their dmesg is that their nvidia GPU (hybrid gfx setup) > > > will no longer suspend with recent kernels, this is with a 5.4 kernel which already has the > > > > > > "ALSA: hda - Force runtime PM on Nvidia HDMI codecs" > > > > > > Fix and for good measure I've already given them a test kernel with the: > > > "ALSA: hda: Allow HDA to be runtime suspended when dGPU is not bound to a drive" > > > > > > patch added. But looking at the fix for the oops I'm not sure if fixing > > > the oops is also going to fix the issue with the dGPU no longer suspending? > > > > I guess it's irrelevant with that problem, as this kernel warning (not > > really an Oops) is just about skipping the multiple audio component > > registration. And the audio component isn't used in nouveau side on > > 5.4.x at all, and it's just a placeholder. But who knows the black > > magic behind the scene :) > > ... and if this still doesn't fix the problem, please check the > runtime PM state of all HD-audio codec devices and HD-audio controller > device. Do all show the runtime-suspended but the power consumption > is high? Or is some device blocked? > > Basically the audio controller corresponding to the dGPU should have > chip->bus.keep_power = 0, which allows the runtime PM. This flag is > cleared at azx_vx_gpu_bound() only for the dGPU. For the primary GPU, > we need to keep the link power unless the notification is done via the > audio component (like i915 or amdgpu). I already submitted a patch to > enable the audio component for nouveau in the past, but it's ignored, > so far. > > > thanks, > > Takashi
Hi Takashi
On linux-next-20191127 warning indeed disappeared. Thanks!
Rest of problems did not. This is my output from alsa-info.sh http://alsa-project.org/db/?f=91bb789a01f9eed92d0534fe8951619312b355da Don't know if it's helpful, so I'll leave it here. Power consumption is high, because runtime-suspended is not enabled/active (and cannot be forced) without removing nvidia's audio.
What if you pass power_save=1 to snd-hda-intel option?
echo -n 1 > /sys/module/snd_hda_intel/parameters/power_saveand the following, too: echo -n 1 > /sys/module/snd_hda_intel/parameters/power_save_controller
Otherwise the controller device will keep on.
Thank you for helping us getting to the root of this.
These both default to 1 resp. Y on Fedora kernels, so I do not think that this will help, as they are both already 1/Y.
Well, the alsa-info.sh output Michal suggested shows differently: http://alsa-project.org/db/?f=91bb789a01f9eed92d0534fe8951619312b355da
!!Loaded sound module options !!--------------------------- .... power_save : 0 power_save_controller : N
If these values are true, maybe some desktop tuning modifies on the fly?
Oh, that might explain why the fixes for this are confirmed as working by some of our users, but not by all.
Michal, are you perhaps using TLP or some similar software to tune / improve power-management settings ? Or do you perhaps have some custom files under /etc/modprobe.conf.d messing with these settings?
Regards,
Hans
OK. So that explains everything, it's working as intended with tlp disabled. I'm using tlp and I assumed, that if my tlp's configuration was working before, it should work now. Especially when I've checked live isos and was broken in exactly same way. Clearly I was wrong.
BIG THANK YOU!
Michał
Hi,
On 27-11-2019 21:00, Michał Matysiak wrote:
On Wed, Nov 27, 2019 at 08:46:36PM +0100, Hans de Goede wrote:
Hi,
On 27-11-2019 20:40, Takashi Iwai wrote:
On Wed, 27 Nov 2019 20:31:20 +0100, Hans de Goede wrote:
Hi,
On 27-11-2019 20:27, Takashi Iwai wrote:
On Wed, 27 Nov 2019 20:24:49 +0100, Takashi Iwai wrote:
On Wed, 27 Nov 2019 19:52:37 +0100, Michał Matysiak wrote: > > On Wed, Nov 27, 2019 at 06:00:17PM +0100, Takashi Iwai wrote: >> On Wed, 27 Nov 2019 16:57:04 +0100, >> Takashi Iwai wrote: >>> >>> On Wed, 27 Nov 2019 16:46:00 +0100, >>> Hans de Goede wrote: >>>> >>>> Hi Takashi, >>>> >>>> On 27-11-2019 15:39, Takashi Iwai wrote: >>>>> On Wed, 27 Nov 2019 15:26:37 +0100, >>>>> Michał Matysiak wrote: >>>>>> >>>>>> Hi >>>>>> >>>>>> Recently I've encountered this error and as Hans de Goede's request I'm >>>>>> reporting this back to you. This happens while booting my laptop >>>>>> connected to docking station and without using one. >>>>>> >>>>>> kernel: WARNING: CPU: 1 PID: 330 at sound/hda/hdac_component.c:290 snd_hdac_acomp_init+0xde/0x130 [snd_hda_core] >>>>>> There are 2 more "cut here", but they're almost identical so I've only >>>>>> included one in this email. >>>>>> >>>>>> Don't know what will be valuable to you, but I'm willing to help test >>>>>> this and do what I'm told. So, how can I help? >>>>>> >>>>>> More info about this particular kernel and issue, that led to this is at: >>>>>> https://bugzilla.redhat.com/show_bug.cgi?id=1757891 >>>>>> >>>>>> dmesg output: >>>>>> >>>>>> Nov 26 18:05:45 kernel: microcode: microcode updated early to revision 0x2f, date = 2019-02-17 >>>>>> Nov 26 18:05:45 kernel: Linux version 5.4.0-0.rc8.git0.1.rhbz1757891.fc31.x86_64 (mockbuild@buildhw-10.phx2.fedoraproject.org) (gcc version 9.2.1 20190827 (Red Hat 9.2.1-1) (GCC)) #1 SMP Wed Nov 20 14:50:34 UTC 2019 >>>>>> Nov 26 18:05:45 kernel: Command line: BOOT_IMAGE=(hd0,gpt2)/vmlinuz-5.4.0-0.rc8.git0.1.rhbz1757891.fc31.x86_64 root=/dev/mapper/fedora-root ro resume=/dev/mapper/fedora-swap rd.lvm.lv=fedora/root rd.luks.uuid=luks-efd8b438-8f56-405a-8cea-88f83ca38d2b rd.lvm.lv=fedora/swap rhgb quiet >>>>>> ... >>>>>> ... >>>>>> ... >>>>>> Nov 26 18:06:16 kernel: ------------[ cut here ]------------ >>>>>> Nov 26 18:06:16 kernel: WARNING: CPU: 0 PID: 461 at sound/hda/hdac_component.c:290 snd_hdac_acomp_init+0xde/0x130 [snd_hda_core] >>>>> >>>>> This should have been already fixed by the recent commit >>>>> 5a858e79c911330678b5a9be91a24830e94a0dc9 >>>>> ALSA: hda - Disable audio component for legacy Nvidia HDMI codecs >>>>> which is already included in Linus tree. Please check it. >>>> >>>> Thanks, I've started a scratch kernel build with the relevant patches added, >>>> for the Fedora users hitting this to test. >>>> >>>> The reason they started looking into their dmesg is that their nvidia GPU (hybrid gfx setup) >>>> will no longer suspend with recent kernels, this is with a 5.4 kernel which already has the >>>> >>>> "ALSA: hda - Force runtime PM on Nvidia HDMI codecs" >>>> >>>> Fix and for good measure I've already given them a test kernel with the: >>>> "ALSA: hda: Allow HDA to be runtime suspended when dGPU is not bound to a drive" >>>> >>>> patch added. But looking at the fix for the oops I'm not sure if fixing >>>> the oops is also going to fix the issue with the dGPU no longer suspending? >>> >>> I guess it's irrelevant with that problem, as this kernel warning (not >>> really an Oops) is just about skipping the multiple audio component >>> registration. And the audio component isn't used in nouveau side on >>> 5.4.x at all, and it's just a placeholder. But who knows the black >>> magic behind the scene :) >> >> ... and if this still doesn't fix the problem, please check the >> runtime PM state of all HD-audio codec devices and HD-audio controller >> device. Do all show the runtime-suspended but the power consumption >> is high? Or is some device blocked? >> >> Basically the audio controller corresponding to the dGPU should have >> chip->bus.keep_power = 0, which allows the runtime PM. This flag is >> cleared at azx_vx_gpu_bound() only for the dGPU. For the primary GPU, >> we need to keep the link power unless the notification is done via the >> audio component (like i915 or amdgpu). I already submitted a patch to >> enable the audio component for nouveau in the past, but it's ignored, >> so far. >> >> >> thanks, >> >> Takashi > > Hi Takashi > > On linux-next-20191127 warning indeed disappeared. Thanks! > > Rest of problems did not. This is my output from alsa-info.sh > http://alsa-project.org/db/?f=91bb789a01f9eed92d0534fe8951619312b355da > Don't know if it's helpful, so I'll leave it here. Power consumption is > high, because runtime-suspended is not enabled/active (and cannot be > forced) without removing nvidia's audio.
What if you pass power_save=1 to snd-hda-intel option?
echo -n 1 > /sys/module/snd_hda_intel/parameters/power_saveand the following, too: echo -n 1 > /sys/module/snd_hda_intel/parameters/power_save_controller
Otherwise the controller device will keep on.
Thank you for helping us getting to the root of this.
These both default to 1 resp. Y on Fedora kernels, so I do not think that this will help, as they are both already 1/Y.
Well, the alsa-info.sh output Michal suggested shows differently: http://alsa-project.org/db/?f=91bb789a01f9eed92d0534fe8951619312b355da
!!Loaded sound module options !!--------------------------- .... power_save : 0 power_save_controller : NIf these values are true, maybe some desktop tuning modifies on the fly?
Oh, that might explain why the fixes for this are confirmed as working by some of our users, but not by all.
Michal, are you perhaps using TLP or some similar software to tune / improve power-management settings ? Or do you perhaps have some custom files under /etc/modprobe.conf.d messing with these settings?
Regards,
Hans
OK. So that explains everything, it's working as intended with tlp disabled. I'm using tlp and I assumed, that if my tlp's configuration was working before, it should work now. Especially when I've checked live isos and was broken in exactly same way. Clearly I was wrong.
Right, so older kernels did not have support for audio over HDMI/DP for nvidia GPUs so the audio part of the GPU did not have a driver attached. In newer kernels there is a driver attached, so now the power-management settings of the hda driver matter for allowing the dGPU to suspend.
BIG THANK YOU!
You're welcome. Note that you should not need TLP anymore since Fedora 29, all worthwhile power savings are enabled by default, including the HDA power saving settings.
Regards,
Hans
On Wed, Nov 27, 2019 at 08:40:41PM +0100, Takashi Iwai wrote:
On Wed, 27 Nov 2019 20:31:20 +0100, Hans de Goede wrote:
Hi,
On 27-11-2019 20:27, Takashi Iwai wrote:
On Wed, 27 Nov 2019 20:24:49 +0100, Takashi Iwai wrote:
On Wed, 27 Nov 2019 19:52:37 +0100, Michał Matysiak wrote:
On Wed, Nov 27, 2019 at 06:00:17PM +0100, Takashi Iwai wrote:
On Wed, 27 Nov 2019 16:57:04 +0100, Takashi Iwai wrote: > > On Wed, 27 Nov 2019 16:46:00 +0100, > Hans de Goede wrote: >> >> Hi Takashi, >> >> On 27-11-2019 15:39, Takashi Iwai wrote: >>> On Wed, 27 Nov 2019 15:26:37 +0100, >>> Michał Matysiak wrote: >>>> >>>> Hi >>>> >>>> Recently I've encountered this error and as Hans de Goede's request I'm >>>> reporting this back to you. This happens while booting my laptop >>>> connected to docking station and without using one. >>>> >>>> kernel: WARNING: CPU: 1 PID: 330 at sound/hda/hdac_component.c:290 snd_hdac_acomp_init+0xde/0x130 [snd_hda_core] >>>> There are 2 more "cut here", but they're almost identical so I've only >>>> included one in this email. >>>> >>>> Don't know what will be valuable to you, but I'm willing to help test >>>> this and do what I'm told. So, how can I help? >>>> >>>> More info about this particular kernel and issue, that led to this is at: >>>> https://bugzilla.redhat.com/show_bug.cgi?id=1757891 >>>> >>>> dmesg output: >>>> >>>> Nov 26 18:05:45 kernel: microcode: microcode updated early to revision 0x2f, date = 2019-02-17 >>>> Nov 26 18:05:45 kernel: Linux version 5.4.0-0.rc8.git0.1.rhbz1757891.fc31.x86_64 (mockbuild@buildhw-10.phx2.fedoraproject.org) (gcc version 9.2.1 20190827 (Red Hat 9.2.1-1) (GCC)) #1 SMP Wed Nov 20 14:50:34 UTC 2019 >>>> Nov 26 18:05:45 kernel: Command line: BOOT_IMAGE=(hd0,gpt2)/vmlinuz-5.4.0-0.rc8.git0.1.rhbz1757891.fc31.x86_64 root=/dev/mapper/fedora-root ro resume=/dev/mapper/fedora-swap rd.lvm.lv=fedora/root rd.luks.uuid=luks-efd8b438-8f56-405a-8cea-88f83ca38d2b rd.lvm.lv=fedora/swap rhgb quiet >>>> ... >>>> ... >>>> ... >>>> Nov 26 18:06:16 kernel: ------------[ cut here ]------------ >>>> Nov 26 18:06:16 kernel: WARNING: CPU: 0 PID: 461 at sound/hda/hdac_component.c:290 snd_hdac_acomp_init+0xde/0x130 [snd_hda_core] >>> >>> This should have been already fixed by the recent commit >>> 5a858e79c911330678b5a9be91a24830e94a0dc9 >>> ALSA: hda - Disable audio component for legacy Nvidia HDMI codecs >>> which is already included in Linus tree. Please check it. >> >> Thanks, I've started a scratch kernel build with the relevant patches added, >> for the Fedora users hitting this to test. >> >> The reason they started looking into their dmesg is that their nvidia GPU (hybrid gfx setup) >> will no longer suspend with recent kernels, this is with a 5.4 kernel which already has the >> >> "ALSA: hda - Force runtime PM on Nvidia HDMI codecs" >> >> Fix and for good measure I've already given them a test kernel with the: >> "ALSA: hda: Allow HDA to be runtime suspended when dGPU is not bound to a drive" >> >> patch added. But looking at the fix for the oops I'm not sure if fixing >> the oops is also going to fix the issue with the dGPU no longer suspending? > > I guess it's irrelevant with that problem, as this kernel warning (not > really an Oops) is just about skipping the multiple audio component > registration. And the audio component isn't used in nouveau side on > 5.4.x at all, and it's just a placeholder. But who knows the black > magic behind the scene :)
... and if this still doesn't fix the problem, please check the runtime PM state of all HD-audio codec devices and HD-audio controller device. Do all show the runtime-suspended but the power consumption is high? Or is some device blocked?
Basically the audio controller corresponding to the dGPU should have chip->bus.keep_power = 0, which allows the runtime PM. This flag is cleared at azx_vx_gpu_bound() only for the dGPU. For the primary GPU, we need to keep the link power unless the notification is done via the audio component (like i915 or amdgpu). I already submitted a patch to enable the audio component for nouveau in the past, but it's ignored, so far.
thanks,
Takashi
Hi Takashi
On linux-next-20191127 warning indeed disappeared. Thanks!
Rest of problems did not. This is my output from alsa-info.sh http://alsa-project.org/db/?f=91bb789a01f9eed92d0534fe8951619312b355da Don't know if it's helpful, so I'll leave it here. Power consumption is high, because runtime-suspended is not enabled/active (and cannot be forced) without removing nvidia's audio.
What if you pass power_save=1 to snd-hda-intel option?
echo -n 1 > /sys/module/snd_hda_intel/parameters/power_save
and the following, too: echo -n 1 > /sys/module/snd_hda_intel/parameters/power_save_controller
Otherwise the controller device will keep on.
Thank you for helping us getting to the root of this.
These both default to 1 resp. Y on Fedora kernels, so I do not think that this will help, as they are both already 1/Y.
Well, the alsa-info.sh output Michal suggested shows differently: http://alsa-project.org/db/?f=91bb789a01f9eed92d0534fe8951619312b355da
!!Loaded sound module options !!--------------------------- .... power_save : 0 power_save_controller : N
If these values are true, maybe some desktop tuning modifies on the fly?
Takashi
I'll check it in a few. This was linux next with config from some fedora rawhide kernel. Don't know if this values are like defaults from F31, and I didn't exec alsa-info.sh on Hans de Goede's kernel, so I'll add this also.
Michał
participants (3)
-
Hans de Goede -
Michał Matysiak -
Takashi Iwai