[alsa-devel] [PATCH] Line In for Acer Inspire 6530G model
The Line In connector is set up as PIN_IN by default, using VREF_HIZ. It is connected to both ADCs, so add it to both input selectors. Also add the ability to use the input mix (on a SoundBlaster one would call this "What You Hear").
Signed-off-by: Tony Vroon tony@linx.net
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 3345331..67dd883 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -1560,18 +1560,22 @@ static struct hda_input_mux alc888_2_capture_sources[2] = { static struct hda_input_mux alc888_acer_aspire_6530_sources[2] = { /* Interal mic only available on one ADC */ { - .num_items = 3, + .num_items = 5, .items = { { "Ext Mic", 0x0 }, + { "Line In", 0x2 }, { "CD", 0x4 }, + { "Input Mix", 0xa }, { "Int Mic", 0xb }, }, }, { - .num_items = 2, + .num_items = 4, .items = { { "Ext Mic", 0x0 }, + { "Line In", 0x2 }, { "CD", 0x4 }, + { "Input Mix", 0xa }, }, } }; @@ -8189,6 +8193,8 @@ static struct snd_kcontrol_new alc888_acer_aspire_6530_mixer[] = { HDA_BIND_MUTE("Front Playback Switch", 0x0c, 2, HDA_INPUT), HDA_CODEC_VOLUME("LFE Playback Volume", 0x0f, 0x0, HDA_OUTPUT), HDA_BIND_MUTE("LFE Playback Switch", 0x0f, 2, HDA_INPUT), + HDA_CODEC_VOLUME("Line Playback Volume", 0x0b, 0x02, HDA_INPUT), + HDA_CODEC_MUTE("Line Playback Switch", 0x0b, 0x02, HDA_INPUT), HDA_CODEC_VOLUME("CD Playback Volume", 0x0b, 0x04, HDA_INPUT), HDA_CODEC_MUTE("CD Playback Switch", 0x0b, 0x04, HDA_INPUT), HDA_CODEC_VOLUME("Mic Playback Volume", 0x0b, 0x0, HDA_INPUT),
At Fri, 26 Jun 2009 09:27:50 +0100 (BST), Tony Vroon wrote:
The Line In connector is set up as PIN_IN by default, using VREF_HIZ. It is connected to both ADCs, so add it to both input selectors. Also add the ability to use the input mix (on a SoundBlaster one would call this "What You Hear").
Signed-off-by: Tony Vroon tony@linx.net
I applied this as this appears safe. Emilio, could you check whether this works?
thanks,
Takashi
2009/6/29 Takashi Iwai tiwai@suse.de:
At Fri, 26 Jun 2009 09:27:50 +0100 (BST), Tony Vroon wrote:
The Line In connector is set up as PIN_IN by default, using VREF_HIZ. It is connected to both ADCs, so add it to both input selectors. Also add the ability to use the input mix (on a SoundBlaster one would call this "What You Hear").
Signed-off-by: Tony Vroon tony@linx.net
I applied this as this appears safe. Emilio, could you check whether this works?
I don't have the necessary cable to connect my MP3/CD Player to line in, sorry. Unless I can use a normal mic on line in (I guess not, because mics don't have any power supply), I won't be able to test.
thanks,
Takashi
Hi.
2009/6/30 Emilio López buhitoescolar@gmail.com:
2009/6/29 Takashi Iwai tiwai@suse.de:
I applied this as this appears safe. Emilio, could you check whether this works?
I don't have the necessary cable to connect my MP3/CD Player to line in, sorry. Unless I can use a normal mic on line in (I guess not, because mics don't have any power supply), I won't be able to test.
Some time ago I was the one to (wrongly, it seems) report the 6530G to work with the 4930 model. My problem was not being able to use the internal mic for audioconference, which that model fixed. I didn't put any attention into the "tuba" thing (I suspected it to be a marketing thing, with the bass speaker tied to one of the two stereo channels).
I've been reading the thread, and I think I'll be able to test the line-in issue. But I'm a bit confused about where to get the latest driver snapshot package. Could you please provide a link to it, so that I can get it running on my Ubuntu 9.04 installation?
Best regards,
Juan Jesus.
At Tue, 30 Jun 2009 08:07:21 +0200, Juan Jesús García de Soria Lucena wrote:
Hi.
2009/6/30 Emilio López buhitoescolar@gmail.com:
2009/6/29 Takashi Iwai tiwai@suse.de:
I applied this as this appears safe. Emilio, could you check whether this works?
I don't have the necessary cable to connect my MP3/CD Player to line in, sorry. Unless I can use a normal mic on line in (I guess not, because mics don't have any power supply), I won't be able to test.
Some time ago I was the one to (wrongly, it seems) report the 6530G to work with the 4930 model. My problem was not being able to use the internal mic for audioconference, which that model fixed. I didn't put any attention into the "tuba" thing (I suspected it to be a marketing thing, with the bass speaker tied to one of the two stereo channels).
I've been reading the thread, and I think I'll be able to test the line-in issue. But I'm a bit confused about where to get the latest driver snapshot package. Could you please provide a link to it, so that I can get it running on my Ubuntu 9.04 installation?
The alsa-driver snapshot tarball can be found at ftp://ftp.kernel.org/pub/linux/kernel/people/tiwai/snapshot/alsa-driver-snapshot.tar.gz
There seems some script for Ubuntu to adapt that tree automatically, but I don't remember exactly as I'm no Ubuntu user :)
HTH,
Takashi
Wow!
El 30 de junio de 2009 08:35, Takashi Iwaitiwai@suse.de escribió:
The alsa-driver snapshot tarball can be found at ftp://ftp.kernel.org/pub/linux/kernel/people/tiwai/snapshot/alsa-driver-snapshot.tar.gz
I installed the snapshot, rebooted, plugged in both a CD player into the line in and an external mic, launched
(arecord | aplay) &
and then started playing with the alsamixer controls.
I can confirm that pluggin in headphones mute all the speakers. Also the LFE level controls the bass speaker correctly.
I played with the "Capture" / "Input Source" pair of controls, and can confirm that "Internal Mic", "External Mic" and "Line In" work ok. I'm not sure about how to test the "CD" and "Input Mix" options.
I couldn't do anything about "Capture 1" / "Input Source 1". Has it anything to do with the second capture device I get from arecord -l?
skandalfo@rimmer:~$ arecord -l **** Lista de CAPTURE Dispositivos Hardware **** tarjeta 0: SB [HDA ATI SB], dispositivo 0: ALC888 Analog [ALC888 Analog] Subdispositivos: 1/1 Subdispositivo #0: subdevice #0 tarjeta 0: SB [HDA ATI SB], dispositivo 2: ALC888 Analog [ALC888 Analog] Subdispositivos: 1/1 Subdispositivo #0: subdevice #0
I tried to perform the same tests with arecord -Dhw:0,2 but it complained about no appropriate sample format, so I suppose I was trying something stupid.
In any case, congratulations, and lots of thanks for your good work. My laptop now sounds much better :-D
Best regards,
Juan Jesus.
On Tue, 2009-06-30 at 21:56 +0200, Juan Jesús García de Soria Lucena wrote:
I played with the "Capture" / "Input Source" pair of controls, and can confirm that "Internal Mic", "External Mic" and "Line In" work ok. I'm not sure about how to test the "CD" and "Input Mix" options.
CD is the analog audio feed from your CD/DVD player. It should work with some of the command-line CD players. Most GUI players will basically rip the audio at 1X speed so they can show you a visualiser.
I couldn't do anything about "Capture 1" / "Input Source 1". Has it anything to do with the second capture device I get from arecord -l?
Indeed, the second ADC should be the second device listed.
In any case, congratulations, and lots of thanks for your good work. My laptop now sounds much better :-D
Team work between Emilio, Takashi & me. I'm very pleased with the result :)
Best regards, Juan Jesus.
Regards, Tony V.
Hi all!
I studing the aplay program and there is a function that I can't find in any header. Ive tried asound.h and asoundlib.h among other but without success!
This is the code:
card = -1; if (snd_card_next(&card) < 0 || card < 0) { error(_("no soundcards found...")); return; }
Where is the snd_card_next() function?
Thanks all!
Tks!
-------------------
Guilherme Longo Dept. Eng. da Computação Unaerp
Linux User - #484927
*Before Asking http://www.istf.com.br/?page=perguntas
!- I'd rather die on my feet than live on my knees -!
Guilherme wrote:
I studing the aplay program and there is a function that I can't find in any header. Ive tried asound.h and asoundlib.h among other but without success! [...] Where is the snd_card_next() function?
$ grep snd_card_next /usr/include/alsa/* /usr/include/alsa/control.h:int snd_card_next(int *card);
HTH Clemens
participants (6)
-
Clemens Ladisch -
Emilio López -
Guilherme -
Juan Jesús García de Soria Lucena -
Takashi Iwai -
Tony Vroon