[alsa-devel] [PATCH RFT] ASoC: sgtl5000: Fix up define for SGTL5000_SMALL_POP
Currently, below code actually does not update any bit because SGTL5000_SMALL_POP is 0.
snd_soc_update_bits(codec, SGTL5000_CHIP_REF_CTRL, SGTL5000_SMALL_POP, 1);
The SGTL5000_SMALL_POP should be BIT(0) rather than 0, fix it.
Signed-off-by: Axel Lin axel.lin@ingics.com --- Hi, I don't have h/w and datasheet, but the code looks obvious does not make sense. Can someone help to confirm and test if this patch? Thanks, Axel sound/soc/codecs/sgtl5000.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/sgtl5000.h b/sound/soc/codecs/sgtl5000.h index bd7a344..1c317de 100644 --- a/sound/soc/codecs/sgtl5000.h +++ b/sound/soc/codecs/sgtl5000.h @@ -275,7 +275,7 @@ #define SGTL5000_BIAS_CTRL_MASK 0x000e #define SGTL5000_BIAS_CTRL_SHIFT 1 #define SGTL5000_BIAS_CTRL_WIDTH 3 -#define SGTL5000_SMALL_POP 0 +#define SGTL5000_SMALL_POP 1
/* * SGTL5000_CHIP_MIC_CTRL
On Wednesday 22 July 2015 11:27:45, Axel Lin wrote:
Currently, below code actually does not update any bit because SGTL5000_SMALL_POP is 0.
snd_soc_update_bits(codec, SGTL5000_CHIP_REF_CTRL, SGTL5000_SMALL_POP, 1);
The SGTL5000_SMALL_POP should be BIT(0) rather than 0, fix it.
Signed-off-by: Axel Lin axel.lin@ingics.com
I can not test this right now, but it seems appropriate. Acked-By: Alexander Stein alexander.stein@systec-electronic.com
Hi, I don't have h/w and datasheet, but the code looks obvious does not make sense. Can someone help to confirm and test if this patch?
The datasheet can be found online: http://www.freescale.com/webapp/sps/site/prod_summary.jsp?code=SGTL5000&...
Best regards, Alexander
2015-07-22 16:58 GMT+08:00 Alexander Stein alexander.stein@systec-electronic.com:
On Wednesday 22 July 2015 11:27:45, Axel Lin wrote:
Currently, below code actually does not update any bit because SGTL5000_SMALL_POP is 0.
snd_soc_update_bits(codec, SGTL5000_CHIP_REF_CTRL, SGTL5000_SMALL_POP, 1);
The SGTL5000_SMALL_POP should be BIT(0) rather than 0, fix it.
Signed-off-by: Axel Lin axel.lin@ingics.com
I can not test this right now, but it seems appropriate. Acked-By: Alexander Stein alexander.stein@systec-electronic.com
Hi, I don't have h/w and datasheet, but the code looks obvious does not make sense. Can someone help to confirm and test if this patch?
The datasheet can be found online: http://www.freescale.com/webapp/sps/site/prod_summary.jsp?code=SGTL5000&...
I just checked the datasheet and confirm the SMALL_POP is BIT(0). Thanks, Axel
On Wed, Jul 22, 2015 at 6:45 AM, Axel Lin axel.lin@ingics.com wrote:
I just checked the datasheet and confirm the SMALL_POP is BIT(0).
Yes, this is correct:
Reviewed-by: Fabio Estevam fabio.estevam@freescale.com
The patch
ASoC: sgtl5000: Fix up define for SGTL5000_SMALL_POP
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks, Mark
From b101acfabc9377469af3abfb7cb63112da367284 Mon Sep 17 00:00:00 2001
From: Axel Lin axel.lin@ingics.com Date: Wed, 22 Jul 2015 11:27:45 +0800 Subject: [PATCH] ASoC: sgtl5000: Fix up define for SGTL5000_SMALL_POP
Currently, below code actually does not update any bit because SGTL5000_SMALL_POP is 0.
snd_soc_update_bits(codec, SGTL5000_CHIP_REF_CTRL, SGTL5000_SMALL_POP, 1);
The SGTL5000_SMALL_POP should be BIT(0) rather than 0, fix it.
Signed-off-by: Axel Lin axel.lin@ingics.com Acked-By: Alexander Stein alexander.stein@systec-electronic.com Signed-off-by: Mark Brown broonie@kernel.org --- sound/soc/codecs/sgtl5000.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/sgtl5000.h b/sound/soc/codecs/sgtl5000.h index bd7a344bf8c5..1c317de26176 100644 --- a/sound/soc/codecs/sgtl5000.h +++ b/sound/soc/codecs/sgtl5000.h @@ -275,7 +275,7 @@ #define SGTL5000_BIAS_CTRL_MASK 0x000e #define SGTL5000_BIAS_CTRL_SHIFT 1 #define SGTL5000_BIAS_CTRL_WIDTH 3 -#define SGTL5000_SMALL_POP 0 +#define SGTL5000_SMALL_POP 1
/* * SGTL5000_CHIP_MIC_CTRL
On Wed, Jul 22, 2015 at 11:27 AM, Axel Lin axel.lin@ingics.com wrote:
Currently, below code actually does not update any bit because SGTL5000_SMALL_POP is 0.
snd_soc_update_bits(codec, SGTL5000_CHIP_REF_CTRL, SGTL5000_SMALL_POP, 1);
The SGTL5000_SMALL_POP should be BIT(0) rather than 0, fix it.
Signed-off-by: Axel Lin axel.lin@ingics.com
Hi, I don't have h/w and datasheet, but the code looks obvious does not make sense. Can someone help to confirm and test if this patch? Thanks, Axel sound/soc/codecs/sgtl5000.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/sgtl5000.h b/sound/soc/codecs/sgtl5000.h index bd7a344..1c317de 100644 --- a/sound/soc/codecs/sgtl5000.h +++ b/sound/soc/codecs/sgtl5000.h @@ -275,7 +275,7 @@ #define SGTL5000_BIAS_CTRL_MASK 0x000e #define SGTL5000_BIAS_CTRL_SHIFT 1 #define SGTL5000_BIAS_CTRL_WIDTH 3 -#define SGTL5000_SMALL_POP 0 +#define SGTL5000_SMALL_POP 1
/*
- SGTL5000_CHIP_MIC_CTRL
-- 2.1.0
Thanks for your report, seems your are right. I have no board to test it.
The code introduced by c251ea7bd7a04f1f2575467e0de76e803cf59149. Fabio, can you verify it on mx28evk?
Thanks
participants (5)
-
Alexander Stein -
Axel Lin -
Fabio Estevam -
Mark Brown -
Zeng Zhaoming