[alsa-devel] [PATCH - alsa-lib 1/1] include/global.h: missing struct on FreeBSD
From: Rumko rumko@rumko.net
On FreeBSD, struct timespec is not accessible through <time.h>, but through <sys/tiespec.h>. Add specific include for that header on that platform only.
Signed-off-by: Rumko rumko@rumko.net
diff --git a/include/global.h b/include/global.h index 16a26dc..70be1f9 100644 --- a/include/global.h +++ b/include/global.h @@ -31,6 +31,10 @@ /* for timeval and timespec */ #include <time.h>
+#if defined(__FreeBSD__) +#include <sys/timespec.h> +#endif + #ifdef __cplusplus extern "C" { #endif
At Sat, 10 Jan 2015 11:04:59 +0100, rumko@rumko.net wrote:
From: Rumko rumko@rumko.net
On FreeBSD, struct timespec is not accessible through <time.h>, but through <sys/tiespec.h>. Add specific include for that header on that platform only.
Signed-off-by: Rumko rumko@rumko.net
If you give your sign-off, please give the full real name.
thanks,
Takashi
diff --git a/include/global.h b/include/global.h index 16a26dc..70be1f9 100644 --- a/include/global.h +++ b/include/global.h @@ -31,6 +31,10 @@ /* for timeval and timespec */ #include <time.h>
+#if defined(__FreeBSD__) +#include <sys/timespec.h> +#endif
#ifdef __cplusplus extern "C" {
#endif
2.2.1
On Sunday 11 January 2015 11:27:52 Takashi Iwai wrote:
At Sat, 10 Jan 2015 11:04:59 +0100,
rumko@rumko.net wrote:
From: Rumko rumko@rumko.net
On FreeBSD, struct timespec is not accessible through <time.h>, but through <sys/tiespec.h>. Add specific include for that header on that platform only.
Signed-off-by: Rumko rumko@rumko.net
If you give your sign-off, please give the full real name.
Sorry about that, was just following http://www.alsa-project.org/main/index.php/GIT_Server#Occasional_Developers It specifically adds the -s flag to format-patch as instructions for generating the patchset.
Should I resubmit without it?
thanks,
Takashi
At Sun, 11 Jan 2015 12:17:31 +0100, Rumko wrote:
On Sunday 11 January 2015 11:27:52 Takashi Iwai wrote:
At Sat, 10 Jan 2015 11:04:59 +0100,
rumko@rumko.net wrote:
From: Rumko rumko@rumko.net
On FreeBSD, struct timespec is not accessible through <time.h>, but through <sys/tiespec.h>. Add specific include for that header on that platform only.
Signed-off-by: Rumko rumko@rumko.net
If you give your sign-off, please give the full real name.
Sorry about that, was just following http://www.alsa-project.org/main/index.php/GIT_Server#Occasional_Developers It specifically adds the -s flag to format-patch as instructions for generating the patchset.
Should I resubmit without it?
We follow the policy of Linux kernel development for the user-space stuff in principle. See Documentation/SubmittingPatches of Linux driver tree, "Sign your work" section. You need to give the real name.
thanks,
Takashi
On Sunday 11 January 2015 16:57:39 Takashi Iwai wrote: <snip>
We follow the policy of Linux kernel development for the user-space stuff in principle. See Documentation/SubmittingPatches of Linux driver tree, "Sign your work" section. You need to give the real name.
Ah, in that case, sorry to have bothered you. As far as I'm concerned, this thread can be closed.
Thank you
thanks,
Takashi
participants (3)
-
Rumko -
rumko＠rumko.net
-
Takashi Iwai