[alsa-devel] [Xen-devel][PATCH] ALSA: xen-front: Do not use stream buffer size before it is set
From: Oleksandr Andrushchenko oleksandr_andrushchenko@epam.com
This fixes the regression introduced while moving to Xen shared buffer implementation.
Fixes: 58f9d806d16a ("ALSA: xen-front: Use Xen common shared buffer implementation")
Signed-off-by: Oleksandr Andrushchenko oleksandr_andrushchenko@epam.com --- sound/xen/xen_snd_front_alsa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/xen/xen_snd_front_alsa.c b/sound/xen/xen_snd_front_alsa.c index a7f413cb704d..b14ab512c2ce 100644 --- a/sound/xen/xen_snd_front_alsa.c +++ b/sound/xen/xen_snd_front_alsa.c @@ -441,7 +441,7 @@ static int shbuf_setup_backstore(struct xen_snd_front_pcm_stream_info *stream, { int i;
- stream->buffer = alloc_pages_exact(stream->buffer_sz, GFP_KERNEL); + stream->buffer = alloc_pages_exact(buffer_sz, GFP_KERNEL); if (!stream->buffer) return -ENOMEM;
On 04/04/2019 14:38, Oleksandr Andrushchenko wrote:
From: Oleksandr Andrushchenko oleksandr_andrushchenko@epam.com
This fixes the regression introduced while moving to Xen shared buffer implementation.
Fixes: 58f9d806d16a ("ALSA: xen-front: Use Xen common shared buffer implementation")
Signed-off-by: Oleksandr Andrushchenko oleksandr_andrushchenko@epam.com
Reviewed-by: Juergen Gross jgross@suse.com
Juergen
On Thu, 04 Apr 2019 14:42:44 +0200, Juergen Gross wrote:
On 04/04/2019 14:38, Oleksandr Andrushchenko wrote:
From: Oleksandr Andrushchenko oleksandr_andrushchenko@epam.com
This fixes the regression introduced while moving to Xen shared buffer implementation.
Fixes: 58f9d806d16a ("ALSA: xen-front: Use Xen common shared buffer implementation")
Signed-off-by: Oleksandr Andrushchenko oleksandr_andrushchenko@epam.com
Reviewed-by: Juergen Gross jgross@suse.com
Applied now, thanks. I put Cc to stable since the bug was already in 5.0.
Takashi
On 4/4/19 3:45 PM, Takashi Iwai wrote:
On Thu, 04 Apr 2019 14:42:44 +0200, Juergen Gross wrote:
On 04/04/2019 14:38, Oleksandr Andrushchenko wrote:
From: Oleksandr Andrushchenko oleksandr_andrushchenko@epam.com
This fixes the regression introduced while moving to Xen shared buffer implementation.
Fixes: 58f9d806d16a ("ALSA: xen-front: Use Xen common shared buffer implementation")
Signed-off-by: Oleksandr Andrushchenko oleksandr_andrushchenko@epam.com
Reviewed-by: Juergen Gross jgross@suse.com
Applied now, thanks. I put Cc to stable since the bug was already in 5.0.
Takashi
Thank you, Oleksandr
participants (3)
-
Juergen Gross
-
Oleksandr Andrushchenko
-
Takashi Iwai