[alsa-devel] [PATCH] ASoC: Remove module probe announcements from CODEC drivers
Signed-off-by: Mark Brown broonie@opensource.wolfsonmicro.com --- sound/soc/codecs/ak4104.c | 1 - sound/soc/codecs/cs4270.c | 2 -- 2 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/sound/soc/codecs/ak4104.c b/sound/soc/codecs/ak4104.c index c27f8f5..cbf0b6d 100644 --- a/sound/soc/codecs/ak4104.c +++ b/sound/soc/codecs/ak4104.c @@ -294,7 +294,6 @@ static struct spi_driver ak4104_spi_driver = {
static int __init ak4104_init(void) { - pr_info("Asahi Kasei AK4104 ALSA SoC Codec Driver\n"); return spi_register_driver(&ak4104_spi_driver); } module_init(ak4104_init); diff --git a/sound/soc/codecs/cs4270.c b/sound/soc/codecs/cs4270.c index c0fccad..65f578f 100644 --- a/sound/soc/codecs/cs4270.c +++ b/sound/soc/codecs/cs4270.c @@ -743,8 +743,6 @@ static struct i2c_driver cs4270_i2c_driver = {
static int __init cs4270_init(void) { - pr_info("Cirrus Logic CS4270 ALSA SoC Codec Driver\n"); - return i2c_add_driver(&cs4270_i2c_driver); } module_init(cs4270_init);
Mark Brown wrote:
static int __init cs4270_init(void) {
- pr_info("Cirrus Logic CS4270 ALSA SoC Codec Driver\n");
- return i2c_add_driver(&cs4270_i2c_driver);
}
I'm not fond of this at all.
Can I get a justification for this change? On my boards, the CS4270 driver is compiled in-kernel, not as a module, and so when the kernel boots, the driver announces itself when it's loaded. I like this a lot, which is why I always put a pr_info() in the __init function of my modules.
On Tue, Mar 01, 2011 at 02:17:09PM -0600, Timur Tabi wrote:
Can I get a justification for this change? On my boards, the CS4270 driver is compiled in-kernel, not as a module, and so when the kernel boots, the driver announces itself when it's loaded. I like this a lot, which is why I always put a pr_info() in the __init function of my modules.
It's rather chatty, especially where one has unused modules compiled into the kernel, and displayed on the (usually slow serial) console by default. Having lots of drivers announce themselves in this fashion gets rather spammy, at the minute only a very small proportion do so. As a matter of policy Linux drivers generally don't do this.
Printing a message when the driver is actually binding to hardware can be useful, mainly if it's something like announcing the device revision, but doing so at module load isn't really conveying anything meaningful.
On Tue, 2011-03-01 at 20:14 +0000, Mark Brown wrote:
Signed-off-by: Mark Brown broonie@opensource.wolfsonmicro.com
sound/soc/codecs/ak4104.c | 1 - sound/soc/codecs/cs4270.c | 2 -- 2 files changed, 0 insertions(+), 3 deletions(-)
Acked-by: Liam Girdwood lrg@slimlogic.co.uk
participants (3)
-
Liam Girdwood -
Mark Brown -
Timur Tabi