[alsa-devel] [PATCH v2 0/2] ASoC: ads117x: Add device tree support for TI ADS117x
Hello,
This series adds device tree support for Texas Instruments ADS117x ADC chip. The first patch adds the binding documentation, while the second patch adds the compatible string into the driver. No further properties are necessary.
Best regards, Florian
--- Since v1: - Updated topic for the documentation patch - Removed wildcard in compatible string ---
Florian Vaussard (2): ASoC: ads117x: Add bindings documentation for TI ADS117x ADC ASoC: ads117x: Add device tree compatible string
Documentation/devicetree/bindings/sound/ti,ads117x.txt | 11 +++++++++++ sound/soc/codecs/ads117x.c | 12 ++++++++++++ 2 files changed, 23 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/ti,ads117x.txt
Currently the binding is only made of the compatible string.
Signed-off-by: Florian Vaussard florian.vaussard@heig-vd.ch --- Documentation/devicetree/bindings/sound/ti,ads117x.txt | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/ti,ads117x.txt
diff --git a/Documentation/devicetree/bindings/sound/ti,ads117x.txt b/Documentation/devicetree/bindings/sound/ti,ads117x.txt new file mode 100644 index 0000000..7db19b5 --- /dev/null +++ b/Documentation/devicetree/bindings/sound/ti,ads117x.txt @@ -0,0 +1,11 @@ +Texas Intstruments ADS117x ADC + +Required properties: + + - compatible : "ti,ads1174" or "ti,ads1178" + +Example: + +ads1178 { + compatible = "ti,ads1178"; +};
On Fri, Feb 05, 2016 at 04:32:13PM +0100, Florian Vaussard wrote:
Currently the binding is only made of the compatible string.
Signed-off-by: Florian Vaussard florian.vaussard@heig-vd.ch
Documentation/devicetree/bindings/sound/ti,ads117x.txt | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/ti,ads117x.txt
Acked-by: Rob Herring robh@kernel.org
The patch
ASoC: ads117x: Add bindings documentation for TI ADS117x ADC
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks, Mark
From c9146fae4e88fa9864c4a7087289523b96cdbf2d Mon Sep 17 00:00:00 2001
From: Florian Vaussard florian.vaussard@gmail.com Date: Fri, 5 Feb 2016 16:32:13 +0100 Subject: [PATCH] ASoC: ads117x: Add bindings documentation for TI ADS117x ADC
Currently the binding is only made of the compatible string.
Signed-off-by: Florian Vaussard florian.vaussard@heig-vd.ch Signed-off-by: Mark Brown broonie@kernel.org --- Documentation/devicetree/bindings/sound/ti,ads117x.txt | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/ti,ads117x.txt
diff --git a/Documentation/devicetree/bindings/sound/ti,ads117x.txt b/Documentation/devicetree/bindings/sound/ti,ads117x.txt new file mode 100644 index 000000000000..7db19b50865a --- /dev/null +++ b/Documentation/devicetree/bindings/sound/ti,ads117x.txt @@ -0,0 +1,11 @@ +Texas Intstruments ADS117x ADC + +Required properties: + + - compatible : "ti,ads1174" or "ti,ads1178" + +Example: + +ads1178 { + compatible = "ti,ads1178"; +};
This patch adds the necessary device tree compatible string to allow DT probing.
Signed-off-by: Florian Vaussard florian.vaussard@heig-vd.ch --- sound/soc/codecs/ads117x.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)
diff --git a/sound/soc/codecs/ads117x.c b/sound/soc/codecs/ads117x.c index 1222282..c5be1bd 100644 --- a/sound/soc/codecs/ads117x.c +++ b/sound/soc/codecs/ads117x.c @@ -20,6 +20,8 @@ #include <sound/initval.h> #include <sound/soc.h>
+#include <linux/of.h> + #define ADS117X_RATES (SNDRV_PCM_RATE_8000_48000) #define ADS117X_FORMATS (SNDRV_PCM_FMTBIT_S16_LE)
@@ -75,9 +77,19 @@ static int ads117x_remove(struct platform_device *pdev) return 0; }
+#if defined(CONFIG_OF) +static const struct of_device_id ads117x_dt_ids[] = { + { .compatible = "ti,ads1174" }, + { .compatible = "ti,ads1178" }, + { }, +}; +MODULE_DEVICE_TABLE(of, ads117x_dt_ids); +#endif + static struct platform_driver ads117x_codec_driver = { .driver = { .name = "ads117x-codec", + .of_match_table = of_match_ptr(ads117x_dt_ids), },
.probe = ads117x_probe,
Hello Mark,
On 02/05/2016 04:32 PM, Florian Vaussard wrote:
This patch adds the necessary device tree compatible string to allow DT probing.
Signed-off-by: Florian Vaussard florian.vaussard@heig-vd.ch
sound/soc/codecs/ads117x.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)
diff --git a/sound/soc/codecs/ads117x.c b/sound/soc/codecs/ads117x.c index 1222282..c5be1bd 100644 --- a/sound/soc/codecs/ads117x.c +++ b/sound/soc/codecs/ads117x.c @@ -20,6 +20,8 @@ #include <sound/initval.h> #include <sound/soc.h>
+#include <linux/of.h>
#define ADS117X_RATES (SNDRV_PCM_RATE_8000_48000) #define ADS117X_FORMATS (SNDRV_PCM_FMTBIT_S16_LE)
@@ -75,9 +77,19 @@ static int ads117x_remove(struct platform_device *pdev) return 0; }
+#if defined(CONFIG_OF) +static const struct of_device_id ads117x_dt_ids[] = {
- { .compatible = "ti,ads1174" },
- { .compatible = "ti,ads1178" },
- { },
+}; +MODULE_DEVICE_TABLE(of, ads117x_dt_ids); +#endif
static struct platform_driver ads117x_codec_driver = { .driver = { .name = "ads117x-codec",
.of_match_table = of_match_ptr(ads117x_dt_ids),
},
.probe = ads117x_probe,
Do you have any more comments on this patch?
Best regards, Florian
On Wed, Feb 24, 2016 at 08:36:37AM +0100, Florian Vaussard wrote:
.name = "ads117x-codec",
.of_match_table = of_match_ptr(ads117x_dt_ids),
},
.probe = ads117x_probe,
Do you have any more comments on this patch?
Please don't send content free pings and please allow a reasonable time for review. People get busy, go on holiday, attend conferences and so on so unless there is some reason for urgency (like critical bug fixes) please allow at least a couple of weeks for review. Sending content free pings just adds to the mail volume (if they are seen at all) and if something has gone wrong you'll have to resend the patches anyway.
The patch
ASoC: ads117x: Add device tree compatible string
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks, Mark
From 4f2bf0ace0f96cc693002e1bbde967fa2356bc43 Mon Sep 17 00:00:00 2001
From: Florian Vaussard florian.vaussard@gmail.com Date: Fri, 5 Feb 2016 16:32:14 +0100 Subject: [PATCH] ASoC: ads117x: Add device tree compatible string
This patch adds the necessary device tree compatible string to allow DT probing.
Signed-off-by: Florian Vaussard florian.vaussard@heig-vd.ch Signed-off-by: Mark Brown broonie@kernel.org --- sound/soc/codecs/ads117x.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)
diff --git a/sound/soc/codecs/ads117x.c b/sound/soc/codecs/ads117x.c index 1222282e93c3..c5be1bdc2c9a 100644 --- a/sound/soc/codecs/ads117x.c +++ b/sound/soc/codecs/ads117x.c @@ -20,6 +20,8 @@ #include <sound/initval.h> #include <sound/soc.h>
+#include <linux/of.h> + #define ADS117X_RATES (SNDRV_PCM_RATE_8000_48000) #define ADS117X_FORMATS (SNDRV_PCM_FMTBIT_S16_LE)
@@ -75,9 +77,19 @@ static int ads117x_remove(struct platform_device *pdev) return 0; }
+#if defined(CONFIG_OF) +static const struct of_device_id ads117x_dt_ids[] = { + { .compatible = "ti,ads1174" }, + { .compatible = "ti,ads1178" }, + { }, +}; +MODULE_DEVICE_TABLE(of, ads117x_dt_ids); +#endif + static struct platform_driver ads117x_codec_driver = { .driver = { .name = "ads117x-codec", + .of_match_table = of_match_ptr(ads117x_dt_ids), },
.probe = ads117x_probe,
participants (3)
-
Florian Vaussard
-
Mark Brown
-
Rob Herring