Re: [alsa-devel] [PATCH v2 4/4]AsoC/nuc900: fix a typo and rename the header file
On Wed, 2010-06-02 at 14:05 +0800, Wan ZongShun wrote:
Fix a '#include "nuc900-audio.h' typo, I think it should be 'audio'. At the same time, this patch renames the 'nuc900-auido.h' file to 'nuc900-audio.h'.
Signed-off-by: Wan ZongShunmcuos.com@gmail.com
sound/soc/nuc900/nuc900-ac97.c | 2 +- .../soc/nuc900/{nuc900-auido.h => nuc900-audio.h} | 0 2 files changed, 1 insertions(+), 1 deletions(-) rename sound/soc/nuc900/{nuc900-auido.h => nuc900-audio.h} (100%)
diff --git a/sound/soc/nuc900/nuc900-ac97.c b/sound/soc/nuc900/nuc900-ac97.c index db7fc13..caa7c90 100644 --- a/sound/soc/nuc900/nuc900-ac97.c +++ b/sound/soc/nuc900/nuc900-ac97.c @@ -25,7 +25,7 @@
#include <mach/mfp.h>
-#include "nuc900-auido.h" +#include "nuc900-audio.h"
static DEFINE_MUTEX(ac97_mutex); struct nuc900_audio *nuc900_ac97_data; diff --git a/sound/soc/nuc900/nuc900-auido.h b/sound/soc/nuc900/nuc900-audio.h similarity index 100% rename from sound/soc/nuc900/nuc900-auido.h rename to sound/soc/nuc900/nuc900-audio.h
I've just tried to build NUC900 as part of the ASoC multi-component work and it looks like you didn't build this patch before sending it. The old header name is still used in nuc900-audio.c and nuc900-pcm.c.
Can you send an incremental patch to fix this.
Thanks
Liam
2010/6/9 Liam Girdwood lrg@slimlogic.co.uk:
On Wed, 2010-06-02 at 14:05 +0800, Wan ZongShun wrote:
Fix a '#include "nuc900-audio.h' typo, I think it should be 'audio'. At the same time, this patch renames the 'nuc900-auido.h' file to 'nuc900-audio.h'.
Signed-off-by: Wan ZongShunmcuos.com@gmail.com
sound/soc/nuc900/nuc900-ac97.c | 2 +- .../soc/nuc900/{nuc900-auido.h => nuc900-audio.h} | 0 2 files changed, 1 insertions(+), 1 deletions(-) rename sound/soc/nuc900/{nuc900-auido.h => nuc900-audio.h} (100%)
diff --git a/sound/soc/nuc900/nuc900-ac97.c b/sound/soc/nuc900/nuc900-ac97.c index db7fc13..caa7c90 100644 --- a/sound/soc/nuc900/nuc900-ac97.c +++ b/sound/soc/nuc900/nuc900-ac97.c @@ -25,7 +25,7 @@
#include <mach/mfp.h>
-#include "nuc900-auido.h" +#include "nuc900-audio.h"
static DEFINE_MUTEX(ac97_mutex); struct nuc900_audio *nuc900_ac97_data; diff --git a/sound/soc/nuc900/nuc900-auido.h b/sound/soc/nuc900/nuc900-audio.h similarity index 100% rename from sound/soc/nuc900/nuc900-auido.h rename to sound/soc/nuc900/nuc900-audio.h
I've just tried to build NUC900 as part of the ASoC multi-component work and it looks like you didn't build this patch before sending it. The old header name is still used in nuc900-audio.c and nuc900-pcm.c.
God.
I am so sorry for this wrong, I just think it is only a little and obvious patch, so I really do not re-build it.
Can you send an incremental patch to fix this.
Okay, I will fix it tomorrow.
Thanks
Liam
Freelance Developer, SlimLogic Ltd ASoC and Voltage Regulator Maintainer. http://www.slimlogic.co.uk
participants (2)
-
Liam Girdwood
-
Wan ZongShun