[alsa-devel] Internal Mic vs Int Mic
To try to clean up a little in the Volume Control namespace, it seems "Int Mic" and "Internal Mic" both mean the same thing. "Internal Mic" seems to be the winning one as it is used in hda_codec.c:hda_get_input_pin_label.
So, would a patch that changes every "Int Mic" to "Internal Mic" be appreciated and merged?
At Mon, 20 Dec 2010 10:07:38 +0100, David Henningsson wrote:
To try to clean up a little in the Volume Control namespace, it seems "Int Mic" and "Internal Mic" both mean the same thing. "Internal Mic" seems to be the winning one as it is used in hda_codec.c:hda_get_input_pin_label.
So, would a patch that changes every "Int Mic" to "Internal Mic" be appreciated and merged?
Sounds reasonable. Go ahead.
thanks,
Takashi
On 2010-12-20 13:49, Takashi Iwai wrote:
At Mon, 20 Dec 2010 10:07:38 +0100, David Henningsson wrote:
To try to clean up a little in the Volume Control namespace, it seems "Int Mic" and "Internal Mic" both mean the same thing. "Internal Mic" seems to be the winning one as it is used in hda_codec.c:hda_get_input_pin_label.
So, would a patch that changes every "Int Mic" to "Internal Mic" be appreciated and merged?
Sounds reasonable. Go ahead.
Ok. I also took the liberty of renaming "Ext Mic" and "External Mic" to just "Mic", which is the de-facto standard for external microphone jacks.
At Mon, 20 Dec 2010 14:55:15 +0100, David Henningsson wrote:
On 2010-12-20 13:49, Takashi Iwai wrote:
At Mon, 20 Dec 2010 10:07:38 +0100, David Henningsson wrote:
To try to clean up a little in the Volume Control namespace, it seems "Int Mic" and "Internal Mic" both mean the same thing. "Internal Mic" seems to be the winning one as it is used in hda_codec.c:hda_get_input_pin_label.
So, would a patch that changes every "Int Mic" to "Internal Mic" be appreciated and merged?
Sounds reasonable. Go ahead.
Ok. I also took the liberty of renaming "Ext Mic" and "External Mic" to just "Mic", which is the de-facto standard for external microphone jacks.
Thanks, now applied all three patches.
Takashi
participants (2)
-
David Henningsson -
Takashi Iwai