[alsa-devel] sound: enable sound support on n900 on devicetree-based boot
With device tree, it is possible (and encouraged) to build N900 kernels without CONFIG_MACH_NOKIA_RX51. Update config file to enable the driver build in this case.
This makes sound work on my n900 under 3.18-rc1.
Signed-off-by: Pavel Machek pavel@ucw.cz
diff --git a/sound/soc/omap/Kconfig b/sound/soc/omap/Kconfig index d44463a..0d7b707 100644 --- a/sound/soc/omap/Kconfig +++ b/sound/soc/omap/Kconfig @@ -26,7 +26,7 @@ config SND_OMAP_SOC_N810
config SND_OMAP_SOC_RX51 tristate "SoC Audio support for Nokia RX-51" - depends on SND_OMAP_SOC && ARM && (MACH_NOKIA_RX51 || COMPILE_TEST) && I2C + depends on SND_OMAP_SOC && ARM && I2C select SND_OMAP_SOC_MCBSP select SND_SOC_TLV320AIC3X select SND_SOC_TPA6130A2
On Sun, Nov 09, 2014 at 01:02:22PM +0100, Pavel Machek wrote:
With device tree, it is possible (and encouraged) to build N900 kernels without CONFIG_MACH_NOKIA_RX51. Update config file to enable the driver build in this case.
Please do try to use subject lines reflecting the style for the subsystem.
config SND_OMAP_SOC_RX51 tristate "SoC Audio support for Nokia RX-51"
- depends on SND_OMAP_SOC && ARM && (MACH_NOKIA_RX51 || COMPILE_TEST) && I2C
- depends on SND_OMAP_SOC && ARM && I2C
Please also update the config text so users have a chance to figure out that this driver is the one they need for their system - I guess most people won't know what RX-51 is.
On Sun 2014-11-09 12:37:53, Mark Brown wrote:
On Sun, Nov 09, 2014 at 01:02:22PM +0100, Pavel Machek wrote:
With device tree, it is possible (and encouraged) to build N900 kernels without CONFIG_MACH_NOKIA_RX51. Update config file to enable the driver build in this case.
Please do try to use subject lines reflecting the style for the subsystem.
Ok.
config SND_OMAP_SOC_RX51 tristate "SoC Audio support for Nokia RX-51"
- depends on SND_OMAP_SOC && ARM && (MACH_NOKIA_RX51 || COMPILE_TEST) && I2C
- depends on SND_OMAP_SOC && ARM && I2C
Please also update the config text so users have a chance to figure out that this driver is the one they need for their system - I guess most people won't know what RX-51 is.
Actually help text below already explains that. I'll update tristate text, too. Pavel
With device tree, it is possible (and encouraged) to build N900 kernels without CONFIG_MACH_NOKIA_RX51. Update config file to enable the driver build in this case.
This makes sound work on my n900 under 3.18-rc1.
Signed-off-by: Pavel Machek pavel@ucw.cz
diff --git a/sound/soc/omap/Kconfig b/sound/soc/omap/Kconfig index d44463a..2738b19 100644 --- a/sound/soc/omap/Kconfig +++ b/sound/soc/omap/Kconfig @@ -25,15 +25,15 @@ config SND_OMAP_SOC_N810 Say Y if you want to add support for SoC audio on Nokia N810.
config SND_OMAP_SOC_RX51 - tristate "SoC Audio support for Nokia RX-51" - depends on SND_OMAP_SOC && ARM && (MACH_NOKIA_RX51 || COMPILE_TEST) && I2C + tristate "SoC Audio support for Nokia N900 (RX-51)" + depends on SND_OMAP_SOC && ARM && I2C select SND_OMAP_SOC_MCBSP select SND_SOC_TLV320AIC3X select SND_SOC_TPA6130A2 depends on GPIOLIB help - Say Y if you want to add support for SoC audio on Nokia RX-51 - hardware. This is also known as Nokia N900 product. + Say Y if you want to add support for SoC audio on Nokia N900 + cellphone.
config SND_OMAP_SOC_AMS_DELTA tristate "SoC Audio support for Amstrad E3 (Delta) videophone"
On Sun, Nov 09, 2014 at 08:41:51PM +0100, Pavel Machek wrote:
With device tree, it is possible (and encouraged) to build N900 kernels without CONFIG_MACH_NOKIA_RX51. Update config file to enable the driver build in this case.
Applied, thanks.
participants (2)
-
Mark Brown -
Pavel Machek