On 14/06/2023 05:17, Maso Huang (黃加竹) wrote:

On Tue, 2023-06-13 at 10:51 +0200, Krzysztof Kozlowski wrote:

...

External email : Please do not click links or open attachments until you have verified the sender or the content.

On 12/06/2023 12:52, Maso Hunag wrote:

...

From: Maso Huang maso.huang@mediatek.com

Add mt79xx audio afe document.

Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel.

Hi Krzysztif,

Thanks for your review. And sorry for missing some necessary maintainers. What's your suggestion, resend these patches again with them, or add them back in v2 patch?

You need to fix the patch anyway, so use get_maintainers.pl in v2. I don't understand why you Cc here many unrelated people but not the actual maintainers which get_maintainers.pl asks you to Cc!

...

...

Signed-off-by: Maso Huang maso.huang@mediatek.com

.../bindings/sound/mediatek,mt79xx-afe.yaml | 102

++++++++++++++++++

...

1 file changed, 102 insertions(+) create mode 100644

Documentation/devicetree/bindings/sound/mediatek,mt79xx-afe.yaml

...

diff --git

a/Documentation/devicetree/bindings/sound/mediatek,mt79xx-afe.yaml b/Documentation/devicetree/bindings/sound/mediatek,mt79xx-afe.yaml

...

new file mode 100644 index 000000000000..11ef1cfdf49b --- /dev/null +++ b/Documentation/devicetree/bindings/sound/mediatek,mt79xx-

afe.yaml

...

@@ -0,0 +1,102 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/mediatek,mt79xx-afe.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml#

+title: MediaTek AFE PCM controller for MT79xx

79XX sounds weird. Are you sure you are not using wildcards (which are not allowed)?

We would like to use mt79xx for mt7986/mt7981/mt7988 series. Or is it better to just use mt7986 for this series?

You cannot use wildcard. Get some internal review of your patches prior to submission to mailing list.

https://elixir.bootlin.com/linux/v6.1-rc1/source/Documentation/devicetree/bi...

...

...

+maintainers:

• • Maso Huang maso.huang@mediatek.com

+properties:

• compatible:
• oneOf:

•  - const: mediatek,mt79xx-afe
  

•  - items:
  

•      - enum:
  

•          - mediatek,mt7981-afe
  

•          - mediatek,mt7986-afe
  

•          - mediatek,mt7988-afe
  

•      - const: mediatek,mt79xx-afe
  

I already saw AFE, why it cannot be part of existing bindings?

Can you answer this?

...

This list is odd. 79xx, 7981? So it is wildcard?

Yes, it is wildcard for mt7986/mt7981/mt7988 series. Is it better to just use mt7986 for this series?

No wildcards.

Best regards, Krzysztof