Re: [PATCH] ALSA: hda/realtek: Add quirk for Samsung Galaxy Book Ion 15 inches
There's a mistake in this. The ID numbers are the wrong way round.
Alex
On Mon, 24 Aug 2020 14:31:17 +0200, Alex Dewar wrote:
My mistake -- I didn't read your changelog properly. Sorry!
Would you resubmit the corrected fix patch?
Also, better to indicate the device id number in the patch description. It's confusing which entry you've corrected intentionally for what, and documenting it would help understanding it.
thanks,
Takashi
On 24/08/2020 13:30, Alex Dewar wrote:
There's a mistake in this. The ID numbers are the wrong way round.
Alex
I believe the code is correct (even though the diff is confusing), but I can edit the commit message to also mention the model name.
Should I submit the patch here as a reply ? or should I create a brand new submission in a new thread ?
On Tue, 25 Aug 2020 at 17:00, Takashi Iwai tiwai@suse.de wrote:
On Mon, 24 Aug 2020 14:31:17 +0200, Alex Dewar wrote:
My mistake -- I didn't read your changelog properly. Sorry!
Would you resubmit the corrected fix patch?
Also, better to indicate the device id number in the patch description. It's confusing which entry you've corrected intentionally for what, and documenting it would help understanding it.
thanks,
Takashi
On 24/08/2020 13:30, Alex Dewar wrote:
There's a mistake in this. The ID numbers are the wrong way round.
Alex
On Tue, 25 Aug 2020 16:36:13 +0200, Adrien Crivelli wrote:
[1 <text/plain; UTF-8 (7bit)>]
I believe the code is correct (even though the diff is confusing), but I can edit the commit message to also mention the model name.
Should I submit the patch here as a reply ? or should I create a brand new submission in a new thread ?
In a new thread please.
thanks,
Takashi
On Tue, 25 Aug 2020 at 17:00, Takashi Iwai tiwai@suse.de wrote:
On Mon, 24 Aug 2020 14:31:17 +0200, Alex Dewar wrote: > > My mistake -- I didn't read your changelog properly. Sorry! Would you resubmit the corrected fix patch? Also, better to indicate the device id number in the patch description. It's confusing which entry you've corrected intentionally for what, and documenting it would help understanding it. thanks, Takashi > > On 24/08/2020 13:30, Alex Dewar wrote: > > There's a mistake in this. The ID numbers are the wrong way round. > > > > Alex >
I just submitted the new patch.
On Wed, 26 Aug 2020 at 00:03, Takashi Iwai tiwai@suse.de wrote:
On Tue, 25 Aug 2020 16:36:13 +0200, Adrien Crivelli wrote:
[1 <text/plain; UTF-8 (7bit)>]
I believe the code is correct (even though the diff is confusing), but I
can
edit the commit message to also mention the model name.
Should I submit the patch here as a reply ? or should I create a brand
new
submission in a new thread ?
In a new thread please.
thanks,
Takashi
On Tue, 25 Aug 2020 at 17:00, Takashi Iwai tiwai@suse.de wrote:
On Mon, 24 Aug 2020 14:31:17 +0200, Alex Dewar wrote: > > My mistake -- I didn't read your changelog properly. Sorry! Would you resubmit the corrected fix patch? Also, better to indicate the device id number in the patch description. It's confusing which entry you've corrected intentionally for what, and documenting it would help understanding it. thanks, Takashi > > On 24/08/2020 13:30, Alex Dewar wrote: > > There's a mistake in this. The ID numbers are the wrong wayround.
> > > > Alex >
participants (3)
-
Adrien Crivelli -
Alex Dewar -
Takashi Iwai