[alsa-devel] [BUG] soc/sti: a possible sleep-in-atomic bug in uni_player_ctl_iec958_put
According to sound/soc/sti/uniperif_player.c, the driver may sleep under a spinlock. The function call path is: uni_player_ctl_iec958_put (acquire the spinlock) uni_player_set_channel_status mutex_lock --> may sleep
I do not find a good way to fix it, so I only report. This possible bug is found by my static analysis tool (DSAC) and checked by my code review.
Thanks, Jia-Ju Bai
Hello Jia-Ju,
On 12/12/2017 03:27 PM, Jia-Ju Bai wrote:
According to sound/soc/sti/uniperif_player.c, the driver may sleep under a spinlock. The function call path is: uni_player_ctl_iec958_put (acquire the spinlock) uni_player_set_channel_status mutex_lock --> may sleep
I do not find a good way to fix it, so I only report. This possible bug is found by my static analysis tool (DSAC) and checked by my code review.
you right, mutex under spin lock is not recommended... I will have a look Thanks!
Regards Arnaud
Thanks, Jia-Ju Bai
participants (2)
-
Arnaud Pouliquen -
Jia-Ju Bai