[alsa-devel] [patch] move dereference after null check
The 'jack' variable was dereference before the NULL check so this patch moves the dereference later.
regards, dan carpenter
Signed-off-by: Dan Carpenter error27@gmail.com
--- orig/sound/soc/soc-jack.c 2009-11-14 11:04:04.000000000 +0200 +++ devel/sound/soc/soc-jack.c 2009-11-14 11:05:01.000000000 +0200 @@ -58,7 +58,7 @@ */ void snd_soc_jack_report(struct snd_soc_jack *jack, int status, int mask) { - struct snd_soc_codec *codec = jack->card->codec; + struct snd_soc_codec *codec; struct snd_soc_jack_pin *pin; int enable; int oldstatus; @@ -67,6 +67,7 @@ WARN_ON_ONCE(!jack); return; } + codec = jack->card->codec;
mutex_lock(&codec->mutex);
On Mon, 2009-11-16 at 11:06 +0200, Dan Carpenter wrote:
The 'jack' variable was dereference before the NULL check so this patch moves the dereference later.
regards, dan carpenter
Signed-off-by: Dan Carpenter error27@gmail.com
Acked-by: Liam Girdwood lrg@slimlogic.co.uk
--- orig/sound/soc/soc-jack.c 2009-11-14 11:04:04.000000000 +0200 +++ devel/sound/soc/soc-jack.c 2009-11-14 11:05:01.000000000 +0200 @@ -58,7 +58,7 @@ */ void snd_soc_jack_report(struct snd_soc_jack *jack, int status, int mask) {
- struct snd_soc_codec *codec = jack->card->codec;
- struct snd_soc_codec *codec; struct snd_soc_jack_pin *pin; int enable; int oldstatus;
@@ -67,6 +67,7 @@ WARN_ON_ONCE(!jack); return; }
codec = jack->card->codec;
mutex_lock(&codec->mutex);
On Mon, Nov 16, 2009 at 11:06:33AM +0200, Dan Carpenter wrote:
The 'jack' variable was dereference before the NULL check so this patch moves the dereference later.
regards, dan carpenter
Signed-off-by: Dan Carpenter error27@gmail.com
This does not apply to the current ASoC code, it appears that someone else has already provided an equivalent change. When doing work like this it's normally best to work against -next to help avoid duplication such as this.
At Mon, 16 Nov 2009 16:11:24 +0000, Mark Brown wrote:
On Mon, Nov 16, 2009 at 11:06:33AM +0200, Dan Carpenter wrote:
The 'jack' variable was dereference before the NULL check so this patch moves the dereference later.
regards, dan carpenter
Signed-off-by: Dan Carpenter error27@gmail.com
This does not apply to the current ASoC code, it appears that someone else has already provided an equivalent change. When doing work like this it's normally best to work against -next to help avoid duplication such as this.
Yep. FYI, it's the commit below:
commit 4f066173fe8deb8874f41917e5d26ea2e0c46e3b Author: Julia Lawall julia@diku.dk Date: Sat Oct 17 08:32:56 2009 +0200 ASoC: Move dereference after NULL test
thanks,
Takashi
Sorry about that.
I wish I could but until I get broadband, or git gets a restartable clone I can't use it for kernel development. The kernel archive is too big to download in one shot.
Right now I pay $20 and I can use wifi for a week but it's capped out at 200MB. Fortunately, I'm likely to get broadband soon. I'll pay $156 per month and it's capped at 200MB during business hours and "unlimitted" on nights and weekends. Woohoo!
regards, dan carpenter
On Mon, 16 Nov 2009, Mark Brown wrote:
On Mon, Nov 16, 2009 at 11:06:33AM +0200, Dan Carpenter wrote:
The 'jack' variable was dereference before the NULL check so this patch moves the dereference later.
regards, dan carpenter
Signed-off-by: Dan Carpenter error27@gmail.com
This does not apply to the current ASoC code, it appears that someone else has already provided an equivalent change. When doing work like this it's normally best to work against -next to help avoid duplication such as this.
participants (4)
-
Dan Carpenter -
Liam Girdwood -
Mark Brown -
Takashi Iwai