[alsa-devel] [PATCH 0/2] Lenovo Thinkpad quirks
Minor update to support new skews and need to manage quirks in codec driver for jack detection to work.
Nicole Faerber (1): ASoC: codecs: rt5670: add Thinkpad Tablet 10 quirk
Pierre-Louis Bossart (1): ASoC: Intel: Atom: update Thinkpad 10 quirk
sound/soc/codecs/rt5670.c | 21 +++++++++++++++++++++ sound/soc/intel/atom/sst/sst_acpi.c | 16 +++++++++++++++- 2 files changed, 36 insertions(+), 1 deletion(-)
There are multiple skews of the same Lenovo audio hardware based on the Realtek RT5670 codec.
Manufacturer: LENOVO Product Name: 20C1CTO1WW Version: ThinkPad 10
Manufacturer: LENOVO Product Name: 20C3001VHH Version: ThinkPad 10
Manufacturer: LENOVO Product Name: 20C10024GE Version: ThinkPad Tablet B
Manufacturer: LENOVO Product Name: 20359 Version: Lenovo Miix 2 10
For all these devices, the same quirk is used to force the machine driver to be based on RT5670 instead of RT5640 as indicated by the BIOS.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=96691 Tested-by: Nicole Faerber nicole.faerber@dpin.de Tested-by: Viacheslav Ostroukh v.dev@ostroukh.me Signed-off-by: Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com --- sound/soc/intel/atom/sst/sst_acpi.c | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/sound/soc/intel/atom/sst/sst_acpi.c b/sound/soc/intel/atom/sst/sst_acpi.c index 18fe46e..dd250b8 100644 --- a/sound/soc/intel/atom/sst/sst_acpi.c +++ b/sound/soc/intel/atom/sst/sst_acpi.c @@ -420,7 +420,21 @@ static const struct dmi_system_id byt_table[] = { .callback = byt_thinkpad10_quirk_cb, .matches = { DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), - DMI_MATCH(DMI_PRODUCT_NAME, "20C3001VHH"), + DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad 10"), + }, + }, + { + .callback = byt_thinkpad10_quirk_cb, + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), + DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad Tablet B"), + }, + }, + { + .callback = byt_thinkpad10_quirk_cb, + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), + DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo Miix 2 10"), }, }, { }
L'octidi 28 germinal, an CCXXV, Pierre-Louis Bossart a écrit :
There are multiple skews of the same Lenovo audio hardware based on the Realtek RT5670 codec.
Manufacturer: LENOVO Product Name: 20359 Version: Lenovo Miix 2 10
Interesting. Any chance that applies to the Miix 3-1030 too?
- {
.callback = byt_thinkpad10_quirk_cb,.matches = {DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo Miix 2 10"),
I guess I should run dmidecode, get the kernel sources, make a similar change and test. Unfortunately, I will probably not have time to do that until at least the week-end.
Thanks.
On 04/17/2017 10:12 AM, Nicolas George wrote:
L'octidi 28 germinal, an CCXXV, Pierre-Louis Bossart a écrit :
There are multiple skews of the same Lenovo audio hardware based on the Realtek RT5670 codec. Manufacturer: LENOVO Product Name: 20359 Version: Lenovo Miix 2 10
Interesting. Any chance that applies to the Miix 3-1030 too?
no idea, you'd have to look at dmesg/DSDT and check if the same rt5640/rt5670 BIOS confusion applies.
- {
.callback = byt_thinkpad10_quirk_cb,.matches = {DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo Miix 2 10"),I guess I should run dmidecode, get the kernel sources, make a similar change and test. Unfortunately, I will probably not have time to do that until at least the week-end.
DMI decode is only needed once you've confirmed the device can't work with the normal ACPI handling. Please provide your findings on bugzilla (dmesg, DSDT, alsa-info.sh) https://bugzilla.kernel.org/show_bug.cgi?id=96691
Thanks.
Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
The patch
ASoC: Intel: Atom: update Thinkpad 10 quirk
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks, Mark
From beb5989a8c6c6867b4e873cca2a66d31f977368f Mon Sep 17 00:00:00 2001
From: Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com Date: Mon, 17 Apr 2017 10:04:07 -0500 Subject: [PATCH] ASoC: Intel: Atom: update Thinkpad 10 quirk
There are multiple skews of the same Lenovo audio hardware based on the Realtek RT5670 codec.
Manufacturer: LENOVO Product Name: 20C1CTO1WW Version: ThinkPad 10
Manufacturer: LENOVO Product Name: 20C3001VHH Version: ThinkPad 10
Manufacturer: LENOVO Product Name: 20C10024GE Version: ThinkPad Tablet B
Manufacturer: LENOVO Product Name: 20359 Version: Lenovo Miix 2 10
For all these devices, the same quirk is used to force the machine driver to be based on RT5670 instead of RT5640 as indicated by the BIOS.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=96691 Tested-by: Nicole Faerber nicole.faerber@dpin.de Tested-by: Viacheslav Ostroukh v.dev@ostroukh.me Signed-off-by: Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com Signed-off-by: Mark Brown broonie@kernel.org --- sound/soc/intel/atom/sst/sst_acpi.c | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/sound/soc/intel/atom/sst/sst_acpi.c b/sound/soc/intel/atom/sst/sst_acpi.c index 18fe46ef6ac7..dd250b8b26f2 100644 --- a/sound/soc/intel/atom/sst/sst_acpi.c +++ b/sound/soc/intel/atom/sst/sst_acpi.c @@ -420,7 +420,21 @@ static const struct dmi_system_id byt_table[] = { .callback = byt_thinkpad10_quirk_cb, .matches = { DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), - DMI_MATCH(DMI_PRODUCT_NAME, "20C3001VHH"), + DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad 10"), + }, + }, + { + .callback = byt_thinkpad10_quirk_cb, + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), + DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad Tablet B"), + }, + }, + { + .callback = byt_thinkpad10_quirk_cb, + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), + DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo Miix 2 10"), }, }, { }
From: Nicole Faerber nicole.faerber@id3p.com
The Thinkpad Tablet tablet has a similar audio setup as the Intel Braswell platform. A quirk is needed to detect the platform and setup the platform data properly:
Manufacturer: LENOVO Product Name: 20C1CTO1WW Version: ThinkPad 10
Manufacturer: LENOVO Product Name: 20C3001VHH Version: ThinkPad 10
Manufacturer: LENOVO Product Name: 20C10024GE Version: ThinkPad Tablet B
Manufacturer: LENOVO Product Name: 20359 Version: Lenovo Miix 2 10
Signed-off-by: Nicole Faerber nicole.faerber@id3p.com Signed-off-by: Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com --- sound/soc/codecs/rt5670.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+)
diff --git a/sound/soc/codecs/rt5670.c b/sound/soc/codecs/rt5670.c index 17d20b9..e27c5a4 100644 --- a/sound/soc/codecs/rt5670.c +++ b/sound/soc/codecs/rt5670.c @@ -2835,6 +2835,27 @@ static const struct dmi_system_id dmi_platform_intel_braswell[] = { DMI_MATCH(DMI_PRODUCT_NAME, "Wyse 3040"), }, }, + { + .ident = "Lenovo Thinkpad Tablet 10", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), + DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad 10"), + }, + }, + { + .ident = "Lenovo Thinkpad Tablet 10", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), + DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad Tablet B"), + }, + }, + { + .ident = "Lenovo Thinkpad Tablet 10", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), + DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo Miix 2 10"), + }, + }, {} };
The patch
ASoC: codecs: rt5670: add Thinkpad Tablet 10 quirk
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks, Mark
From 67e03ff3f32ffeb8f425d80627f3054b60bac0b7 Mon Sep 17 00:00:00 2001
From: Nicole Faerber nicole.faerber@id3p.com Date: Mon, 17 Apr 2017 10:04:08 -0500 Subject: [PATCH] ASoC: codecs: rt5670: add Thinkpad Tablet 10 quirk
The Thinkpad Tablet tablet has a similar audio setup as the Intel Braswell platform. A quirk is needed to detect the platform and setup the platform data properly:
Manufacturer: LENOVO Product Name: 20C1CTO1WW Version: ThinkPad 10
Manufacturer: LENOVO Product Name: 20C3001VHH Version: ThinkPad 10
Manufacturer: LENOVO Product Name: 20C10024GE Version: ThinkPad Tablet B
Manufacturer: LENOVO Product Name: 20359 Version: Lenovo Miix 2 10
Signed-off-by: Nicole Faerber nicole.faerber@id3p.com Signed-off-by: Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com Signed-off-by: Mark Brown broonie@kernel.org --- sound/soc/codecs/rt5670.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+)
diff --git a/sound/soc/codecs/rt5670.c b/sound/soc/codecs/rt5670.c index 17d20b99f041..e27c5a4a0a15 100644 --- a/sound/soc/codecs/rt5670.c +++ b/sound/soc/codecs/rt5670.c @@ -2835,6 +2835,27 @@ static const struct dmi_system_id dmi_platform_intel_braswell[] = { DMI_MATCH(DMI_PRODUCT_NAME, "Wyse 3040"), }, }, + { + .ident = "Lenovo Thinkpad Tablet 10", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), + DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad 10"), + }, + }, + { + .ident = "Lenovo Thinkpad Tablet 10", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), + DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad Tablet B"), + }, + }, + { + .ident = "Lenovo Thinkpad Tablet 10", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), + DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo Miix 2 10"), + }, + }, {} };
participants (3)
-
Mark Brown -
Nicolas George -
Pierre-Louis Bossart