[alsa-devel] [PATCH 1/2] ALSA: timer: remove some dead code
We just checked "id.card < 0" on the lines before so we know it's not true here. We can delete that check.
Also checkpatch.pl complains about some extra curly braces so we may as well fix that while we're at it.
Signed-off-by: Dan Carpenter dan.carpenter@oracle.com
diff --git a/sound/core/timer.c b/sound/core/timer.c index 6d4fbc439246..8b9e7943a83b 100644 --- a/sound/core/timer.c +++ b/sound/core/timer.c @@ -1430,18 +1430,13 @@ static int snd_timer_user_next_device(struct snd_timer_id __user *_tid) if (id.card < 0) { id.card = 0; } else { - if (id.card < 0) { - id.card = 0; + if (id.device < 0) { + id.device = 0; } else { - if (id.device < 0) { - id.device = 0; - } else { - if (id.subdevice < 0) { - id.subdevice = 0; - } else { - id.subdevice++; - } - } + if (id.subdevice < 0) + id.subdevice = 0; + else + id.subdevice++; } } list_for_each(p, &snd_timer_list) {
On Fri, 31 Mar 2017 17:21:41 +0200, Dan Carpenter wrote:
We just checked "id.card < 0" on the lines before so we know it's not true here. We can delete that check.
Also checkpatch.pl complains about some extra curly braces so we may as well fix that while we're at it.
Signed-off-by: Dan Carpenter dan.carpenter@oracle.com
Applied, thanks.
Takashi
participants (2)
-
Dan Carpenter
-
Takashi Iwai