On Sat, Jul 12, 2008 at 8:31 AM, Liam Girdwood lg@opensource.wolfsonmicro.com wrote:

On Sat, 2008-07-12 at 00:53 -0600, Grant Likely wrote:

...

On Wed, Jul 02, 2008 at 11:51:17AM +0100, Liam Girdwood wrote:

...

...

Fwiw, I usually separate out the DMA from I2S so it can be used by AC97, PCM interfaces etc. If your hardware only has I2S the it's not required.

Agreed. However, I don't think I have my mind sufficiently wrapped around ASoC yet to split it up without making a royal mess out of it.

Would you be okay with merging it without the split? I know that at least two others people are actively playing with this driver, and it will be easier to collaborate on adding features if it is in mainline.

I've no objections if it's something on your roadmap for the future. I suppose the AC97 parts will only be written (and I2S de-merged) when mpc5200 AC97 hardware is available.

Oh, absolutely. It is definitely something on my roadmap.

Thanks, g.