[alsa-devel] ASoC: omap-mcbsp: Deletion of an unnecessary check before the function call "kfree"
From: Markus Elfring elfring@users.sourceforge.net Date: Mon, 17 Nov 2014 14:05:27 +0100
The kfree() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring elfring@users.sourceforge.net --- sound/soc/omap/mcbsp.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/sound/soc/omap/mcbsp.c b/sound/soc/omap/mcbsp.c index 86c7538..68a1252 100644 --- a/sound/soc/omap/mcbsp.c +++ b/sound/soc/omap/mcbsp.c @@ -621,8 +621,7 @@ void omap_mcbsp_free(struct omap_mcbsp *mcbsp) mcbsp->reg_cache = NULL; spin_unlock(&mcbsp->lock);
- if (reg_cache) - kfree(reg_cache); + kfree(reg_cache); }
/*
On 11/17/2014 03:15 PM, SF Markus Elfring wrote:
From: Markus Elfring elfring@users.sourceforge.net Date: Mon, 17 Nov 2014 14:05:27 +0100
The kfree() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring elfring@users.sourceforge.net
sound/soc/omap/mcbsp.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
Acked-by: Jarkko Nikula jarkko.nikula@bitmer.com
On Mon, Nov 17, 2014 at 02:15:01PM +0100, SF Markus Elfring wrote:
From: Markus Elfring elfring@users.sourceforge.net Date: Mon, 17 Nov 2014 14:05:27 +0100
The kfree() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed.
Applied, thanks.
participants (3)
-
Jarkko Nikula -
Mark Brown -
SF Markus Elfring