[alsa-devel] [PATCH] ASoC: Use SGTL5000_LINREG_VDDD_MASK instead of hardcoded mask value
We have defined SGTL5000_LINREG_VDDD_MASK in sgtl5000.h, use it instead of hardcoded (0x1 << 4) - 1 for the mask.
Signed-off-by: Axel Lin axel.lin@gmail.com --- sound/soc/codecs/sgtl5000.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc/codecs/sgtl5000.c index 8395002..32b5bbd 100644 --- a/sound/soc/codecs/sgtl5000.c +++ b/sound/soc/codecs/sgtl5000.c @@ -754,7 +754,7 @@ static int ldo_regulator_enable(struct regulator_dev *dev)
/* set voltage to register */ snd_soc_update_bits(codec, SGTL5000_CHIP_LINREG_CTRL, - (0x1 << 4) - 1, reg); + SGTL5000_LINREG_VDDD_MASK, reg);
snd_soc_update_bits(codec, SGTL5000_CHIP_ANA_POWER, SGTL5000_LINEREG_D_POWERUP, @@ -780,7 +780,7 @@ static int ldo_regulator_disable(struct regulator_dev *dev)
/* clear voltage info */ snd_soc_update_bits(codec, SGTL5000_CHIP_LINREG_CTRL, - (0x1 << 4) - 1, 0); + SGTL5000_LINREG_VDDD_MASK, 0);
ldo->enabled = 0;
@@ -1115,7 +1115,7 @@ static int sgtl5000_set_power_regs(struct snd_soc_codec *codec)
/* set voltage to register */ snd_soc_update_bits(codec, SGTL5000_CHIP_LINREG_CTRL, - (0x1 << 4) - 1, 0x8); + SGTL5000_LINREG_VDDD_MASK, 0x8);
/* * if vddd linear reg has been enabled,
On Thu, Oct 20, 2011 at 06:49:29PM +0800, Axel Lin wrote:
We have defined SGTL5000_LINREG_VDDD_MASK in sgtl5000.h, use it instead of hardcoded (0x1 << 4) - 1 for the mask.
Signed-off-by: Axel Lin axel.lin@gmail.com
Acked-by: Wolfram Sang w.sang@pengutronix.de
On 20 October 2011 12:02, Wolfram Sang w.sang@pengutronix.de wrote:
On Thu, Oct 20, 2011 at 06:49:29PM +0800, Axel Lin wrote:
We have defined SGTL5000_LINREG_VDDD_MASK in sgtl5000.h, use it instead of hardcoded (0x1 << 4) - 1 for the mask.
Signed-off-by: Axel Lin axel.lin@gmail.com
Acked-by: Wolfram Sang w.sang@pengutronix.de
Acked-by: Liam Girdwood lrg@ti.com
participants (4)
-
Axel Lin -
Girdwood, Liam -
Mark Brown -
Wolfram Sang