Re: [alsa-devel] [PATCH v2] ASoC: dfbmcs320: make the driver common for other BT modules
On Fri, May 17, 2013 at 10:19:37AM +0800, Barry Song wrote:
DFBM-CS320 is only one of bluetooth modules using CSR bluetooth chips, we don't want everyone to have a seperate codec driver. anyway, the feature of Bluetooth handsfree is same on all platforms, so this patch makes the DFBM-CS320 driver become a common BT handsfree driver.
Sorry, should have thought of this before but why are we calling this "handsfree"? It's just a generic bluetooth link as far as the host system is concerned, "bt-sco" might be more appropriate?
Otherwise this looks OK for ASoC though I'd expect to see a change to registration of the OpenMoko BT device (perhaps I missed it though).
2013/5/17 Mark Brown broonie@kernel.org:
On Fri, May 17, 2013 at 10:19:37AM +0800, Barry Song wrote:
DFBM-CS320 is only one of bluetooth modules using CSR bluetooth chips, we don't want everyone to have a seperate codec driver. anyway, the feature of Bluetooth handsfree is same on all platforms, so this patch makes the DFBM-CS320 driver become a common BT handsfree driver.
Sorry, should have thought of this before but why are we calling this "handsfree"? It's just a generic bluetooth link as far as the host system is concerned, "bt-sco" might be more appropriate?
agree. BT SCO should be more suitable.
Otherwise this looks OK for ASoC though I'd expect to see a change to registration of the OpenMoko BT device (perhaps I missed it though).
sorry. i don't understand. i would think OpenMOKO can also use this driver?
-barry
On Sat, May 18, 2013 at 07:03:24PM +0800, Barry Song wrote:
2013/5/17 Mark Brown broonie@kernel.org:
Otherwise this looks OK for ASoC though I'd expect to see a change to registration of the OpenMoko BT device (perhaps I missed it though).
sorry. i don't understand. i would think OpenMOKO can also use this driver?
If you change the names the driver uses to bind you need to also update the users so that they use the new name.
On 05/18/2013 01:25 PM, Mark Brown wrote:
On Sat, May 18, 2013 at 07:03:24PM +0800, Barry Song wrote:
2013/5/17 Mark Brown broonie@kernel.org:
Otherwise this looks OK for ASoC though I'd expect to see a change to registration of the OpenMoko BT device (perhaps I missed it though).
sorry. i don't understand. i would think OpenMOKO can also use this driver?
If you change the names the driver uses to bind you need to also update the users so that they use the new name.
Since there's the platform_device_id table now this should not be necessary.
2013/5/18 Lars-Peter Clausen lars@metafoo.de:
On 05/18/2013 01:25 PM, Mark Brown wrote:
On Sat, May 18, 2013 at 07:03:24PM +0800, Barry Song wrote:
2013/5/17 Mark Brown broonie@kernel.org:
Otherwise this looks OK for ASoC though I'd expect to see a change to registration of the OpenMoko BT device (perhaps I missed it though).
sorry. i don't understand. i would think OpenMOKO can also use this driver?
If you change the names the driver uses to bind you need to also update the users so that they use the new name.
Since there's the platform_device_id table now this should not be necessary.
i guess Mark meaned i missed to change "select SND_SOC_DFBMCS320"?
config SND_SOC_SAMSUNG_NEO1973_WM8753 tristate "Audio support for Openmoko Neo1973 Smartphones (GTA02)" depends on SND_SOC_SAMSUNG && MACH_NEO1973_GTA02 select SND_S3C24XX_I2S select SND_SOC_WM8753 select SND_SOC_DFBMCS320 help Say Y here to enable audio support for the Openmoko Neo1973 Smartphones.
-barry
participants (3)
-
Barry Song -
Lars-Peter Clausen -
Mark Brown