[alsa-devel] [PATCH] ASoC: rt5645: move RT5650 muxes to rt5650_specific_dapm_widgets
Developing a driver for an Asus X205TA laptop I get these dmesg errors:
rt5645 i2c-10EC5648:00: ASoC: mux RT5650 IF1 ADC1 Swap Mux has no paths rt5645 i2c-10EC5648:00: ASoC: mux RT5650 IF1 ADC2 Swap Mux has no paths rt5645 i2c-10EC5648:00: ASoC: mux RT5650 IF1 ADC3 Swap Mux has no paths rt5645 i2c-10EC5648:00: ASoC: mux RT5650 IF1 ADC Mux has no paths rt5645 i2c-10EC5648:00: ASoC: mux RT5650 IF1 DAC1 L Mux has no paths rt5645 i2c-10EC5648:00: ASoC: mux RT5650 IF1 DAC1 R Mux has no paths rt5645 i2c-10EC5648:00: ASoC: mux RT5650 IF1 DAC2 L Mux has no paths rt5645 i2c-10EC5648:00: ASoC: mux RT5650 IF1 DAC2 R Mux has no paths
so, move these muxes to the rt5650_specific_dapm_widgets[] list.
Signed-off-by: Michele Curti michele.curti@gmail.com Signed-off-by: Oder Chiou oder_chiou@realtek.com --- sound/soc/codecs/rt5645.c | 35 ++++++++++++++++++----------------- 1 file changed, 18 insertions(+), 17 deletions(-)
diff --git a/sound/soc/codecs/rt5645.c b/sound/soc/codecs/rt5645.c index 4344043..9ce311e 100644 --- a/sound/soc/codecs/rt5645.c +++ b/sound/soc/codecs/rt5645.c @@ -1706,15 +1706,6 @@ static const struct snd_soc_dapm_widget rt5645_dapm_widgets[] = { SND_SOC_DAPM_MUX("RT5645 IF1 ADC Mux", SND_SOC_NOPM, 0, 0, &rt5645_if1_adc_in_mux),
- SND_SOC_DAPM_MUX("RT5650 IF1 ADC1 Swap Mux", SND_SOC_NOPM, - 0, 0, &rt5650_if1_adc1_in_mux), - SND_SOC_DAPM_MUX("RT5650 IF1 ADC2 Swap Mux", SND_SOC_NOPM, - 0, 0, &rt5650_if1_adc2_in_mux), - SND_SOC_DAPM_MUX("RT5650 IF1 ADC3 Swap Mux", SND_SOC_NOPM, - 0, 0, &rt5650_if1_adc3_in_mux), - SND_SOC_DAPM_MUX("RT5650 IF1 ADC Mux", SND_SOC_NOPM, - 0, 0, &rt5650_if1_adc_in_mux), - SND_SOC_DAPM_MUX("IF2 ADC Mux", SND_SOC_NOPM, 0, 0, &rt5645_if2_adc_in_mux),
@@ -1733,14 +1724,6 @@ static const struct snd_soc_dapm_widget rt5645_dapm_widgets[] = { &rt5645_if1_dac2_tdm_sel_mux), SND_SOC_DAPM_MUX("RT5645 IF1 DAC2 R Mux", SND_SOC_NOPM, 0, 0, &rt5645_if1_dac3_tdm_sel_mux), - SND_SOC_DAPM_MUX("RT5650 IF1 DAC1 L Mux", SND_SOC_NOPM, 0, 0, - &rt5650_if1_dac0_tdm_sel_mux), - SND_SOC_DAPM_MUX("RT5650 IF1 DAC1 R Mux", SND_SOC_NOPM, 0, 0, - &rt5650_if1_dac1_tdm_sel_mux), - SND_SOC_DAPM_MUX("RT5650 IF1 DAC2 L Mux", SND_SOC_NOPM, 0, 0, - &rt5650_if1_dac2_tdm_sel_mux), - SND_SOC_DAPM_MUX("RT5650 IF1 DAC2 R Mux", SND_SOC_NOPM, 0, 0, - &rt5650_if1_dac3_tdm_sel_mux), SND_SOC_DAPM_PGA("IF1 ADC", SND_SOC_NOPM, 0, 0, NULL, 0), SND_SOC_DAPM_PGA("IF1 ADC L", SND_SOC_NOPM, 0, 0, NULL, 0), SND_SOC_DAPM_PGA("IF1 ADC R", SND_SOC_NOPM, 0, 0, NULL, 0), @@ -1882,6 +1865,24 @@ static const struct snd_soc_dapm_widget rt5650_specific_dapm_widgets[] = { 0, 0, &rt5650_a_dac2_l_mux), SND_SOC_DAPM_MUX("A DAC2 R Mux", SND_SOC_NOPM, 0, 0, &rt5650_a_dac2_r_mux), + + SND_SOC_DAPM_MUX("RT5650 IF1 ADC1 Swap Mux", SND_SOC_NOPM, + 0, 0, &rt5650_if1_adc1_in_mux), + SND_SOC_DAPM_MUX("RT5650 IF1 ADC2 Swap Mux", SND_SOC_NOPM, + 0, 0, &rt5650_if1_adc2_in_mux), + SND_SOC_DAPM_MUX("RT5650 IF1 ADC3 Swap Mux", SND_SOC_NOPM, + 0, 0, &rt5650_if1_adc3_in_mux), + SND_SOC_DAPM_MUX("RT5650 IF1 ADC Mux", SND_SOC_NOPM, + 0, 0, &rt5650_if1_adc_in_mux), + + SND_SOC_DAPM_MUX("RT5650 IF1 DAC1 L Mux", SND_SOC_NOPM, 0, 0, + &rt5650_if1_dac0_tdm_sel_mux), + SND_SOC_DAPM_MUX("RT5650 IF1 DAC1 R Mux", SND_SOC_NOPM, 0, 0, + &rt5650_if1_dac1_tdm_sel_mux), + SND_SOC_DAPM_MUX("RT5650 IF1 DAC2 L Mux", SND_SOC_NOPM, 0, 0, + &rt5650_if1_dac2_tdm_sel_mux), + SND_SOC_DAPM_MUX("RT5650 IF1 DAC2 R Mux", SND_SOC_NOPM, 0, 0, + &rt5650_if1_dac3_tdm_sel_mux), };
static const struct snd_soc_dapm_route rt5645_dapm_routes[] = {
On Mon, Jun 15, 2015 at 10:44:11AM +0800, Oder Chiou wrote:
Developing a driver for an Asus X205TA laptop I get these dmesg errors:
Signed-off-by: Michele Curti michele.curti@gmail.com Signed-off-by: Oder Chiou oder_chiou@realtek.com
Did Michele write this patch or did you? It doesn't matter so much when all the signoffs come from within the same company but given that Michele has a gmail rather than Realtek address the licensing parts of the signoff start to matter.
-----Original Message----- From: Mark Brown [mailto:broonie@kernel.org] Sent: Monday, June 15, 2015 6:04 PM To: Oder Chiou Cc: lgirdwood@gmail.com; alsa-devel@alsa-project.org; Flove; Bard Liao; John Lin; Michele Curti Subject: Re: [PATCH] ASoC: rt5645: move RT5650 muxes to rt5650_specific_dapm_widgets
On Mon, Jun 15, 2015 at 10:44:11AM +0800, Oder Chiou wrote:
Developing a driver for an Asus X205TA laptop I get these dmesg errors:
Signed-off-by: Michele Curti michele.curti@gmail.com Signed-off-by: Oder Chiou oder_chiou@realtek.com
Did Michele write this patch or did you? It doesn't matter so much when all the signoffs come from within the same company but given that Michele has a gmail rather than Realtek address the licensing parts of the signoff start to matter.
The patch was written by Michele. She sent the patch to us and alsa-devel@alsa-project.org, but the mail address was not included you. So we forwarded the patch, thanks.
On Mon, Jun 15, 2015 at 10:29:56AM +0000, Oder Chiou wrote:
-----Original Message----- From: Mark Brown [mailto:broonie@kernel.org] Sent: Monday, June 15, 2015 6:04 PM To: Oder Chiou Cc: lgirdwood@gmail.com; alsa-devel@alsa-project.org; Flove; Bard Liao; John Lin; Michele Curti Subject: Re: [PATCH] ASoC: rt5645: move RT5650 muxes to rt5650_specific_dapm_widgets
On Mon, Jun 15, 2015 at 10:44:11AM +0800, Oder Chiou wrote:
Developing a driver for an Asus X205TA laptop I get these dmesg errors:
Signed-off-by: Michele Curti michele.curti@gmail.com Signed-off-by: Oder Chiou oder_chiou@realtek.com
Did Michele write this patch or did you? It doesn't matter so much when all the signoffs come from within the same company but given that Michele has a gmail rather than Realtek address the licensing parts of the signoff start to matter.
The patch was written by Michele. She sent the patch to us and alsa-devel@alsa-project.org, but the mail address was not included you. So we forwarded the patch, thanks.
Oh.. Yep, sorry. I only added the maintainers and not the supporters.
Thanks, Michele
On Mon, Jun 15, 2015 at 10:29:56AM +0000, Oder Chiou wrote:
Did Michele write this patch or did you? It doesn't matter so much when all the signoffs come from within the same company but given that Michele has a gmail rather than Realtek address the licensing parts of the signoff start to matter.
The patch was written by Michele. She sent the patch to us and alsa-devel@alsa-project.org, but the mail address was not included you. So we forwarded the patch, thanks.
If you are forwarding on a patch that someone else wrote it is *very* important that you preserve their authorship, sending a From: line as part of the patch (as covered in SubmittingPatches).
participants (3)
-
Mark Brown -
Michele Curti -
Oder Chiou