At Wed, 17 Sep 2014 03:17:08 +0000 (GMT), Renu Tyagi wrote:

Hi Takashi, File in which changes are being made : rawmidi.c Bug type - Handle h to be closed in case of error before returning PFA patch.

By some reason, your post doesn't appear on alsa-devel ML. Did you subscribe the ML? If not, please subscribe and repost. Also, what about other patches you made?

Last but not least: please prepare a patch to be applicable via git-am, including subject and from tags and the changelog content, and don't forget your sign-off to the patch, just like a patch to Linux kernel.

thanks,

Takashi

Community Code: if (err >= 0) err = open_func(inputp, outputp, name, rawmidi_root, rawmidi_conf, mode); if (err < 0) return err; if (inputp) { (*inputp)->dl_handle = h; h = NULL;

Recommended Code : if (err >= 0) err = open_func(inputp, outputp, name, rawmidi_root, rawmidi_conf, mode); if (err < 0){ if (h) snd_dlclose(h); return err; } if (inputp) { (*inputp)->dl_handle = h; h = NULL;

Thanks & Regards, Renu Tyagi [2 22578.patch <application/octet-stream (base64)>]