[alsa-devel] [PATCH 24/45] hdspm.h: include stdint.h in userspace
Fixes compilation error:
sound/hdspm.h:43:2: error: unknown type name ‘uint32_t’
Signed-off-by: Mikko Rapeli mikko.rapeli@iki.fi --- include/uapi/sound/hdspm.h | 6 ++++++ 1 file changed, 6 insertions(+)
diff --git a/include/uapi/sound/hdspm.h b/include/uapi/sound/hdspm.h index d956c35..f799828 100644 --- a/include/uapi/sound/hdspm.h +++ b/include/uapi/sound/hdspm.h @@ -20,6 +20,12 @@ * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. */
+#ifdef __KERNEL__ +#include <linux/types.h> +#else +#include <stdint.h> +#endif + /* Maximum channels is 64 even on 56Mode you have 64playbacks to matrix */ #define HDSPM_MAX_CHANNELS 64
At Tue, 17 Feb 2015 00:05:27 +0100, Mikko Rapeli wrote:
Fixes compilation error:
sound/hdspm.h:43:2: error: unknown type name ‘uint32_t’
Signed-off-by: Mikko Rapeli mikko.rapeli@iki.fi
Applied for 3.21, thanks.
Takashi
include/uapi/sound/hdspm.h | 6 ++++++ 1 file changed, 6 insertions(+)
diff --git a/include/uapi/sound/hdspm.h b/include/uapi/sound/hdspm.h index d956c35..f799828 100644 --- a/include/uapi/sound/hdspm.h +++ b/include/uapi/sound/hdspm.h @@ -20,6 +20,12 @@
- Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
*/
+#ifdef __KERNEL__ +#include <linux/types.h> +#else +#include <stdint.h> +#endif
/* Maximum channels is 64 even on 56Mode you have 64playbacks to matrix */ #define HDSPM_MAX_CHANNELS 64
-- 2.1.4
On Tue, Feb 17, 2015 at 07:46:02AM +0100, Takashi Iwai wrote:
At Tue, 17 Feb 2015 00:05:27 +0100, Mikko Rapeli wrote:
Fixes compilation error:
sound/hdspm.h:43:2: error: unknown type name ‘uint32_t’
Signed-off-by: Mikko Rapeli mikko.rapeli@iki.fi
Applied for 3.21, thanks.
Sorry, but this should maybe be dropped or reverted from the sound tree.
Arnd and others pointed out that kernel headers should be using __u32 etc types from linux/types.h instead of including stdint.h from libc and using uint32_t et al.
I'll post a new patch version for hdspm.h too in the next revision.
-Mikko
Takashi
include/uapi/sound/hdspm.h | 6 ++++++ 1 file changed, 6 insertions(+)
diff --git a/include/uapi/sound/hdspm.h b/include/uapi/sound/hdspm.h index d956c35..f799828 100644 --- a/include/uapi/sound/hdspm.h +++ b/include/uapi/sound/hdspm.h @@ -20,6 +20,12 @@
- Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
*/
+#ifdef __KERNEL__ +#include <linux/types.h> +#else +#include <stdint.h> +#endif
/* Maximum channels is 64 even on 56Mode you have 64playbacks to matrix */ #define HDSPM_MAX_CHANNELS 64
-- 2.1.4
At Wed, 11 Mar 2015 02:28:12 +0200, Mikko Rapeli wrote:
On Tue, Feb 17, 2015 at 07:46:02AM +0100, Takashi Iwai wrote:
At Tue, 17 Feb 2015 00:05:27 +0100, Mikko Rapeli wrote:
Fixes compilation error:
sound/hdspm.h:43:2: error: unknown type name ‘uint32_t’
Signed-off-by: Mikko Rapeli mikko.rapeli@iki.fi
Applied for 3.21, thanks.
Sorry, but this should maybe be dropped or reverted from the sound tree.
Arnd and others pointed out that kernel headers should be using __u32 etc types from linux/types.h instead of including stdint.h from libc and using uint32_t et al.
I'll post a new patch version for hdspm.h too in the next revision.
Then please post an incremental patch to for-next branch of sound git tree (or the current linux-next tree).
Takashi
participants (2)
-
Mikko Rapeli -
Takashi Iwai