[alsa-devel] [asoc:for-next 462/535] sound/soc/codecs/da7219.c:1777:22: sparse: symbol 'da7219_dai_clks_ops' was not declared. Should it be static?
tree: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next head: 27f6213507962a2c754d7dff7c25515e09e31752 commit: fc8f7ea2d6c074baaad202c9187962bfa493ef13 [462/535] ASoC: da7219: Add common clock usage for providing DAI clks reproduce: # apt-get install sparse git checkout fc8f7ea2d6c074baaad202c9187962bfa493ef13 make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__
sparse warnings: (new ones prefixed by >>)
sound/soc/codecs/da7219.c:440:44: sparse: cast to restricted __le16 sound/soc/codecs/da7219.c:461:13: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [unsigned] [usertype] val @@ got short [unsigned] [usertype] val @@ sound/soc/codecs/da7219.c:461:13: expected unsigned short [unsigned] [usertype] val sound/soc/codecs/da7219.c:461:13: got restricted __le16 [usertype] <noident> sound/soc/codecs/da7219.c:817:57: sparse: dubious: x & !y sound/soc/codecs/da7219.c:1427:16: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [unsigned] [usertype] offset @@ got short [unsigned] [usertype] offset @@ sound/soc/codecs/da7219.c:1427:16: expected unsigned short [unsigned] [usertype] offset sound/soc/codecs/da7219.c:1427:16: got restricted __le16 [usertype] <noident>
sound/soc/codecs/da7219.c:1777:22: sparse: symbol 'da7219_dai_clks_ops' was not declared. Should it be static?
Please review and possibly fold the followup patch.
--- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Fixes: fc8f7ea2d6c0 ("ASoC: da7219: Add common clock usage for providing DAI clks") Signed-off-by: Fengguang Wu fengguang.wu@intel.com --- da7219.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/da7219.c b/sound/soc/codecs/da7219.c index 4412159..7e2eabd 100644 --- a/sound/soc/codecs/da7219.c +++ b/sound/soc/codecs/da7219.c @@ -1774,7 +1774,7 @@ static int da7219_dai_clks_is_prepared(struct clk_hw *hw) return !!(clk_reg & DA7219_DAI_CLK_EN_MASK); }
-const struct clk_ops da7219_dai_clks_ops = { +static const struct clk_ops da7219_dai_clks_ops = { .prepare = da7219_dai_clks_prepare, .unprepare = da7219_dai_clks_unprepare, .is_prepared = da7219_dai_clks_is_prepared,
The patch
ASoC: da7219: make structure da7219_dai_clks_ops static
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks, Mark
From 1d37ce929c71f430389db3042a8b23536cede1e5 Mon Sep 17 00:00:00 2001
From: Colin Ian King colin.king@canonical.com Date: Wed, 14 Mar 2018 14:28:25 +0000 Subject: [PATCH] ASoC: da7219: make structure da7219_dai_clks_ops static
structure da7219_dai_clks_ops is local to the source and does not need to be in global scope, so make it static.
Cleans up sparse warning: sound/soc/codecs/da7219.c:1777:22: warning: symbol 'da7219_dai_clks_ops' was not declared. Should it be static?
Signed-off-by: Colin Ian King colin.king@canonical.com Signed-off-by: Mark Brown broonie@kernel.org --- sound/soc/codecs/da7219.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/da7219.c b/sound/soc/codecs/da7219.c index 08f55d7a11ba..980a6a8bf56d 100644 --- a/sound/soc/codecs/da7219.c +++ b/sound/soc/codecs/da7219.c @@ -1774,7 +1774,7 @@ static int da7219_dai_clks_is_prepared(struct clk_hw *hw) return !!(clk_reg & DA7219_DAI_CLK_EN_MASK); }
-const struct clk_ops da7219_dai_clks_ops = { +static const struct clk_ops da7219_dai_clks_ops = { .prepare = da7219_dai_clks_prepare, .unprepare = da7219_dai_clks_unprepare, .is_prepared = da7219_dai_clks_is_prepared,
participants (2)
-
kbuild test robot -
Mark Brown