[alsa-devel] ASoc : cs42xx8 : merge cs42xx8-i2c.c into cs42xx8.c
Do you think it would be a good idea to merge cs42xx8-i2c.c into cs42xx8.c ?
Is there a reason to keep these two related driver functions separate ?
Here is their source code :
https://github.com/torvalds/linux/blob/master/sound/soc/codecs/cs42xx8-i2c.c
https://github.com/torvalds/linux/blob/master/sound/soc/codecs/cs42xx8.c
Matt
Hi Matt,
On Thu, 2019-05-16 at 16:15 +1000, Matt Flax wrote:
Do you think it would be a good idea to merge cs42xx8-i2c.c into cs42xx8.c ?
I think it is fine to keep this separate. The i2c code is clean and easy to understand.
Is there a reason to keep these two related driver functions separate ?
cs42xxx codec has also an SPI interface. If anyone wants to implement support for that it would be easier with the current split.
thanks, Daniel.
On Thu, May 16, 2019 at 06:34:47AM +0000, Daniel Baluta wrote:
On Thu, 2019-05-16 at 16:15 +1000, Matt Flax wrote:
Is there a reason to keep these two related driver functions separate ?
cs42xxx codec has also an SPI interface. If anyone wants to implement support for that it would be easier with the current split.
Right, that's the reason for the split - the split would need to be redone if anyone wants to add SPI support.
On 16/5/19 7:52 pm, Mark Brown wrote:
On Thu, May 16, 2019 at 06:34:47AM +0000, Daniel Baluta wrote:
On Thu, 2019-05-16 at 16:15 +1000, Matt Flax wrote:
Is there a reason to keep these two related driver functions separate ?
cs42xxx codec has also an SPI interface. If anyone wants to implement support for that it would be easier with the current split.
Right, that's the reason for the split - the split would need to be redone if anyone wants to add SPI support.
OK, make sense.
participants (3)
-
Daniel Baluta -
Mark Brown -
Matt Flax