[alsa-devel] [PATCH] ASoC: rt5645: disable soft volume control
With soft volume control function, rt5645/rt5650 will start with 0dB volume and take a little time to adjust volume to given value. And it will cause a bad user experience. This patch disable it.
Signed-off-by: Bard Liao bardliao@realtek.com --- sound/soc/codecs/rt5645.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/sound/soc/codecs/rt5645.c b/sound/soc/codecs/rt5645.c index 97bf96e..c969f48 100644 --- a/sound/soc/codecs/rt5645.c +++ b/sound/soc/codecs/rt5645.c @@ -63,6 +63,7 @@ static const struct reg_sequence init_list[] = { {RT5645_PR_BASE + 0x20, 0x611f}, {RT5645_PR_BASE + 0x21, 0x4040}, {RT5645_PR_BASE + 0x23, 0x0004}, + {RT5645_PR_BASE + 0x00, 0x0a2a}, {RT5645_ASRC_4, 0x0120}, };
On Tue, Jul 05, 2016 at 01:23:55PM +0800, Bard Liao wrote:
With soft volume control function, rt5645/rt5650 will start with 0dB volume and take a little time to adjust volume to given value. And it will cause a bad user experience. This patch disable it.
This seems like something that it'd be better to give users control over - some users will be annoyed by a soft ramp but there will be others who welcome it.
-----Original Message----- From: Mark Brown [mailto:broonie@kernel.org] Sent: Tuesday, July 05, 2016 4:34 PM To: Bard Liao Cc: lgirdwood@gmail.com; alsa-devel@alsa-project.org; lars@metafoo.de; Flove; Oder Chiou; Jack Yu; koro.chen@mediatek.com; PC.Liao@mediatek.com Subject: Re: [PATCH] ASoC: rt5645: disable soft volume control
On Tue, Jul 05, 2016 at 01:23:55PM +0800, Bard Liao wrote:
With soft volume control function, rt5645/rt5650 will start with 0dB volume and take a little time to adjust volume to given value. And it will cause a bad user experience. This patch disable it.
This seems like something that it'd be better to give users control over
- some users will be annoyed by a soft ramp but there will be others who
welcome it.
Good idea. I will do it.
------Please consider the environment before printing this e-mail.
participants (2)
-
Bard Liao -
Mark Brown