[alsa-devel] [PATCH v2] ALSA: usb-audio: Change structure initialisation to C99 style
To allow for structure randomisation, replace the in order struct initialisation style with explicit field style.
The Coccinelle semantic patch used to make this change is as follows:
@decl@ identifier i1,fld; type T; field list[n] fs; @@
struct i1 { fs T fld; ...};
@@ identifier decl.i1,i2,decl.fld; expression e; position bad.p, bad.fix; @@
struct i1 i2@p = { ..., + .fld = e - e@fix ,...};
Signed-off-by: Amitoj Kaur Chawla amitoj1606@gmail.com --- Changes in v2: -Modified commit message
sound/usb/mixer_maps.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/sound/usb/mixer_maps.c b/sound/usb/mixer_maps.c index 1f8fb0d9..9038b2e 100644 --- a/sound/usb/mixer_maps.c +++ b/sound/usb/mixer_maps.c @@ -107,8 +107,10 @@ static struct usbmix_name_map extigy_map[] = { * e.g. no Master and fake PCM volume * Pavel Mihaylov bin@bash.info */ -static struct usbmix_dB_map mp3plus_dB_1 = {-4781, 0}; /* just guess */ -static struct usbmix_dB_map mp3plus_dB_2 = {-1781, 618}; /* just guess */ +static struct usbmix_dB_map mp3plus_dB_1 = {.min = -4781, .max = 0}; + /* just guess */ +static struct usbmix_dB_map mp3plus_dB_2 = {.min = -1781, .max = 618}; + /* just guess */
static struct usbmix_name_map mp3plus_map[] = { /* 1: IT pcm */
On Fri, 17 Jun 2016 16:42:15 +0200, Amitoj Kaur Chawla wrote:
To allow for structure randomisation, replace the in order struct initialisation style with explicit field style.
The Coccinelle semantic patch used to make this change is as follows:
@decl@ identifier i1,fld; type T; field list[n] fs; @@
struct i1 { fs T fld; ...};
@@ identifier decl.i1,i2,decl.fld; expression e; position bad.p, bad.fix; @@
struct i1 i2@p = { ...,
- .fld = e
- e@fix
,...};
Signed-off-by: Amitoj Kaur Chawla amitoj1606@gmail.com
Changes in v2: -Modified commit message
Applied, thanks.
Takashi
participants (2)
-
Amitoj Kaur Chawla
-
Takashi Iwai