Re: [alsa-devel] [PATCH 2/2] pxa: modify the pxa2xx-ac97 file for pxa168
2010/6/8 Wan ZongShun mcuos.com@gmail.com:
In order to allow the sharing of the pxa2xx-ac97 driver file with pxa168, we have to do a little change to pxa2xx-ac97 file.
All private register addresses were located in mach/include/ac97.h.
This is not the right way to go, as suggested already. I hope the ac97 driver is more self-contained. i.e. having a platform device for:
- where the registers are mapped from - drcmr channel numbers can be encoded within dma resource - ac97 register definitions are not exposed everywhere
2010/6/8 Eric Miao eric.y.miao@gmail.com:
2010/6/8 Wan ZongShun mcuos.com@gmail.com:
In order to allow the sharing of the pxa2xx-ac97 driver file with pxa168, we have to do a little change to pxa2xx-ac97 file.
All private register addresses were located in mach/include/ac97.h.
This is not the right way to go, as suggested already. I hope the ac97 driver is more self-contained. i.e. having a platform device for:
- where the registers are mapped from - drcmr channel numbers can be encoded within dma resource - ac97 register definitions are not exposed everywhere
Got it, so I should put above to platform_device and remove regs-ac97.h, any private bit definition should be removed to driver directory as driver _only_.
On Tue, 2010-06-08 at 22:49 +0800, Wan ZongShun wrote:
2010/6/8 Eric Miao eric.y.miao@gmail.com:
2010/6/8 Wan ZongShun mcuos.com@gmail.com:
In order to allow the sharing of the pxa2xx-ac97 driver file with pxa168, we have to do a little change to pxa2xx-ac97 file.
All private register addresses were located in mach/include/ac97.h.
This is not the right way to go, as suggested already. I hope the ac97 driver is more self-contained. i.e. having a platform device for:
- where the registers are mapped from
- drcmr channel numbers can be encoded within dma resource
- ac97 register definitions are not exposed everywhere
Got it, so I should put above to platform_device and remove regs-ac97.h, any private bit definition should be removed to driver directory as driver _only_.
...and could you also CC Mark on any ASoC related changes too.
Thanks
Liam
participants (3)
-
Eric Miao -
Liam Girdwood -
Wan ZongShun