[alsa-devel] [PATCH] pcm.h: include sys/types.h, necessary for u_int_XX types
fixes compilation on musl libc. --- include/pcm.h | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/include/pcm.h b/include/pcm.h index 95b8aed..7ea9e84 100644 --- a/include/pcm.h +++ b/include/pcm.h @@ -29,6 +29,8 @@ #ifndef __ALSA_PCM_H #define __ALSA_PCM_H
+#include <sys/types.h> + #ifdef __cplusplus extern "C" { #endif
oops, forgot Signed-off-by, resending...
On 10/10/2013 03:17 PM, John Spencer wrote:
fixes compilation on musl libc.
include/pcm.h | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/include/pcm.h b/include/pcm.h index 95b8aed..7ea9e84 100644 --- a/include/pcm.h +++ b/include/pcm.h @@ -29,6 +29,8 @@ #ifndef __ALSA_PCM_H #define __ALSA_PCM_H
+#include<sys/types.h>
- #ifdef __cplusplus extern "C" { #endif
At Thu, 10 Oct 2013 15:17:40 +0200, John Spencer wrote:
fixes compilation on musl libc.
But sys/types.h is already included in asoundlib.h...
Takashi
include/pcm.h | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/include/pcm.h b/include/pcm.h index 95b8aed..7ea9e84 100644 --- a/include/pcm.h +++ b/include/pcm.h @@ -29,6 +29,8 @@ #ifndef __ALSA_PCM_H #define __ALSA_PCM_H
+#include <sys/types.h>
#ifdef __cplusplus extern "C" {
#endif
1.7.3.4
Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
On 10/10/2013 03:35 PM, Takashi Iwai wrote:
At Thu, 10 Oct 2013 15:17:40 +0200, John Spencer wrote:
fixes compilation on musl libc.
But sys/types.h is already included in asoundlib.h...
maybe, but right now this header is not usable standalone as-is, and something during build includes it without including asoundlib.h:
In file included from ../../include/local.h:141:0, from control_local.h:22, from hcontrol.c:51: ../../include/pcm.h:1051:1: error: unknown type name 'u_int8_t'
full build log attached.
--JS
Takashi
include/pcm.h | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/include/pcm.h b/include/pcm.h index 95b8aed..7ea9e84 100644 --- a/include/pcm.h +++ b/include/pcm.h @@ -29,6 +29,8 @@ #ifndef __ALSA_PCM_H #define __ALSA_PCM_H
+#include<sys/types.h>
- #ifdef __cplusplus extern "C" { #endif
-- 1.7.3.4
Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
At Thu, 10 Oct 2013 15:36:11 +0200, John Spencer wrote:
On 10/10/2013 03:35 PM, Takashi Iwai wrote:
At Thu, 10 Oct 2013 15:17:40 +0200, John Spencer wrote:
fixes compilation on musl libc.
But sys/types.h is already included in asoundlib.h...
maybe, but right now this header is not usable standalone as-is, and something during build includes it without including asoundlib.h:
In file included from ../../include/local.h:141:0, from control_local.h:22, from hcontrol.c:51: ../../include/pcm.h:1051:1: error: unknown type name 'u_int8_t'
full build log attached.
In that case, better to fix include/local.h, add sys/types.h there.
Takashi
participants (2)
-
John Spencer -
Takashi Iwai