[alsa-devel] [PATCH 1/2] ASoC: cs42l52: Reorder Min/Max and update to SX_TLV for Beep Volume
Beep Volume Min/Max was backwards. Change to SOC_SONGLE_SX_TLV for correct volume representation
Signed-off-by: Brian Austin brian.austin@cirrus.com --- sound/soc/codecs/cs42l52.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/cs42l52.c b/sound/soc/codecs/cs42l52.c index 987f728..ee25f32 100644 --- a/sound/soc/codecs/cs42l52.c +++ b/sound/soc/codecs/cs42l52.c @@ -451,7 +451,7 @@ static const struct snd_kcontrol_new cs42l52_snd_controls[] = { SOC_ENUM("Beep Pitch", beep_pitch_enum), SOC_ENUM("Beep on Time", beep_ontime_enum), SOC_ENUM("Beep off Time", beep_offtime_enum), - SOC_SINGLE_TLV("Beep Volume", CS42L52_BEEP_VOL, 0, 0x1f, 0x07, hl_tlv), + SOC_SINGLE_SX_TLV("Beep Volume", CS42L52_BEEP_VOL, 0, 0x07, 0x1f, hl_tlv), SOC_SINGLE("Beep Mixer Switch", CS42L52_BEEP_TONE_CTL, 5, 1, 1), SOC_ENUM("Beep Treble Corner Freq", beep_treble_enum), SOC_ENUM("Beep Bass Corner Freq", beep_bass_enum),
On Mon, Aug 05, 2013 at 03:08:47PM -0500, Brian Austin wrote:
Beep Volume Min/Max was backwards. Change to SOC_SONGLE_SX_TLV for correct volume representation
This doesn't apply against v3.11-rc4 - can you check what's going on there please? I don't see any obvious issues by eye which is worrying...
On Mon, 5 Aug 2013, Mark Brown wrote:
On Mon, Aug 05, 2013 at 03:08:47PM -0500, Brian Austin wrote:
Beep Volume Min/Max was backwards. Change to SOC_SONGLE_SX_TLV for correct volume representation
This doesn't apply against v3.11-rc4 - can you check what's going on there please? I don't see any obvious issues by eye which is worrying...
huh, I just did a fresh pull of for-next and applied and it did fine... It is SINGLE instead of SONGLE though :) But that wasn't the patch itself
On 08/05/2013 10:31 PM, Brian Austin wrote:
On Mon, 5 Aug 2013, Mark Brown wrote:
On Mon, Aug 05, 2013 at 03:08:47PM -0500, Brian Austin wrote:
Beep Volume Min/Max was backwards. Change to SOC_SONGLE_SX_TLV for correct volume representation
This doesn't apply against v3.11-rc4 - can you check what's going on there please? I don't see any obvious issues by eye which is worrying...
huh, I just did a fresh pull of for-next and applied and it did fine... It is SINGLE instead of SONGLE though :) But that wasn't the patch itself
Looks like your mail client replaced the tabs in the patch with spaces.
- Lars
On Aug 5, 2013, at 15:34, "Lars-Peter Clausen" lars@metafoo.de wrote:
On 08/05/2013 10:31 PM, Brian Austin wrote:
On Mon, 5 Aug 2013, Mark Brown wrote:
On Mon, Aug 05, 2013 at 03:08:47PM -0500, Brian Austin wrote:
Beep Volume Min/Max was backwards. Change to SOC_SONGLE_SX_TLV for correct volume representation
This doesn't apply against v3.11-rc4 - can you check what's going on there please? I don't see any obvious issues by eye which is worrying...
huh, I just did a fresh pull of for-next and applied and it did fine... It is SINGLE instead of SONGLE though :) But that wasn't the patch itself
Looks like your mail client replaced the tabs in the patch with spaces.
- Lars
Ok, so I guess FWD from pine won't work. Good grief. I'll have to fix my git mailer tomorrow.
Sorry for the delay
participants (4)
-
Austin, Brian -
Brian Austin
-
Lars-Peter Clausen -
Mark Brown