[alsa-devel] [PATCH] pcm_plug: fix comparison always true
Signed-off-by: Anssi Hannula anssi.hannula@iki.fi --- Fixes an obvious mistake which I noticed while reading the code. Untested.
src/pcm/pcm_plug.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/pcm/pcm_plug.c b/src/pcm/pcm_plug.c index 967cf46..e9d2923 100644 --- a/src/pcm/pcm_plug.c +++ b/src/pcm/pcm_plug.c @@ -485,7 +485,7 @@ static int snd_pcm_plug_change_format(snd_pcm_t *pcm, snd_pcm_t **new, snd_pcm_p /* No conversion is needed */ if (clt->format == slv->format && clt->rate == slv->rate && - clt->channels == clt->channels) + clt->channels == slv->channels) return 0;
if (snd_pcm_format_linear(slv->format)) {
At Mon, 2 Aug 2010 18:50:08 +0300, Anssi Hannula wrote:
Signed-off-by: Anssi Hannula anssi.hannula@iki.fi
Fixes an obvious mistake which I noticed while reading the code. Untested.
Looks obvious, yeah. Applied now.
thanks,
Takashi
src/pcm/pcm_plug.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/pcm/pcm_plug.c b/src/pcm/pcm_plug.c index 967cf46..e9d2923 100644 --- a/src/pcm/pcm_plug.c +++ b/src/pcm/pcm_plug.c @@ -485,7 +485,7 @@ static int snd_pcm_plug_change_format(snd_pcm_t *pcm, snd_pcm_t **new, snd_pcm_p /* No conversion is needed */ if (clt->format == slv->format && clt->rate == slv->rate &&
clt->channels == clt->channels)
clt->channels == slv->channels)return 0;
if (snd_pcm_format_linear(slv->format)) {
-- 1.7.2
Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
participants (2)
-
Anssi Hannula -
Takashi Iwai