[PATCH] ASoC: codecs/jz4770: Remove superfluous error message
The function devm_platform_ioremap_resource has already contained error message if failed, so remove superfluous dev_err here.
Signed-off-by: Zhang Shengju zhangshengju@cmss.chinamobile.com Signed-off-by: Tang Bin tangbin@cmss.chinamobile.com --- sound/soc/codecs/jz4770.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/sound/soc/codecs/jz4770.c b/sound/soc/codecs/jz4770.c index 298689a07..5a24471a5 100644 --- a/sound/soc/codecs/jz4770.c +++ b/sound/soc/codecs/jz4770.c @@ -900,11 +900,8 @@ static int jz4770_codec_probe(struct platform_device *pdev) codec->dev = dev;
codec->base = devm_platform_ioremap_resource(pdev, 0); - if (IS_ERR(codec->base)) { - ret = PTR_ERR(codec->base); - dev_err(dev, "Failed to ioremap mmio memory: %d\n", ret); - return ret; - } + if (IS_ERR(codec->base)) + return PTR_ERR(codec->base);
codec->regmap = devm_regmap_init(dev, NULL, codec, &jz4770_codec_regmap_config);
Le dim. 7 mars 2021 à 15:21, Tang Bin tangbin@cmss.chinamobile.com a écrit :
The function devm_platform_ioremap_resource has already contained error message if failed, so remove superfluous dev_err here.
Signed-off-by: Zhang Shengju zhangshengju@cmss.chinamobile.com Signed-off-by: Tang Bin tangbin@cmss.chinamobile.com
Looks good.
Acked-by: Paul Cercueil paul@crapouillou.net
Cheers, -Paul
sound/soc/codecs/jz4770.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/sound/soc/codecs/jz4770.c b/sound/soc/codecs/jz4770.c index 298689a07..5a24471a5 100644 --- a/sound/soc/codecs/jz4770.c +++ b/sound/soc/codecs/jz4770.c @@ -900,11 +900,8 @@ static int jz4770_codec_probe(struct platform_device *pdev) codec->dev = dev;
codec->base = devm_platform_ioremap_resource(pdev, 0);
- if (IS_ERR(codec->base)) {
ret = PTR_ERR(codec->base);dev_err(dev, "Failed to ioremap mmio memory: %d\n", ret);return ret;- }
if (IS_ERR(codec->base))
return PTR_ERR(codec->base);codec->regmap = devm_regmap_init(dev, NULL, codec, &jz4770_codec_regmap_config);
-- 2.20.1.windows.1
On Sun, 7 Mar 2021 15:21:33 +0800, Tang Bin wrote:
The function devm_platform_ioremap_resource has already contained error message if failed, so remove superfluous dev_err here.
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: codecs/jz4770: Remove superfluous error message commit: 0f76a915201916dd3a21cebd7d528ca4b3112eb5
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks, Mark
participants (3)
-
Mark Brown -
Paul Cercueil -
Tang Bin