[alsa-devel] [PATCH] ALSA: sparc: Add missing kfree in error path
If 'of_ioremap' fails, then 'amd' should be freed, otherwise, there is a memory leak.
Signed-off-by: Christophe JAILLET christophe.jaillet@wanadoo.fr --- sound/sparc/amd7930.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/sound/sparc/amd7930.c b/sound/sparc/amd7930.c index 1b1a89e..784ceb8 100644 --- a/sound/sparc/amd7930.c +++ b/sound/sparc/amd7930.c @@ -956,6 +956,7 @@ static int snd_amd7930_create(struct snd_card *card, if (!amd->regs) { snd_printk(KERN_ERR "amd7930-%d: Unable to map chip registers.\n", dev); + kfree(amd); return -EIO; }
On Fri, 17 Jul 2015 20:33:21 +0200, Christophe JAILLET wrote:
If 'of_ioremap' fails, then 'amd' should be freed, otherwise, there is a memory leak.
Signed-off-by: Christophe JAILLET christophe.jaillet@wanadoo.fr
Applied, thanks.
Takashi
sound/sparc/amd7930.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/sound/sparc/amd7930.c b/sound/sparc/amd7930.c index 1b1a89e..784ceb8 100644 --- a/sound/sparc/amd7930.c +++ b/sound/sparc/amd7930.c @@ -956,6 +956,7 @@ static int snd_amd7930_create(struct snd_card *card, if (!amd->regs) { snd_printk(KERN_ERR "amd7930-%d: Unable to map chip registers.\n", dev);
kfree(amd);-- 2.1.4
participants (2)
-
Christophe JAILLET -
Takashi Iwai