[alsa-devel] [PATCH 0/5] treewide: Add missing breaks in switch/case
Found by grep. Uncompiled/untested.
Joe Perches (5): gpio-tps65910.c: Add missing breaks in switch/case tps65910-irq: Add missing breaks in switch/case ath5k: Add missing breaks in switch/case fusb300_udc: Add missing breaks in switch/case dbri: Add missing breaks in switch/case
drivers/gpio/gpio-tps65910.c | 2 ++ drivers/mfd/tps65910-irq.c | 2 ++ drivers/net/wireless/ath/ath5k/desc.c | 3 +++ drivers/usb/gadget/fusb300_udc.c | 3 +++ sound/sparc/dbri.c | 5 +++++ 5 files changed, 15 insertions(+), 0 deletions(-)
Signed-off-by: Joe Perches joe@perches.com --- sound/sparc/dbri.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/sound/sparc/dbri.c b/sound/sparc/dbri.c index 73f9cba..ca978b1 100644 --- a/sound/sparc/dbri.c +++ b/sound/sparc/dbri.c @@ -578,14 +578,19 @@ static __u32 reverse_bytes(__u32 b, int len) switch (len) { case 32: b = ((b & 0xffff0000) >> 16) | ((b & 0x0000ffff) << 16); + break; case 16: b = ((b & 0xff00ff00) >> 8) | ((b & 0x00ff00ff) << 8); + break; case 8: b = ((b & 0xf0f0f0f0) >> 4) | ((b & 0x0f0f0f0f) << 4); + break; case 4: b = ((b & 0xcccccccc) >> 2) | ((b & 0x33333333) << 2); + break; case 2: b = ((b & 0xaaaaaaaa) >> 1) | ((b & 0x55555555) << 1); + break; case 1: case 0: break;
On Sun, 2011-07-10 at 02:28 -0700, Joe Perches wrote:
defective patch, please ignore.
diff --git a/sound/sparc/dbri.c b/sound/sparc/dbri.c index 73f9cba..ca978b1 100644 --- a/sound/sparc/dbri.c +++ b/sound/sparc/dbri.c @@ -578,14 +578,19 @@ static __u32 reverse_bytes(__u32 b, int len) switch (len) { case 32: b = ((b & 0xffff0000) >> 16) | ((b & 0x0000ffff) << 16);
break;
Maybe add a comment for fall through use instead.
participants (1)
-
Joe Perches