Re: [alsa-devel] [PATCH v2 1/5] dmaengine: mmp_tdma: add mmp tdma support
On Mon, 2012-06-11 at 18:04 +0800, Zhangfei Gao wrote:
+static int mmp_tdma_clear_chan_irq(struct mmp_tdma_chan *tdmac) +{
u32 reg = readl(tdmac->reg_base + TDISR);if (reg & TDISR_COMP) {/* clear irq */reg &= ~TDISR_COMP;writel(reg, tdmac->reg_base + TDISR);return 0;}return -1;+}
-1? Please return a proper linux error code.
On Thu, Jun 14, 2012 at 6:43 PM, Vinod Koul vinod.koul@linux.intel.com wrote:
On Mon, 2012-06-11 at 18:04 +0800, Zhangfei Gao wrote:
+static int mmp_tdma_clear_chan_irq(struct mmp_tdma_chan *tdmac) +{
- u32 reg = readl(tdmac->reg_base + TDISR);
- if (reg & TDISR_COMP) {
- /* clear irq */
- reg &= ~TDISR_COMP;
- writel(reg, tdmac->reg_base + TDISR);
- return 0;
- }
- return -1;
+}
-1? Please return a proper linux error code.
Thanks Vinod for careful review, my mistake, will resend the patch.
On Thu, Jun 14, 2012 at 6:43 PM, Vinod Koul vinod.koul@linux.intel.com wrote:
On Mon, 2012-06-11 at 18:04 +0800, Zhangfei Gao wrote:
+static int mmp_tdma_clear_chan_irq(struct mmp_tdma_chan *tdmac) +{
- u32 reg = readl(tdmac->reg_base + TDISR);
- if (reg & TDISR_COMP) {
- /* clear irq */
- reg &= ~TDISR_COMP;
- writel(reg, tdmac->reg_base + TDISR);
- return 0;
- }
- return -1;
+}
-1? Please return a proper linux error code.
-- ~Vinod
Hi, Vinod
The patch is updated, would you mind take a look, thanks.
participants (2)
-
Vinod Koul -
zhangfei gao