[alsa-devel] [PATCH] ASoC: omap: Enable COMPILE_TEST build for DT platforms
From: Mark Brown broonie@linaro.org
The DT platforms don't have any source dependency on any OMAP stuff so allow them to be built when COMPILE_TEST is enabled.
Signed-off-by: Mark Brown broonie@linaro.org --- sound/soc/omap/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/sound/soc/omap/Kconfig b/sound/soc/omap/Kconfig index 9f5d55e..68dfc0a 100644 --- a/sound/soc/omap/Kconfig +++ b/sound/soc/omap/Kconfig @@ -1,6 +1,6 @@ config SND_OMAP_SOC tristate "SoC Audio for the Texas Instruments OMAP chips" - depends on ARCH_OMAP && DMA_OMAP + depends on (ARCH_OMAP && DMA_OMAP) || COMPILE_TEST select SND_SOC_DMAENGINE_PCM
config SND_OMAP_SOC_DMIC @@ -26,7 +26,7 @@ config SND_OMAP_SOC_N810
config SND_OMAP_SOC_RX51 tristate "SoC Audio support for Nokia RX-51" - depends on SND_OMAP_SOC && MACH_NOKIA_RX51 + depends on SND_OMAP_SOC && (MACH_NOKIA_RX51 || COMPILE_TEST) select SND_OMAP_SOC_MCBSP select SND_SOC_TLV320AIC3X select SND_SOC_TPA6130A2 @@ -87,7 +87,7 @@ config SND_OMAP_SOC_OMAP_TWL4030
config SND_OMAP_SOC_OMAP_ABE_TWL6040 tristate "SoC Audio support for OMAP boards using ABE and twl6040 codec" - depends on TWL6040_CORE && SND_OMAP_SOC && ARCH_OMAP4 + depends on TWL6040_CORE && SND_OMAP_SOC && (ARCH_OMAP4 || COMPILE_TEST) select SND_OMAP_SOC_DMIC select SND_OMAP_SOC_MCPDM select SND_SOC_TWL6040
Hi,
On Mon, Jul 15, 2013 at 04:57:56PM +0100, Mark Brown wrote:
@@ -26,7 +26,7 @@ config SND_OMAP_SOC_N810
config SND_OMAP_SOC_RX51 tristate "SoC Audio support for Nokia RX-51"
- depends on SND_OMAP_SOC && MACH_NOKIA_RX51
- depends on SND_OMAP_SOC && (MACH_NOKIA_RX51 || COMPILE_TEST)
RX51 is OMAP3, and that's DT at all. This is likely just a case of updating commit log.
On Mon, Jul 15, 2013 at 07:00:45PM +0300, Felipe Balbi wrote:
On Mon, Jul 15, 2013 at 04:57:56PM +0100, Mark Brown wrote:
@@ -26,7 +26,7 @@ config SND_OMAP_SOC_N810
config SND_OMAP_SOC_RX51 tristate "SoC Audio support for Nokia RX-51"
- depends on SND_OMAP_SOC && MACH_NOKIA_RX51
- depends on SND_OMAP_SOC && (MACH_NOKIA_RX51 || COMPILE_TEST)
RX51 is OMAP3, and that's DT at all. This is likely just a case of updating commit log.
Sentence parse grammar not.
However... if you look at the driver it actually does have DT support in there, it checks for the machine type or for compatibility with n900. Probably needs an ARM dependency which I'll add due to the machine type check.
On Mon, Jul 15, 2013 at 05:26:05PM +0100, Mark Brown wrote:
On Mon, Jul 15, 2013 at 07:00:45PM +0300, Felipe Balbi wrote:
On Mon, Jul 15, 2013 at 04:57:56PM +0100, Mark Brown wrote:
@@ -26,7 +26,7 @@ config SND_OMAP_SOC_N810
config SND_OMAP_SOC_RX51 tristate "SoC Audio support for Nokia RX-51"
- depends on SND_OMAP_SOC && MACH_NOKIA_RX51
- depends on SND_OMAP_SOC && (MACH_NOKIA_RX51 || COMPILE_TEST)
RX51 is OMAP3, and that's DT at all. This is likely just a case of
^ not
updating commit log.
Sentence parse grammar not.
However... if you look at the driver it actually does have DT support in there, it checks for the machine type or for compatibility with n900. Probably needs an ARM dependency which I'll add due to the machine type check.
alright.
Hi Mark,
On 07/15/2013 05:57 PM, Mark Brown wrote:
From: Mark Brown broonie@linaro.org
The DT platforms don't have any source dependency on any OMAP stuff so allow them to be built when COMPILE_TEST is enabled.
The OMAP3 generic machine driver could be also included in this patch: SND_OMAP_SOC_OMAP_TWL4030
Signed-off-by: Mark Brown broonie@linaro.org
Otherwise: Acked-by: Peter Ujfalusi peter.ujfalusi@ti.com
sound/soc/omap/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/sound/soc/omap/Kconfig b/sound/soc/omap/Kconfig index 9f5d55e..68dfc0a 100644 --- a/sound/soc/omap/Kconfig +++ b/sound/soc/omap/Kconfig @@ -1,6 +1,6 @@ config SND_OMAP_SOC tristate "SoC Audio for the Texas Instruments OMAP chips"
- depends on ARCH_OMAP && DMA_OMAP
- depends on (ARCH_OMAP && DMA_OMAP) || COMPILE_TEST select SND_SOC_DMAENGINE_PCM
config SND_OMAP_SOC_DMIC @@ -26,7 +26,7 @@ config SND_OMAP_SOC_N810
config SND_OMAP_SOC_RX51 tristate "SoC Audio support for Nokia RX-51"
- depends on SND_OMAP_SOC && MACH_NOKIA_RX51
- depends on SND_OMAP_SOC && (MACH_NOKIA_RX51 || COMPILE_TEST) select SND_OMAP_SOC_MCBSP select SND_SOC_TLV320AIC3X select SND_SOC_TPA6130A2
@@ -87,7 +87,7 @@ config SND_OMAP_SOC_OMAP_TWL4030
config SND_OMAP_SOC_OMAP_ABE_TWL6040 tristate "SoC Audio support for OMAP boards using ABE and twl6040 codec"
- depends on TWL6040_CORE && SND_OMAP_SOC && ARCH_OMAP4
- depends on TWL6040_CORE && SND_OMAP_SOC && (ARCH_OMAP4 || COMPILE_TEST) select SND_OMAP_SOC_DMIC select SND_OMAP_SOC_MCPDM select SND_SOC_TWL6040
On Mon, Jul 15, 2013 at 06:43:46PM +0200, Peter Ujfalusi wrote:
On 07/15/2013 05:57 PM, Mark Brown wrote:
From: Mark Brown broonie@linaro.org
The DT platforms don't have any source dependency on any OMAP stuff so allow them to be built when COMPILE_TEST is enabled.
The OMAP3 generic machine driver could be also included in this patch: SND_OMAP_SOC_OMAP_TWL4030
There's no need for that - it has no dependencies other than the TWL4030 core driver and SND_OMAP_SOC so as soon as SND_OMAP_SOC can be enabled it is too.
participants (3)
-
Felipe Balbi -
Mark Brown -
Peter Ujfalusi