[PATCH] ASoC: codec: rt5640: Resolve failure to set DMIC clock after playback
From: Ondrej Jirman megi@xff.cz
rt5640_set_dai_sysclk is called with freq == 0 when playback stops. This causes DMIC setup code to fail. I2S interface doesn't need to be active for codec to work, so don't clear rt5640->sysclk after rt5640_set_dai_sysclk is called with freq == 0.
Signed-off-by: Ondrej Jirman megi@xff.cz Signed-off-by: Jarrah Gosbell kernel@undef.tools --- sound/soc/codecs/rt5640.c | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/sound/soc/codecs/rt5640.c b/sound/soc/codecs/rt5640.c index 18e01949f20e..054de41ceccb 100644 --- a/sound/soc/codecs/rt5640.c +++ b/sound/soc/codecs/rt5640.c @@ -1839,6 +1839,9 @@ static int rt5640_set_dai_sysclk(struct snd_soc_dai *dai, unsigned int reg_val = 0; unsigned int pll_bit = 0;
+ if (freq == 0) + return 0; + switch (clk_id) { case RT5640_SCLK_S_MCLK: reg_val |= RT5640_SCLK_SRC_MCLK;
On Sat, Jan 14, 2023 at 12:30:54AM +0000, Jarrah Gosbell wrote:
rt5640_set_dai_sysclk is called with freq == 0 when playback stops. This causes DMIC setup code to fail. I2S interface doesn't need to be active for codec to work, so don't clear rt5640->sysclk after rt5640_set_dai_sysclk is called with freq == 0.
The goal with set_sysclk() is to record the current clock frequency, if the clock is stopped it should be set to zero. If a machine driver is setting the input clock to zero when it's still being provided then it should be fixed. If the device doesn't need a clock for DMIC (which seems dubious) then whatever is checking for a clock should be fixed.
participants (1)
-
Jarrah Gosbell
-
Mark Brown