[PATCH v2] ASoC: SOF: Makefile: Fix randconfig sof-client build when SND_SOC_SOF=y
Intel's kernel test robot found the following randconfig combination: SND_SOC_SOF=y SND_SOC_SOF_CLIENT=m
In this the sof-client object is not going to be built into the snd-sof.o and we will have undefined references to the sof-client functions.
Fixes: 6955d9512d0e ("ASoC: SOF: Introduce IPC SOF client support") Reported-by: kernel test robot lkp@intel.com Signed-off-by: Peter Ujfalusi <Peter Ujfalusi peter.ujfalusi@linux.intel.com> --- Hi Mark, Pierre,
Changes since v1: - fix author and SoB from gmail.com to linux.intel.com
When the client support was added we did some permutation tests (at least I did) but missed this combination. It is a valid one for sure and the proper fix is via the Makefile.
Sorry for mising this
Regards, Peter
sound/soc/sof/Makefile | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/sound/soc/sof/Makefile b/sound/soc/sof/Makefile index 4d31282c847d..a0459f06c68a 100644 --- a/sound/soc/sof/Makefile +++ b/sound/soc/sof/Makefile @@ -2,7 +2,9 @@
snd-sof-objs := core.o ops.o loader.o ipc.o pcm.o pm.o debug.o topology.o\ control.o trace.o iomem-utils.o sof-audio.o stream-ipc.o -snd-sof-$(CONFIG_SND_SOC_SOF_CLIENT) += sof-client.o +ifneq ($(CONFIG_SND_SOC_SOF_CLIENT),) +snd-sof-objs += sof-client.o +endif
snd-sof-$(CONFIG_SND_SOC_SOF_COMPRESS) += compress.o
On Mon, 14 Feb 2022 09:13:30 +0200, Peter Ujfalusi wrote:
Intel's kernel test robot found the following randconfig combination: SND_SOC_SOF=y SND_SOC_SOF_CLIENT=m
In this the sof-client object is not going to be built into the snd-sof.o and we will have undefined references to the sof-client functions.
[...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: SOF: Makefile: Fix randconfig sof-client build when SND_SOC_SOF=y commit: 4965e38fa064056021254af4656b1089a42dc764
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks, Mark
participants (2)
-
Mark Brown -
Peter Ujfalusi