At Sun, 22 Feb 2009 18:58:45 +0100, Michael Schwingen wrote:

On Thu, Feb 05, 2009 at 08:28:50AM +0100, Takashi Iwai wrote:

...

The patch looks almost good but there are a few issues to fix.

First off, please use a unified diff (diff -u) for a patch. Then, rebase your patch to the latest sound git tree[*] or 2.6.29-rc3 at least. git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound-2.6.git

Some stuff in patch_realtek.c in the latest tree was changed to be incompatible from 2.6.28. For example,

...

• [ALC260_FAVORIT100] = {

• .mixers = { alc260_favorit100_mixer,
  

• 	    alc260_capture_mixer },
  

The capture mixer is now created dynamically. Usually you don't need pass capture_mixer array here.

...

• .init_verbs = { alc260_acer_init_verbs },
  

Don't you use alc260_favorit100_init_verbs?

Could you fix these and repost?

Here is the updated patch, against the git version - is the diff format OK now?

Yes, it was merged to sound tree. Sorry, forgot to notify you.

Thanks!

Takashi