[alsa-devel] [PATCH] S3C64XX I2S: Enable audio-bus clock
Added the missing clk_enable after acquiring the 'audio-bus' clock.
Signed-off-by: Jassi Brar jassi.brar@samsung.com --- sound/soc/s3c24xx/s3c64xx-i2s.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/sound/soc/s3c24xx/s3c64xx-i2s.c b/sound/soc/s3c24xx/s3c64xx-i2s.c index b67eed5..d68cae1 100644 --- a/sound/soc/s3c24xx/s3c64xx-i2s.c +++ b/sound/soc/s3c24xx/s3c64xx-i2s.c @@ -236,6 +236,8 @@ static __devinit int s3c64xx_iis_dev_probe(struct platform_device *pdev) goto err; }
+ clk_enable(i2s->iis_cclk); + ret = s3c_i2sv2_probe(pdev, dai, i2s, 0); if (ret) goto err_clk;
On Fri, Nov 06, 2009 at 06:00:24PM +0900, Jassi Brar wrote:
Added the missing clk_enable after acquiring the 'audio-bus' clock.
I'll apply this but I beleive the driver ought to be smarter with the clocks - AFAICT from the documentation the audio bus clock is not guaranteed to be needed.
On Fri, Nov 6, 2009 at 10:13 PM, Mark Brown broonie@opensource.wolfsonmicro.com wrote:
On Fri, Nov 06, 2009 at 06:00:24PM +0900, Jassi Brar wrote:
Added the missing clk_enable after acquiring the 'audio-bus' clock.
I'll apply this but I beleive the driver ought to be smarter with the clocks - AFAICT from the documentation the audio bus clock is not guaranteed to be needed.
this patch only adds the missing code, its no modification. s3c64xx-i2s driver sure needs to be upgraded, which i plan to do soon if nobody else does.
On Fri, Nov 06, 2009 at 11:48:30PM +0900, jassi brar wrote:
On Fri, Nov 6, 2009 at 10:13 PM, Mark Brown
I'll apply this but I beleive the driver ought to be smarter with the clocks - AFAICT from the documentation the audio bus clock is not guaranteed to be needed.
this patch only adds the missing code, its no modification.
I'm not sure what you mean by that? Presumably any system that's managing to use the driver as-is is doing so by clocking the block from something other than the audio clock so from their point of view it isn't needed.
s3c64xx-i2s driver sure needs to be upgraded, which i plan to do soon if nobody else does.
Any news on IISv4 port support? It'd be good to get the SMDKs to the point where they can actually play audio. I had been expecting some followups from your previous patches.
On Sat, Nov 7, 2009 at 12:09 AM, Mark Brown broonie@opensource.wolfsonmicro.com wrote:
On Fri, Nov 06, 2009 at 11:48:30PM +0900, jassi brar wrote:
On Fri, Nov 6, 2009 at 10:13 PM, Mark Brown
I'll apply this but I beleive the driver ought to be smarter with the clocks - AFAICT from the documentation the audio bus clock is not guaranteed to be needed.
this patch only adds the missing code, its no modification.
I'm not sure what you mean by that?
Sorry, if its hard to understand what i write. I will write detailed explanation.
Seems the clk_enable for cclk went 'missing' during segregation of one driver into separate SoC specific(s3c2412, s3c64xx) and version specific(s3c-i2s-v2) parts.. PCLK(iis) and CLKAUDIO(audio-bus) are equally potential candidates of I2S source clock. If the driver gets and enables 'iis' there is no reason why it should only get and not enable 'audio-bus'.
By the design of the driver, clk_enable for 'audio-bus' too ought to be in driver (just like 'iis'). If some user is enabling it somewhere else, he/she is not in line with the design.
Presumably any system that's managing to use the driver as-is is doing so by clocking the block from something other than the audio clock so from their point of view it isn't needed.
Why overlook the right but missing part? just because users have a work around?
s3c64xx-i2s driver sure needs to be upgraded, which i plan to do soon if nobody else does.
Any news on IISv4 port support? It'd be good to get the SMDKs to the point where they can actually play audio. I had been expecting some followups from your previous patches.
I will resend some patches which were given reviews. I just got busy. Due to different official priorities, the 6channel support implementation got delayed. It is definitely on my todo list.
On Sat, Nov 07, 2009 at 12:03:34PM +0900, jassi brar wrote:
By the design of the driver, clk_enable for 'audio-bus' too ought to be in driver (just like 'iis'). If some user is enabling it somewhere else, he/she is not in line with the design.
I suspect that these users were just never enabling the clock at all rather than enabling it somewhere else.
Any news on IISv4 port support? It'd be good to get the SMDKs to the point where they can actually play audio. I had been expecting some followups from your previous patches.
I will resend some patches which were given reviews. I just got busy. Due to different official priorities, the 6channel support implementation got delayed. It is definitely on my todo list.
OK, thanks. Even two channel support for the port would be good since it'd make it much easier for me to do the enhancements to the wm8580 driver that we were talking about.
participants (3)
-
Jassi Brar -
jassi brar -
Mark Brown