From: Tom Rix trix@redhat.com

Static analysis reports this problem clock.c:338:10: warning: The right operand of '==' is a garbage value if (i == cur) ^ ~~~

In __uac_clock_find_source() the goto find_others skips over setting of the 'cur' variable. Since the pin loop variable starts with 1, it is safe to initialize cur to 0.

Signed-off-by: Tom Rix trix@redhat.com --- sound/usb/clock.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/sound/usb/clock.c b/sound/usb/clock.c index 772478c725c2e..edc458c50bf2c 100644 --- a/sound/usb/clock.c +++ b/sound/usb/clock.c @@ -258,9 +258,10 @@ static int __uac_clock_find_source(struct snd_usb_audio *chip, union uac23_clock_source_desc *source; union uac23_clock_selector_desc *selector; union uac23_clock_multiplier_desc *multiplier; - int ret, i, cur, err, pins, clock_id; + int ret, i, err, pins, clock_id; const u8 *sources; int proto = fmt->protocol; + int cur = 0;

entity_id &= 0xff;