[PATCH RESEND] soundwire: amd: clear wake enable register for power off mode
As per design for power off mode, clear the wake enable register during resume sequence.
Signed-off-by: Vijendar Mukunda Vijendar.Mukunda@amd.com --- drivers/soundwire/amd_manager.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/soundwire/amd_manager.c b/drivers/soundwire/amd_manager.c index 5a4bfaef65fb..96a3aa6da711 100644 --- a/drivers/soundwire/amd_manager.c +++ b/drivers/soundwire/amd_manager.c @@ -1190,6 +1190,7 @@ static int __maybe_unused amd_resume_runtime(struct device *dev) if (amd_manager->power_mode_mask & AMD_SDW_CLK_STOP_MODE) { return amd_sdw_clock_stop_exit(amd_manager); } else if (amd_manager->power_mode_mask & AMD_SDW_POWER_OFF_MODE) { + writel(0x00, amd_manager->acp_mmio + ACP_SW_WAKE_EN(amd_manager->instance)); val = readl(amd_manager->mmio + ACP_SW_CLK_RESUME_CTRL); if (val) { val |= AMD_SDW_CLK_RESUME_REQ;
On 12/3/2024 03:21, Vijendar Mukunda wrote:
As per design for power off mode, clear the wake enable register during resume sequence.
Signed-off-by: Vijendar Mukunda Vijendar.Mukunda@amd.com
Hi Vinod,
Can you please pick up this patch? There is other work that needs to build on it that is currently blocked. It's been on the list for nearly a month [1] along with a resend [2] with no feedback.
[1] https://lore.kernel.org/alsa-devel/20241112185138.3235375-1-Vijendar.Mukunda... [2] https://lore.kernel.org/alsa-devel/20241203092144.4096986-1-Vijendar.Mukunda...
Thanks,
drivers/soundwire/amd_manager.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/soundwire/amd_manager.c b/drivers/soundwire/amd_manager.c index 5a4bfaef65fb..96a3aa6da711 100644 --- a/drivers/soundwire/amd_manager.c +++ b/drivers/soundwire/amd_manager.c @@ -1190,6 +1190,7 @@ static int __maybe_unused amd_resume_runtime(struct device *dev) if (amd_manager->power_mode_mask & AMD_SDW_CLK_STOP_MODE) { return amd_sdw_clock_stop_exit(amd_manager); } else if (amd_manager->power_mode_mask & AMD_SDW_POWER_OFF_MODE) {
writel(0x00, amd_manager->acp_mmio + ACP_SW_WAKE_EN(amd_manager->instance));
On 12/12/2024 16:30, Mario Limonciello wrote:
On 12/3/2024 03:21, Vijendar Mukunda wrote:
As per design for power off mode, clear the wake enable register during resume sequence.
Signed-off-by: Vijendar Mukunda Vijendar.Mukunda@amd.com
Hi Vinod,
Can you please pick up this patch? There is other work that needs to build on it that is currently blocked. It's been on the list for nearly a month [1] along with a resend [2] with no feedback.
[1] https://lore.kernel.org/alsa-devel/20241112185138.3235375-1- Vijendar.Mukunda@amd.com/ [2] https://lore.kernel.org/alsa-devel/20241203092144.4096986-1- Vijendar.Mukunda@amd.com/
Thanks,
Hi Vinod,
Ping on this.
Bard,
You're also a maintainer in drivers/soundwire, can you take this instead?
Or can you Ack it and let it go through Mark's tree with ASoC stuff instead perhaps?
Thanks,
drivers/soundwire/amd_manager.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/soundwire/amd_manager.c b/drivers/soundwire/ amd_manager.c index 5a4bfaef65fb..96a3aa6da711 100644 --- a/drivers/soundwire/amd_manager.c +++ b/drivers/soundwire/amd_manager.c @@ -1190,6 +1190,7 @@ static int __maybe_unused amd_resume_runtime(struct device *dev) if (amd_manager->power_mode_mask & AMD_SDW_CLK_STOP_MODE) { return amd_sdw_clock_stop_exit(amd_manager); } else if (amd_manager->power_mode_mask & AMD_SDW_POWER_OFF_MODE) { + writel(0x00, amd_manager->acp_mmio + ACP_SW_WAKE_EN(amd_manager->instance)); val = readl(amd_manager->mmio + ACP_SW_CLK_RESUME_CTRL); if (val) { val |= AMD_SDW_CLK_RESUME_REQ;
participants (2)
-
Mario Limonciello -
Vijendar Mukunda