I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by: Chuansheng Liu chuansheng.liu@intel.com Signed-off-by: Baole Ni baolex.ni@intel.com --- sound/core/timer.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/core/timer.c b/sound/core/timer.c index e722022..07ec222 100644 --- a/sound/core/timer.c +++ b/sound/core/timer.c @@ -46,9 +46,9 @@ static int timer_tstamp_monotonic = 1; MODULE_AUTHOR("Jaroslav Kysela perex@perex.cz, Takashi Iwai tiwai@suse.de"); MODULE_DESCRIPTION("ALSA timer interface"); MODULE_LICENSE("GPL"); -module_param(timer_limit, int, 0444); +module_param(timer_limit, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(timer_limit, "Maximum global timers in system."); -module_param(timer_tstamp_monotonic, int, 0444); +module_param(timer_tstamp_monotonic, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(timer_tstamp_monotonic, "Use posix monotonic clock source for timestamps (default).");

MODULE_ALIAS_CHARDEV(CONFIG_SND_MAJOR, SNDRV_MINOR_TIMER);