[alsa-devel] [PATCH v2] ASoC: mxs-pcm: Fix fifo size
From: Fabio Estevam fabio.estevam@freescale.com
According to MX28 Reference Manual the SAIF FIFO contains four 32-bit entries.
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com --- Changes since v1: - Fix info about FIFO size sound/soc/mxs/mxs-pcm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/mxs/mxs-pcm.c b/sound/soc/mxs/mxs-pcm.c index f82d766..6b360d0 100644 --- a/sound/soc/mxs/mxs-pcm.c +++ b/sound/soc/mxs/mxs-pcm.c @@ -60,7 +60,7 @@ static struct snd_pcm_hardware snd_mxs_hardware = { .periods_min = 1, .periods_max = 52, .buffer_bytes_max = 64 * 1024, - .fifo_size = 32, + .fifo_size = 4,
};
On 2 November 2012 23:06, Mark Brown broonie@opensource.wolfsonmicro.com wrote:
On Wed, Oct 31, 2012 at 03:06:11PM -0200, Fabio Estevam wrote:
According to MX28 Reference Manual the SAIF FIFO contains four 32-bit entries.
.fifo_size = 32,
.fifo_size = 4,fifo_size should be specified in bytes so the original code looks correct?
Then, probably it should be 16. BTW, it seems this param is not used anymore: http://www.alsa-project.org/~tiwai/writing-an-alsa-driver/ch05s05.html That may be the reason why i see some other platforms pcm code just set fifo_size to 0.
Regards Dong Aisheng
On Sat, Nov 03, 2012 at 04:04:02AM +0800, Dong Aisheng wrote:
On 2 November 2012 23:06, Mark Brown
On Wed, Oct 31, 2012 at 03:06:11PM -0200, Fabio Estevam wrote:
According to MX28 Reference Manual the SAIF FIFO contains four 32-bit entries.
.fifo_size = 32,
.fifo_size = 4,
fifo_size should be specified in bytes so the original code looks correct?
Then, probably it should be 16.
Yup.
BTW, it seems this param is not used anymore: http://www.alsa-project.org/~tiwai/writing-an-alsa-driver/ch05s05.html That may be the reason why i see some other platforms pcm code just set fifo_size to 0.
Hrm, right - that'll be why nobody noticed. Guess it doesn't matter any more.
participants (3)
-
Dong Aisheng -
Fabio Estevam -
Mark Brown