On Thu, Oct 20, 2016 at 12:26:16PM +0200, Lukas Wunner wrote:

skl_probe() releases a runtime pm ref unconditionally wheras skl_remove() acquires one only if the device is wakeup capable. Thus if the device is not wakeup capable, unloading and reloading the module will result in the refcount being decreased below 0. Fix it.

Hi Lukas,

Thanks for the patch, have you tested this?

I did some tests last week and I dont remember module load/unload having an issue.. I will test again next week and get back.

Was this found on hardware or by code inspection..