[alsa-devel] [alsa-lib][PATCH] ctl: fix a test for user-defined element set in a point of dimension
Currently, this test program has a bug related to dimension information. When testing an element set with byte type, the program adds 512 members to an element. This is a maximum number permitted for this type.
On the other hand, dimension information of the elements consists of [8, 4, 8, 4]. Calculated members in the multi-dimensional matrix is 1024. This should be less than 512.
This commit fixes the bug.
Signed-off-by: Takashi Sakamoto o-takashi@sakamocchi.jp --- test/user-ctl-element-set.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test/user-ctl-element-set.c b/test/user-ctl-element-set.c index c346e03..0481300 100644 --- a/test/user-ctl-element-set.c +++ b/test/user-ctl-element-set.c @@ -513,7 +513,7 @@ int main(void) trial.dimension[0] = 8; trial.dimension[1] = 4; trial.dimension[2] = 8; - trial.dimension[3] = 4; + trial.dimension[3] = 2; trial.add_elem_set = add_bytes_elem_set; trial.check_elem_props = NULL; trial.change_elem_members = change_bytes_elem_members;
On Thu, 07 Jul 2016 16:22:21 +0200, Takashi Sakamoto wrote:
Currently, this test program has a bug related to dimension information. When testing an element set with byte type, the program adds 512 members to an element. This is a maximum number permitted for this type.
On the other hand, dimension information of the elements consists of [8, 4, 8, 4]. Calculated members in the multi-dimensional matrix is 1024. This should be less than 512.
This commit fixes the bug.
Signed-off-by: Takashi Sakamoto o-takashi@sakamocchi.jp
Applied, thanks.
Takashi
participants (2)
-
Takashi Iwai
-
Takashi Sakamoto