[alsa-devel] [PATCH 2/2] configure.in: don't rely on test -a, not all shells support it
Notably, /bin/sh in Debian and Ubuntu is dash, which doesn't. --- configure.in | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/configure.in b/configure.in index e904956..c353759 100644 --- a/configure.in +++ b/configure.in @@ -119,7 +119,7 @@ if test "$versioned" = "yes"; then major=`echo $xres | cut -d . -f 1` minor=`echo $xres | cut -d . -f 2` pass=0 - if test $major -eq 1 -a $minor -gt 3; then + if test $major -eq 1 && test $minor -gt 3; then pass=1 else if test $major -gt 1; then
On Fri, 08 Oct 2010 at 09:06:58 +0100, Simon McVittie wrote:
Notably, /bin/sh in Debian and Ubuntu is dash, which doesn't.
Sorry, I'd misinterpreted the error produced when grep fails (fixed by patch 1/2). Recent dash versions do support test -a, so patch 2/2 turns out to be unnecessary on current Debian, although it might conceivably be useful for backports to older Ubuntu versions.
S
At Fri, 8 Oct 2010 09:31:53 +0100, Simon McVittie wrote:
On Fri, 08 Oct 2010 at 09:06:58 +0100, Simon McVittie wrote:
Notably, /bin/sh in Debian and Ubuntu is dash, which doesn't.
Sorry, I'd misinterpreted the error produced when grep fails (fixed by patch 1/2). Recent dash versions do support test -a, so patch 2/2 turns out to be unnecessary on current Debian, although it might conceivably be useful for backports to older Ubuntu versions.
Yeah, the patch is still useful. I applied it with added "older" word in the changelog.
thanks,
Takashi
participants (2)
-
Simon McVittie -
Takashi Iwai