[alsa-devel] [PATCH] ALSA: nm256: constify snd_ac97_res_table
snd_ac97_res_table are not supposed to change at runtime. All functions working with snd_ac97_res_table provided by <sound/ac97_codec.h> work with const snd_ac97_res_table. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav arvind.yadav.cs@gmail.com --- sound/pci/nm256/nm256.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/pci/nm256/nm256.c b/sound/pci/nm256/nm256.c index 0ef8054..b97f4ea 100644 --- a/sound/pci/nm256/nm256.c +++ b/sound/pci/nm256/nm256.c @@ -1271,7 +1271,7 @@ static int nm256_ac97_idx(unsigned short reg) }
/* static resolution table */ -static struct snd_ac97_res_table nm256_res_table[] = { +static const struct snd_ac97_res_table nm256_res_table[] = { { AC97_MASTER, 0x1f1f }, { AC97_HEADPHONE, 0x1f1f }, { AC97_MASTER_MONO, 0x001f },
On Thu, 24 Aug 2017 08:25:28 +0200, Arvind Yadav wrote:
snd_ac97_res_table are not supposed to change at runtime. All functions working with snd_ac97_res_table provided by <sound/ac97_codec.h> work with const snd_ac97_res_table. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav arvind.yadav.cs@gmail.com
Applied, thanks.
Takashi
participants (2)
-
Arvind Yadav
-
Takashi Iwai